From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CDF7E6FE4B for ; Fri, 6 Sep 2024 23:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject: References:In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fogRVChcIjGKXi1embF1uu5zfnyMHIdxyguDOltwxtc=; b=fLrtsyOegjEZHAxMx0vJ+AfvC9 fY8mWAPDdyd6+vIN9QwXDSgQ0qkDZCa0ZOgwkBwDkhgBOyF7Wy+wHTRB/EdjZ6194RIumpWguiGPf nkdcCEoWQqNTSKNvA8toyeOPX5yYiyspB/VroBh76xsOcu6lq+MLSUaEu8+1Qq3UcXUakLuXKRqC4 CAXLafwosW8VbMssYtDzaBetYBY/UyNmuYEW3u9Ls6U/BPEgJDH5eWN4k0XBLYXd6OkxsHCjs7kt+ xTHjiBp0t3DFA2Eb7maIEiTS5xX5s0YoY5Pey85SxRx6Ds3Q2A+/SQ9seM86cg95E6cWcd6IEYtDB 5NljcMhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smhyz-0000000DpMs-2odB; Fri, 06 Sep 2024 23:03:13 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smhy0-0000000DpDp-0aZG; Fri, 06 Sep 2024 23:02:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D5000A410E7; Fri, 6 Sep 2024 23:02:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF4F0C4CEC5; Fri, 6 Sep 2024 23:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725663730; bh=ldflI04Ts9BSmUuRhFXFjpTFI7d5OrKXMZDtQeiJu+k=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=oHUoICWtCtwGqLgYdGmyD7Ju3yflh55yITURS00j6N3pfj4WeVnawdt9gwXlExhRb nQVWElBJa+7LSNjsiIAQD4ZefcamFbwjfAwhOWd9Jj8i87bsfTsOYqpen2scJEpV+x it6MlCsWeQT6Fdq4SDovdESx8h7eHxHHcen8GNoMYES1fVfMFgU6zxbWD0t67j2/hk vkPNaf75x/KQpJtrSvwO7mwaaVc+rxjqjVpB5d7TtmI3DHjq8DqlVJgXoduUptF9FJ GNA8D5JDHOZVD0T4j6sJZAuCX8DqzuFLCShteQN2d7ouZcg4oHOYAvk79vgi8GHDkh 65bUcAV0YtX4A== Message-ID: <91eca16a2453514123e8ffd5346297eb.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <5168975.haC6HkEk0m@diego> References: <20240828101503.1478491-1-heiko@sntech.de> <20240828101503.1478491-5-heiko@sntech.de> <9b92b5f03632e8793253ba75fc00f6e3.sboyd@kernel.org> <5168975.haC6HkEk0m@diego> Subject: Re: [PATCH v3 4/5] clk: clk-gpio: add driver for gated-fixed-clocks From: Stephen Boyd Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org To: Heiko =?utf-8?q?St=C3=BCbner?= , mturquette@baylibre.com Date: Fri, 06 Sep 2024 16:02:08 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240906_160212_264273_3F00B3F4 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Heiko St=C3=BCbner (2024-09-05 15:48:35) > Am Mittwoch, 28. August 2024, 20:30:51 CEST schrieb Stephen Boyd: > > Quoting Heiko Stuebner (2024-08-28 03:15:02) >=20 > [leaving out all the "will fix" parts :-) ] >=20 > > > +static struct platform_driver gated_fixed_clk_driver =3D { > > > + .probe =3D clk_gated_fixed_probe, > > > + .driver =3D { > > > + .name =3D "gated-fixed-clk", > > > + .of_match_table =3D gated_fixed_clk_match_table, > > > + }, > > > +}; > > > +builtin_platform_driver(gated_fixed_clk_driver); > >=20 > > The comment above builtin_platform_driver says "Each driver may only use > > this macro once". Seems that we need to expand the macro. >=20 > each _driver_, not each file is the important point I think. Ok!