From: "Maxime Ripard" <mripard@kernel.org>
To: "Stefan Wahren" <wahrenst@gmx.net>
Cc: bcm-kernel-feedback-list@broadcom.com,
dri-devel@lists.freedesktop.org, kernel-list@raspberrypi.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
"Artur Petrosyan" <Arthur.Petrosyan@synopsys.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"David Airlie" <airlied@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Maíra Canal" <mcanal@igalia.com>,
"Minas Harutyunyan" <hminas@synopsys.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Subject: Re: [PATCH V2 07/16] drm/vc4: Get the rid of DRM_ERROR()
Date: Tue, 30 Jul 2024 06:30:58 +0000 [thread overview]
Message-ID: <91f9c77f71fb1bce513a02d5e2800f04@kernel.org> (raw)
In-Reply-To: <20240728114200.75559-8-wahrenst@gmx.net>
On Sun, 28 Jul 2024 13:41:51 +0200, Stefan Wahren wrote:
> DRM_ERROR() has been deprecated in favor of pr_err(). However, we
> should prefer to use drm_err() whenever possible so we get device-
> specific output with the error message. In error case of kcalloc,
> we can simply drop DRM_ERROR(), because kcalloc already logs errors.
>
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2024-07-30 6:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 11:41 [PATCH V2 00/16] ARM: bcm2835: Implement initial S2Idle for Raspberry Pi Stefan Wahren
2024-07-28 11:41 ` [PATCH V2 01/16] firmware: raspberrypi: Improve timeout warning Stefan Wahren
2024-08-12 20:51 ` Stefan Wahren
2024-08-13 20:21 ` Florian Fainelli
2024-07-28 11:41 ` [PATCH V2 02/16] mailbox: bcm2835: Fix timeout during suspend mode Stefan Wahren
2024-08-12 20:56 ` Stefan Wahren
2024-07-28 11:41 ` [PATCH V2 03/16] pmdomain: raspberrypi-power: Adjust packet definition Stefan Wahren
2024-07-28 11:41 ` [PATCH V2 04/16] pmdomain: raspberrypi-power: Add logging to rpi_firmware_set_power Stefan Wahren
2024-07-28 11:41 ` [PATCH V2 05/16] pmdomain: raspberrypi-power: set flag GENPD_FLAG_ACTIVE_WAKEUP Stefan Wahren
2024-08-12 21:04 ` Stefan Wahren
2024-08-14 12:25 ` Ulf Hansson
2024-07-28 11:41 ` [PATCH V2 06/16] drm/vc4: hdmi: Handle error case of pm_runtime_resume_and_get Stefan Wahren
2024-07-30 11:37 ` Maíra Canal
2024-07-30 13:32 ` Maxime Ripard
2024-07-28 11:41 ` [PATCH V2 07/16] drm/vc4: Get the rid of DRM_ERROR() Stefan Wahren
2024-07-30 6:30 ` Maxime Ripard [this message]
2024-07-30 11:19 ` Maíra Canal
2024-07-28 11:41 ` [PATCH V2 08/16] drm/vc4: hdmi: add PM suspend/resume support Stefan Wahren
2024-07-30 13:32 ` Maxime Ripard
2024-07-28 13:00 ` [PATCH V2 09/16] drm/vc4: v3d: simplify clock retrieval Stefan Wahren
2024-07-28 13:00 ` [PATCH V2 10/16] drm/vc4: v3d: add PM suspend/resume support Stefan Wahren
2024-07-28 13:00 ` [PATCH V2 11/16] usb: dwc2: debugfs: Print parameter no_clock_gating Stefan Wahren
2024-07-28 13:00 ` [PATCH V2 12/16] usb: dwc2: Add comment about BCM2848 ACPI ID Stefan Wahren
2024-07-28 13:00 ` [PATCH V2 13/16] usb: dwc2: Skip clock gating on Broadcom SoCs Stefan Wahren
2024-07-28 13:00 ` [PATCH V2 14/16] WIP: usb: dwc2: Implement recovery after PM domain off Stefan Wahren
2024-08-12 23:47 ` Stefan Wahren
2024-08-13 19:57 ` Doug Anderson
2024-08-14 12:01 ` Ulf Hansson
2024-08-14 21:48 ` Stefan Wahren
2024-08-15 19:37 ` Doug Anderson
2024-08-16 16:57 ` Stefan Wahren
2024-07-28 13:00 ` [PATCH V2 15/16] serial: 8250_bcm2835aux: add PM suspend/resume support Stefan Wahren
2024-08-14 12:18 ` Ulf Hansson
2024-08-14 20:54 ` Stefan Wahren
2024-07-28 13:00 ` [PATCH V2 16/16] ARM: bcm2835_defconfig: Enable SUSPEND Stefan Wahren
2024-07-30 11:23 ` [PATCH V2 09/16] drm/vc4: v3d: simplify clock retrieval Maíra Canal
2024-07-31 16:41 ` Stefan Wahren
2024-08-02 12:56 ` Maíra Canal
2024-08-02 13:00 ` Stefan Wahren
2024-08-07 14:31 ` Maíra Canal
2024-08-07 14:49 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f9c77f71fb1bce513a02d5e2800f04@kernel.org \
--to=mripard@kernel.org \
--cc=Arthur.Petrosyan@synopsys.com \
--cc=airlied@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=jassisinghbrar@gmail.com \
--cc=jirislaby@kernel.org \
--cc=kernel-list@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=pbrobinson@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).