From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF29C28CBC for ; Wed, 6 May 2020 17:24:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E87C20746 for ; Wed, 6 May 2020 17:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q2ZUlzU2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E87C20746 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=joFoixguR4M6JPCKN2x9rlS2KaTrc9JNA7ZU1wSV2bI=; b=q2ZUlzU28SGdpd c0Hb9uh1K3VM4/+onE1KNUDtnGtvw0vLY9Cp+8RIHM5WlNMJQYiZtUVd0QXn7c7jmvLjGCx2VLkqX mmXJry2csfsTwgs0dUeVGau/cxdGvPWMqbr++ddMXaz6hZMNTVdhfXGi1gJ7jOzoo/yxFbfuyqbHG prQptC6jd8wcXjewgCsUV72qh8VlJpWxFuzmRISezhRpJkbOgyqBkRdeEU1wbF6VKrdRW/fj9rVFh D3Wbxj2LgC5iJr0zRB17SJr4Deo7XjgmYg2cGwOncBrjtXGLla918qFX1oCtEyN49AlEDQ2/DwFW+ AO0NCDA9e46HVn24K8vQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWNmS-0008CM-4C; Wed, 06 May 2020 17:24:24 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWNmP-0008Bm-CZ; Wed, 06 May 2020 17:24:22 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 9DF802A23AD Subject: Re: [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe() To: Wei Yongjun , Matthias Brugger References: <20200506141317.119537-1-weiyongjun1@huawei.com> From: Enric Balletbo i Serra Message-ID: <923a48d8-eb9e-2729-a4be-dad63a6df28a@collabora.com> Date: Wed, 6 May 2020 19:24:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506141317.119537-1-weiyongjun1@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_102421_556478_D59A934D X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wei, Thank you for your patch. On 6/5/20 16:13, Wei Yongjun wrote: > Add the missing platform_device_unregister() before return > from mtk_mmsys_probe() in the error handling case. > > Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing") > Signed-off-by: Wei Yongjun Reviewed-by: Enric Balletbo i Serra > --- > drivers/soc/mediatek/mtk-mmsys.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index 05e322c9c301..05ce4cb464b0 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev) > > drm = platform_device_register_data(&pdev->dev, "mediatek-drm", > PLATFORM_DEVID_AUTO, NULL, 0); > - if (IS_ERR(drm)) > + if (IS_ERR(drm)) { > + platform_device_unregister(clks); > return PTR_ERR(drm); > + } > > return 0; > } > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel