From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 739A6C47073 for ; Wed, 10 Jan 2024 21:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9VUSBDIHPyhl2FEi53Njr2oT0yNf0TNTegkRHG1Ti4s=; b=0yAn7yySdOeSLc hGqxlEXDBSQAZQvaL2h9dcbEaYBS4H063GqT02Urgcj6r3OCQKach8D+0T2yF/EAsgiwnKNZLr4yS +B1EKlTC8sx+6O5ub5ninYCewYLy24dCPYZd6ugXENEttLpop6YkjoPVJjyNACw8/JFDK/yXKj/4t PDgHxGmA57hNqwCoETTkLmPsozUGQE4O+moAy6MIOVY6JbihfBTg12vs7IjERS3nwtMSrG1d6/DCA l/i+OvdPGc7iV5yMOrZYWfTYolWHicjS2nvKjbkeaSFckv42oCFd6Hh+2Z9gefzrKoOCLCyDcSdbR paOdW2v3VFm1YSHH0Pvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNgKe-00EJsj-1q; Wed, 10 Jan 2024 21:41:52 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNgKc-00EJry-00 for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 21:41:51 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d3ea5cc137so40202585ad.0 for ; Wed, 10 Jan 2024 13:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704922909; x=1705527709; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=HId8f3hkvGtnDismZhBcVXhWd29HmilwtOOYjG3JP0w=; b=YpYTaOjSMiQ+c/AhWWZMYAVmrmBk2JbeZVT4jGmcESBZhAJUauqexLmx5zhXRT8uk/ XoDMG2OgA/GzpkBiQQNE7uaHxpUyglfY2OoFZIhPxsbWtmD6H7K3dH4/dxWLngT6kHtq X8pQbhmiAwvoKAIfWE+5xDxDxet47ltWr5SvIV1LYPYnDztOnZh2IVgjtT5QvyUKmBrB fiOUW41C0vL7S7zSQtIPBURWjp3HWlLW/0HSmD40PQp/CKwJksPS28dOt1jUSZqcPwRg ouB507WGujIB8emsUikIcMaHosflwrGa3hRacBF4/KC7zb6FHuKXw1wvflcOlzfmekcG gbwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704922909; x=1705527709; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HId8f3hkvGtnDismZhBcVXhWd29HmilwtOOYjG3JP0w=; b=Ek5IJc4lQ14RTLG/xn3P4vPDhJv1ASG41PhByJTfIe9jdCB/cqm4YGlIz8XC+Uv9Gv sV8kJRcr10V117Y3/+XQDQAcHGhbsRYpaHK/XV4GDYVfyKjIP2jIUrEKpe/6fNziQH7B q21+JeN9blPVJVq6calPjNnbtrTI4wqCixkxsCIF8AzeCp4A6JG8fS8G3bgdkT8lbcB2 /yTG08w2Tu8y7NXprDcTU0YEGyNfyQl4jokhH7IEBjTzZzAKii+EIx9qLyFmh39mwu9D IsoJ0gi8udVKeu/kLEc8GMR7J1SUY9jOheCKoYu7inJg6vz0peb9nN4TOt9DTPhGZKSD vXXA== X-Gm-Message-State: AOJu0Yw40s/7CqHIKoNueJHDvyFfgn31vGsfcN0KumDc58OThX5aaiu+ TTSrWyFqUZLBn84zHdLKKTw= X-Google-Smtp-Source: AGHT+IEUyQyYeicmT88yj9ZQjWF+5ZnzsbxcWV9NwQBfyw8mdjrtSspcwIBzY9L+4XjDdlhnLm20WQ== X-Received: by 2002:a17:902:f54a:b0:1d0:7535:8b94 with SMTP id h10-20020a170902f54a00b001d075358b94mr231266plf.97.1704922908844; Wed, 10 Jan 2024 13:41:48 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id q22-20020a170902789600b001cfcc10491fsm4121526pll.161.2024.01.10.13.41.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jan 2024 13:41:47 -0800 (PST) Message-ID: <92625821-d79d-4aba-9bef-148f154be427@roeck-us.net> Date: Wed, 10 Jan 2024 13:41:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings Content-Language: en-US To: Krzysztof Kozlowski , Ninad Palsule , Conor Dooley Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, johannes.holland@infineon.com, broonie@kernel.org, patrick.rudolph@9elements.com, vincent@vtremblay.dev, peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com, bhelgaas@google.com, naresh.solanki@9elements.com, alexander.stein@ew.tq-group.com, festevam@denx.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org, geissonator@yahoo.com References: <20231212164004.1683589-1-ninad@linux.ibm.com> <20231212164004.1683589-8-ninad@linux.ibm.com> <20231212-avid-grill-dbead068fac8@spud> <73381bb0-7fa7-4a9e-88df-ab0063058e26@roeck-us.net> <20231212-mouth-choice-40a83caa34ec@spud> <2946fbb1-2a47-4d21-83dc-8e45bf6ba5a9@roeck-us.net> <60c8bbdb-4e08-44f0-88d4-ab164d4843b5@linux.ibm.com> <20240109-pep-coerce-2a86ae88753d@spud> <01974929-dfbf-4989-ba39-369e521827d0@linux.ibm.com> <3d194e84-bf1a-48e4-a376-e5c327c6508d@linaro.org> <2dd37d2b-28da-4e73-9047-61ec5d64bdb5@linux.ibm.com> <385b06e9-1daa-408a-a0ed-7b09d7d539df@linux.ibm.com> <3830c26d-96be-4084-a04d-8edb9ccbab5e@roeck-us.net> <32d46b64-d4a5-437a-8737-c2d172608559@linaro.org> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <32d46b64-d4a5-437a-8737-c2d172608559@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_134150_044353_757590B3 X-CRM114-Status: GOOD ( 28.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/10/24 12:34, Krzysztof Kozlowski wrote: > On 10/01/2024 20:06, Guenter Roeck wrote: >> On 1/10/24 09:54, Krzysztof Kozlowski wrote: >>> On 10/01/2024 16:54, Ninad Palsule wrote: >>>> Hello Krzysztof, >>>> >>>> >>>> On 1/10/24 09:37, Krzysztof Kozlowski wrote: >>>>> On 10/01/2024 15:31, Ninad Palsule wrote: >>>>>> Hello Krzysztof, >>>>>> >>>>>> >>>>>> >>>>>>>>>> I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad@linux.ibm.com/ >>>>>>>>> Why did you do that? It now just adds undocumented compatibles to the >>>>>>>>> driver. Please, as Rob requested, work with Lukas on his series to make >>>>>>>>> sure that these devices are documented. >>>>>>>> I think krzysztof kozlowski suggested to send these patches separately: >>>>>>>> https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f@linaro.org/ >>>>>>>> >>>>>>>> Did I misunderstood it? Do you guys want me to include that commit again? >>>>>>> My comment was in DTS thread under specific DTS patch. How did you >>>>>>> figure out it applies to driver and bindings? This does not make sense. >>>>>> Sorry for the misunderstanding. Where do you want me to add driver >>>>>> patch? Before all DTS patches or after all DTS patches? >>>>> Does not matter, why do you insist on combining them with DTS? Drivers >>>>> and bindings are going together. DTS better separate, although depending >>>>> on the case can be together. >>>>> >>>> I have combined DTS and Driver because DTS was using compatibility >>>> string which is not upstream yet hence I thought it is logical to send >>>> it under same patchset. >>> >>> Sometimes yes, sometimes not. DTS must not go via driver subsystem, so >>> sending it in the same patchset has implications on maintainers applying >>> it. Some like it, some don't and you will be nagged for combining them. >>> >> >> "DTS must not go via driver subsystem" >> >> I always thought the guideline was to submit separate _patches_ for dts >> and driver changes, but as part of a single series. I didn't know that >> there is a rule to submit separate patch _series_. I also didn't know >> (and as far as I know no one called me on it) that I am not supposed >> to _apply_ dts changes. So far, I typically applied dts changes together >> with driver patches after receiving an Acked-by: or Reviewed-by: >> from a devicetree maintainer. > > I did not notice you applying them, but such guideline - DTS must go via > respective SoC tree - was always repeated by me and SoC maintainers. > Just like gazillion other things probably was not documented... or even > if it was documented, it would be so deep among hundreds of other rules > nobody would find it. :) > >> >> This exchange suggests that I did it all wrong. Should I reject devicetree >> patches submitted as part of a driver patch series going forward ? > > I propose: just ignore them. The SoC maintainer will pick them up. > >> Should I not apply dts patches submitted as part of a patch series ? > > No, please do not apply them. > >> If so, it would help to have some documentation I can point to to explain >> the rationale to submitters (and myself). Also, in that case, how is the > > Yes, it would. I can try to create something. > >> synchronization between device tree patches and driver patches supposed >> to happen ? > > There should not be synchronization. Just to remind: we talk about DTS > (so also DTSI and DTSO), thus everything being in arch/*/boot/dts/. We > do not talk about DT bindings, right? The bindings are obvious (and > documented): preferably go via driver subsystem, with fallback/special > cases via SoC tree and fallback to Rob. > Sorry, misunderstanding on my side. I do not and never did apply patches in arch/*/boot/dts/. I referred to patches in Documentation/devicetree/ Sorry, I though you also referred to bindings. My bad. Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel