Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Linus Walleij <linusw@kernel.org>
Cc: soc@kernel.org, arm@kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] amlogic ARM64 DT updates for v7.2 take 1
Date: Tue, 2 Jun 2026 09:47:17 +0200	[thread overview]
Message-ID: <9267eeb5-a221-4108-bc7a-57e88347e7a7@linaro.org> (raw)
In-Reply-To: <CAD++jLkiZD6tyUW6k2wt_TD3MeLNVDZNa0N+Rhwb0mAAGfLMvA@mail.gmail.com>

Hi,

On 6/1/26 22:06, Linus Walleij wrote:
> Hi Neil,
> 
> thanks for your pull request!
> 
> On Thu, May 21, 2026 at 3:19 PM Neil Armstrong
> <neil.armstrong@linaro.org> wrote:
> 
>>         arm64: dts: amlogic: t7: khadas-vim4: Remove invalid property
> 
> This commit has a problematic Fixes:
> 
> commit 6f14ba3c3fa3d67b72e052f431f6776470eb2cbd
> Author: Ronald Claveau <linux-kernel-dev@aliel.fr>
> Date:   Mon Mar 30 14:11:21 2026 +0200
> 
>      arm64: dts: amlogic: t7: khadas-vim4: Remove invalid property
> 
>      Fix introduced invalid property for Khadas VIM4 sdcard regulator.
> 
>      arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dtb:
> regulator-sdcard-3v3 (regulator-fixed): Unevaluated properties are not
> allowed ('enable-active-low' was unexpected)
> 
>      Reported-by: kernel test robot <lkp@intel.com>
>      Closes: https://lore.kernel.org/oe-kbuild-all/202603290828.5gt393t6-lkp@intel.com/
>      Fixes: 60eff75ac67b ("arm64: dts: amlogic: t7: khadas-vim4: Add
> power regulators")
>      Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>      Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
>      Link: https://patch.msgid.link/20260330-fix-invalid-property-v2-1-228c51c8de93@aliel.fr
>      Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> 
> Commit 60eff75ac67b does not exist in the SoC tree nor in Torvalds'
> tree.
> 
> What's up here, it looks incorrect?

Yeah sorry it was probably based on an earlier apply for the previous rejected PR

The right commit is 8f4e4fbd5072 arm64: dts: amlogic: t7: khadas-vim4: Add power regulators

But since it's in the same PR I will just squash it...

@arnd I'll post a v2 of this PR with this issue fixed.

Thanks,
Neil

> 
> Can you look into it?
> 
> Yours,
> Linus Walleij



  parent reply	other threads:[~2026-06-02  7:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 13:19 [GIT PULL] amlogic ARM64 DT updates for v7.2 take 1 Neil Armstrong
2026-06-01 20:06 ` Linus Walleij
2026-06-02  5:47   ` Martin Blumenstingl
2026-06-02  7:47   ` Neil Armstrong [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-02  7:52 Neil Armstrong
2026-06-09 12:02 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9267eeb5-a221-4108-bc7a-57e88347e7a7@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=arm@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox