From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 14/17] aarch64: ilp32: use generic stat64 structure
Date: Thu, 05 Nov 2015 15:03:52 +0100 [thread overview]
Message-ID: <9280044.CblpxvJy8Z@wuerfel> (raw)
In-Reply-To: <1446507046-24604-15-git-send-email-ynorov@caviumnetworks.com>
On Tuesday 03 November 2015 02:30:43 Yury Norov wrote:
> Generic 32-bit and AARCH32 stat64 structures has same names.
> ILP32 needs generic stat64. So we can either make ILP32 mutual
> exclusive with AARCH32, or introduce __stat64, and where needed,
> cast stat64 to it with #define.
>
> Second option requires to duplicate cp_new_stat64 code. But we
> choose it, because it's more flexible to have independend support
> for ABIs.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> Reviewed-by: David Daney <david.daney@cavium.com>
I'm sorry I screwed up with the definition for stat64 in asm-generic,
by defining it to have too short st_{a,m,c}time members.
This means we have to introduce another 'struct stat64' variant already
to solve the y2038 problem, and I have patches for it already, to make
that implementation use the same structure as the 64-bit 'struct stat'
with 64-bit timestamps. There is also an ongoing effort from David Howells
to create a new 'struct statx' (or maybe xstat) system call with a
completely new layout.
I think here it would be better to avoid adding yet another version
for ilp32 mode, and we are better off defining 'struct stat64' in
the arm64 headers, and share either the normal arm32 syscall entry
(with the default asm-generic syscall) or the normal arm64 syscall
entry (as we will do for the future replacement).
Arnd
next prev parent reply other threads:[~2015-11-05 14:03 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 23:30 [RFC PATCH v6 00/17] ILP32 for ARM64 Yury Norov
2015-11-02 23:30 ` [PATCH v6 01/17] arm64:ilp32: add documentation on the ILP32 ABI " Yury Norov
2015-11-05 14:33 ` Arnd Bergmann
2015-11-02 23:30 ` [PATCH v6 02/17] arm64: ensure the kernel is compiled for LP64 Yury Norov
2015-11-02 23:30 ` [PATCH v6 03/17] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2015-11-02 23:30 ` [PATCH v6 04/17] arm64: change some CONFIG_COMPAT over to use CONFIG_AARCH32_EL0 instead Yury Norov
2015-11-02 23:30 ` [PATCH v6 05/17] arm64:ilp32: share signal structures between ILP32 and LP64 ABIs Yury Norov
2015-11-02 23:30 ` [PATCH v6 06/17] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov
2015-11-02 23:30 ` [PATCH v6 07/17] arm64:ilp32: add is_ilp32_compat_{task, thread} and TIF_32BIT_AARCH64 Yury Norov
2015-11-02 23:30 ` [PATCH v6 08/17] arm64:ilp32: share HWCAP between LP64 and ILP32 Yury Norov
2015-11-02 23:30 ` [PATCH v6 09/17] arm64:ilp32 use the native LP64 'start_thread' for ILP32 threads Yury Norov
2015-11-02 23:30 ` [PATCH v6 10/17] arm64:ilp32: support core dump generation for ILP32 Yury Norov
2015-11-02 23:30 ` [PATCH v6 11/17] ptrace: Allow compat to use the native siginfo Yury Norov
2015-11-05 13:53 ` Arnd Bergmann
2015-11-02 23:30 ` [PATCH v6 12/17] ilp32: common 32-bit wrappers Yury Norov
2015-11-02 23:30 ` [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2015-11-05 13:50 ` Arnd Bergmann
2015-11-11 17:54 ` Andreas Schwab
2015-11-11 20:40 ` Arnd Bergmann
2015-11-11 23:07 ` Andreas Schwab
2015-11-11 23:23 ` Arnd Bergmann
2015-11-12 8:58 ` Andreas Schwab
2015-11-12 9:22 ` Arnd Bergmann
2015-11-12 9:44 ` Andreas Schwab
2015-11-12 13:24 ` Arnd Bergmann
2015-11-12 13:47 ` Andreas Schwab
2015-11-13 15:34 ` Arnd Bergmann
2015-11-13 15:38 ` Andrew Pinski
2015-11-13 16:10 ` Arnd Bergmann
2015-11-15 15:18 ` Arnd Bergmann
2015-11-15 16:42 ` Chris Metcalf
2015-11-16 10:16 ` Joseph Myers
2015-11-16 11:00 ` Arnd Bergmann
2015-11-16 11:12 ` Joseph Myers
2015-11-16 11:40 ` Arnd Bergmann
2015-11-16 12:03 ` Joseph Myers
2015-11-16 12:12 ` Arnd Bergmann
2015-11-16 12:34 ` Joseph Myers
2015-11-16 13:15 ` Arnd Bergmann
2015-11-16 13:34 ` Andreas Schwab
2015-11-16 13:54 ` Arnd Bergmann
2015-11-02 23:30 ` [PATCH v6 14/17] aarch64: ilp32: use generic stat64 structure Yury Norov
2015-11-05 14:03 ` Arnd Bergmann [this message]
2015-11-02 23:30 ` [PATCH v6 15/17] arm64:ilp32: use the native siginfo instead of the compat siginfo Yury Norov
2015-11-02 23:30 ` [PATCH v6 16/17] arm64:ilp32: change COMPAT_ELF_PLATFORM to report a a subplatform for ILP32 Yury Norov
2015-11-02 23:30 ` [PATCH v6 17/17] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov
2015-11-05 11:36 ` [RFC PATCH v6 00/17] ILP32 for ARM64 Andreas Schwab
2015-11-05 13:39 ` Andrew Pinski
2015-11-05 22:18 ` Yury Norov
2015-11-09 10:01 ` Andreas Schwab
2015-11-11 7:16 ` Zhangjian (Bamvor)
2015-11-11 8:44 ` Andreas Schwab
2015-11-09 13:23 ` Andreas Schwab
2015-11-09 14:21 ` Arnd Bergmann
2015-11-09 14:33 ` Andreas Schwab
2015-11-09 14:36 ` Arnd Bergmann
2015-11-09 14:52 ` pinskia at gmail.com
2015-11-09 15:50 ` Yury Norov
2015-11-09 16:04 ` Yury Norov
[not found] ` <1449010556-31699-1-git-send-email-iharutyunov@sonicwall.com>
2015-12-03 17:05 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9280044.CblpxvJy8Z@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox