From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBFACC02180 for ; Thu, 16 Jan 2025 09:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z2ao+rKhy2rrFNzC5Hk6CZpJrkvTuzh6Wda4P8nTqpU=; b=QjztmD3V+6hxm7 JW6hwt5uWLXlCZnaUUmqEM4rMnaemBM/rT43JVw9ZgNnXyns1n+oUD5j760Q5tUnocuTRCa1YFaVS gwHRg1z1Ar9bkgScJetoQHspdsMyHccv5aYHhHvDGj3WaSM/JCdSzbGEUaNKCV7iq6BvfX4s2znXY YFCFtDDzaecvPFY4JfLutI7+M8P4P6M2JFMULzlFrlA90dozLLo2JCSj46PYC1oMdwRRDc5WYjz18 vLmsHCa5+CY4Ofu35m7pyW2SQMsDCp/OAU5CZooVOc+ittbSptjTBKs1az2mBGz9SLz0nREoa2YTk DJh5VTQpuOv+FiVR6QPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYMCf-0000000EN0V-1Srq; Thu, 16 Jan 2025 09:30:17 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYMBP-0000000EMji-03v8 for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2025 09:29:00 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4361e89b6daso3701665e9.3 for ; Thu, 16 Jan 2025 01:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737019737; x=1737624537; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :reply-to:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=z2ao+rKhy2rrFNzC5Hk6CZpJrkvTuzh6Wda4P8nTqpU=; b=W48f2hOAns40Jzdo7f/0t8JUox823gXYXFGQ0wUZnN3EHVV7Axti6e1RRnX7Cb3cGS AaLNPKoQdHSf19evGrKWdv6qYNWtFboaUsiBaziWCe+TOPHJ3WdIZKm1Wox0aTPV/LUi oCCP3skhnqnLOLHpzFGJv4JIX0tA+yAkMAT+pEL5H6yeNrPrem77+CkrNO/m71xefN0n TDBj/Mc8gkSGUu7no8EgiITG4/G6guVUoahciONgSq4gzt2IrLQKx0BNgjmgYxnrQGvq NuuMfffBVSeC7QPv16HihdfHU14Lvh2J5FLLXlvTdsZmYxM2tKE7WA5Hy9EFQNRvn1Xa a6+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737019737; x=1737624537; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :reply-to:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z2ao+rKhy2rrFNzC5Hk6CZpJrkvTuzh6Wda4P8nTqpU=; b=BC0Qy7FnhFzP8kzQkRXTErz4Fy4THW8oBLson4CBs1tbT8OHPXtogvuwlPE9E4YCzp jQmgP6gweTcALGJHhor24cdgxkg5UAnBmOvxO/SW7mFm83UzsyGi3LeTkNu5VZtuQe5W pqhHRXLH/cIsvd9vgqO8xQDpKzggLOnFFOBC9Eo2PDy+BZn4+dDtUuVef1RcBR7jMnwr R3G37+YDgbC0K2Y+EwYq5u9EoRtEYrdXtXWlusQZugng5M25Izkm5V4FKyMl68PDukT4 GthRTe0RuY1P298JnVKSgJgQDhaawsVeNcKjvUaihu06gAmm6CQgXtps7UZBrlKiyejC 0+lw== X-Forwarded-Encrypted: i=1; AJvYcCXdGah9F4DqHWo5Pv6EPyVs8GhgPaZf0uLXty8+srnk+h4N1yXH22PNqkkjXjcOxqVkGJRn5qwA61PeqZ9Vd+Hq@lists.infradead.org X-Gm-Message-State: AOJu0Yz3Qz5T1XCJw5dtDAqcCtqxoejiM7ALEn7qU+MYusuWkceMS3x9 ly8deV65jeCgtHk2fkgaHn/rd9pqIQ60cia7NFF8sCH6TtTkZTzs59ObqOdKlq4= X-Gm-Gg: ASbGnctAG1BktackCGrMWlLoqDzs8gzDV9x8bmBtu69fCLp1SUqlOxN6zw5jf2Baqdv Cv/GOO8EX41O2xVOQf/NVtJYYO3/Z4zWjueMn+YwfU2OZ9p41TLwkNyV7djW+NFBZZrkOhw6MUn v96WJzvyCU1AW1VWEdflwP3K4fUYBCXRFyBv53sFNGaRPNwqVczJnCARpRzkGP7XTnEPi0R4g15 PH4V0o/N7oJKF4xysRi4nnm274uMf13dE4GoBvOD+r0XEZ8FxF7vuhpDfuZ2uzZwseuRRRDbudj /JmgbNc1ddZOm839aa+MvFySmpnlVJw= X-Google-Smtp-Source: AGHT+IHdmWN7Oeq0S+zEiZuKe5KeBcQ85jvcioqfybqbDRFTq5jmeJjyGwdZonKpDmR4f3lwPMFpRg== X-Received: by 2002:a05:600c:a08b:b0:431:5863:4240 with SMTP id 5b1f17b1804b1-436e26dda73mr251928715e9.24.1737019737060; Thu, 16 Jan 2025 01:28:57 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:69b:c51f:3072:d4f5? ([2a01:e0a:982:cbb0:69b:c51f:3072:d4f5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74e5e69sm51988535e9.37.2025.01.16.01.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 01:28:56 -0800 (PST) Message-ID: <92b2f271-34dc-4560-a96c-bdd372d5e3d6@linaro.org> Date: Thu, 16 Jan 2025 10:28:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] Support Multi-frequency scale for UFS To: Ziqi Chen , quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com, quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com, quic_rampraka@quicinc.com Cc: linux-scsi@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , "open list:ARM/Mediatek SoC support:Keyword:mediatek" , "moderated list:ARM/Mediatek SoC support:Keyword:mediatek" , "moderated list:ARM/Mediatek SoC support:Keyword:mediatek" References: <20250116091150.1167739-1-quic_ziqichen@quicinc.com> Content-Language: en-US, fr From: Neil Armstrong Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250116091150.1167739-1-quic_ziqichen@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_012859_052705_6D853FDA X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, [+linux-arm-msm@vger.kernel.org] On 16/01/2025 10:11, Ziqi Chen wrote: > With OPP V2 enabled, devfreq can scale clocks amongst multiple frequency > plans. However, the gear speed is only toggled between min and max during > clock scaling. Enable multi-level gear scaling by mapping clock frequencies > to gear speeds, so that when devfreq scales clock frequencies we can put > the UFS link at the appropraite gear speeds accordingly. > > This series has been tested on below platforms - > SM8650 + UFS3.1 Which board did you use ? the MTP ? > SM8750 + UFS4.0 Did you alse test it on SM8550 ? this platform is also concerned. And perhaps SM8450 should be also converted to the OPP table & tested. Please Cc linux-arm-msm on all patches since we're directly concerned by the whole changeset. Thanks, Neil > > > Can Guo (6): > scsi: ufs: core: Pass target_freq to clk_scale_notify() vops > scsi: ufs: qcom: Pass target_freq to clk scale pre and post change > scsi: ufs: core: Add a vops to map clock frequency to gear speed > scsi: ufs: qcom: Implement the freq_to_gear_speed() vops > scsi: ufs: core: Enable multi-level gear scaling > scsi: ufs: core: Toggle Write Booster during clock scaling base on > gear speed > > Ziqi Chen (2): > scsi: ufs: core: Check if scaling up is required when disable clkscale > ARM: dts: msm: Use Operation Points V2 for UFS on SM8650 > > arch/arm64/boot/dts/qcom/sm8650.dtsi | 51 ++++++++++++++++---- > drivers/ufs/core/ufshcd-priv.h | 17 +++++-- > drivers/ufs/core/ufshcd.c | 71 +++++++++++++++++++++------- > drivers/ufs/host/ufs-mediatek.c | 1 + > drivers/ufs/host/ufs-qcom.c | 60 ++++++++++++++++++----- > include/ufs/ufshcd.h | 8 +++- > 6 files changed, 166 insertions(+), 42 deletions(-) >