From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9224C433F5 for ; Tue, 7 Sep 2021 23:37:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FA76610A3 for ; Tue, 7 Sep 2021 23:37:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9FA76610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OR5pmbMsFI8HgI8tikFSM8z7yVbCz/s+7tnQA++M6sk=; b=LHs7XYaFRbyEKuASyn+twL3PCx J0wBEELXKRF9EnPXXIv0vHQJ+lwMV0u6iZEp0zWZuVYEr0VE6dSrYcBdRVPiuvl+/TgfzRIQVuFyW whacsVdo6mVgaDeKLciiZYYSgKCvmlPcRRZ5haC4/gLzPsdBqogdyyV3Iz+ipno6TR2Ehars3vKrD 1m6VfmjGCyx5Q7oRBSFp5yqxacGzZtbICNhKtLr7MTnlZQ0yZCFAFWjpq2W78CO2DpT46sFUnbSSY e0HyOFox9UJKuCWH1UuMUo0ZTanV4VYJzc5oTu5hX3W26IMhYc3r3ojV+eHSXrhTV0yT5Imm6vf2h UanUipmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNkcp-0051hk-UD; Tue, 07 Sep 2021 23:35:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNkcm-0051h2-A4 for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 23:35:33 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C25E1610C8; Tue, 7 Sep 2021 23:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631057730; bh=vWnttUTlF72LyMrYjIe/78FyUtshVhZy/pfLSh7SFiY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=U6bhbq/e7swGtHS4elAaebisMP4udNQk1DmHur/UmRfOzJP287/22Sl7MnFX2t3m0 H5mdMXeCMhgSw7InBrFmEYhKNE7fqIYXLp8N57IqHvU+6essRsQUqYeslpAnZ3O2v4 EfjPXh4NGH5AMFduknEvWv9grbxsdHlyGvHetBy7UxNRcNcGOgvEAzwJNROk6U7HQg 3HCGqr1MhAm7ZpTuR/80Yj9r4/zqLTlBLBhpvQ4g/X3s7GSTi7X04hnNGoZmr8dp+H mQBaVmu19EFA/kLtF85BSAotL0eJB+eYtyzb3tRYt2cXjDyTspNW85j9zAgxqzXbcC c8obvu7titLiA== Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Shuah Khan , Brendan Higgins , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu Cc: Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet References: From: Nathan Chancellor Message-ID: <92c20b62-c4a7-8e63-4a94-76bdf6d9481e@kernel.org> Date: Tue, 7 Sep 2021 16:35:26 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_163532_425962_4C2AB176 X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/7/2021 4:14 PM, Linus Torvalds wrote: > There are many more of these cases. I've seen Hyper-V allocate 'struct > cpumask' on the stack, which is once again an absolute no-no that > people have apparently just ignored the warning for. When you have > NR_CPUS being the maximum of 8k, those bits add up, and a single > cpumask is 1kB in size. Which is why you should never do that on > stack, and instead use ' > > cpumask_var_t mask; > alloc_cpumask_var(&mask,..) > > which will do a much more reasonable job. But the reason I call out > hyperv is that as far as I know, hyperv itself doesn't actually > support 8192 CPU's. So all that apic noise with 'struct cpumask' that > uses 1kB of data when NR_CPUS is set to 8192 is just wasted. Maybe I'm > wrong. Adding hyperv people to the cc too. I am only commenting on this because I was looking into an instance of this warning yesterday with Fedora's arm64 config, which has CONFIG_NR_CPUS=4096: https://lore.kernel.org/r/YTZyMx91zV9kfDkQ@Ryzen-9-3900X.localdomain/ Won't your example only fix the issue with CONFIG_CPUMASK_OFFSTACK=y or am I misreading the gigantic comment in include/linux/cpumask.h? As far as I can tell, only x86 selects it and it is not user configurable unless CONFIG_DEBUG_PER_CPU_MAPS is set, which is buried in the debug options so most people won't bother trying to enable it. If I understand correctly, how should these be dealt with in the case of CONFIG_CPUMASK_OFFSTACK=n? Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel