From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
Vignesh R <vigneshr@ti.com>, Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <imx@lists.linux.dev>,
<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH 07/12] i2c: st: set device parent and of_node through the adapter struct
Date: Mon, 5 Jan 2026 08:26:02 +0100 [thread overview]
Message-ID: <92c8b930-adc2-4204-b9c1-0dc1e31115f3@foss.st.com> (raw)
In-Reply-To: <20251223-i2c-adap-dev-config-v1-7-4829b1cf0834@oss.qualcomm.com>
On 12/23/25 11:04, Bartosz Golaszewski wrote:
> Configure the parent device and the OF-node using dedicated fields in
> struct i2c_adapter and avoid dereferencing the internal struct device.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> drivers/i2c/busses/i2c-st.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index 97d70e66722706f242cd97153387c3a865abc12d..b50be2c39eaa4b9b95a71b038a4d63f3c5fd7c4b 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -849,8 +849,8 @@ static int st_i2c_probe(struct platform_device *pdev)
> adap->retries = 0;
> adap->algo = &st_i2c_algo;
> adap->bus_recovery_info = &st_i2c_recovery_info;
> - adap->dev.parent = &pdev->dev;
> - adap->dev.of_node = pdev->dev.of_node;
> + adap->parent = &pdev->dev;
> + adap->of_node = pdev->dev.of_node;
>
> init_completion(&i2c_dev->complete);
>
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
next prev parent reply other threads:[~2026-01-05 7:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 10:04 [PATCH 00/12] i2c: configure parent device and OF node through the adapter struct Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 01/12] i2c: allow setting the " Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 02/12] i2c: qcom-geni: set device parent and of_node " Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 03/12] i2c: bcm-kona: " Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 04/12] i2c: keba: " Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 05/12] i2c: omap: " Bartosz Golaszewski
2025-12-29 14:54 ` Andreas Kemnade
2025-12-23 10:04 ` [PATCH 06/12] i2c: rcar: " Bartosz Golaszewski
2026-01-06 9:13 ` Geert Uytterhoeven
2026-01-06 14:17 ` Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 07/12] i2c: st: " Bartosz Golaszewski
2026-01-05 7:26 ` Patrice CHOTARD [this message]
2025-12-23 10:04 ` [PATCH 08/12] i2c: mxs: " Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 09/12] i2c: highlander: " Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 10/12] i2c: gpio: " Bartosz Golaszewski
2025-12-23 10:04 ` [PATCH 11/12] i2c: nomadik: " Bartosz Golaszewski
2026-01-03 19:04 ` Linus Walleij
2025-12-23 10:04 ` [PATCH 12/12] i2c: bcm2835: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92c8b930-adc2-4204-b9c1-0dc1e31115f3@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@kernel.org \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=imx@lists.linux.dev \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=rjui@broadcom.com \
--cc=rogerq@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=viken.dadhaniya@oss.qualcomm.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox