From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42E1DC48BF9 for ; Wed, 15 Nov 2023 13:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m68DL6M1lWKHymlULZz9DwMatBOxWSTVLOjk5ahgzN0=; b=NVed+RiP5BfK57 F0T0CwoIdSy2L1eJVsBMdfO1lO1s/4TEJyoprzhRb8RxqSPoXzig8ePQSW76JEPw5nZbG6dxFnljz UvilVBQ7n9j52pSqWQaeVoGhM4x589zf30p0/Erea3oPxFB+P6LtETM4JI4vNTumi3AwNyUiXNylP Q4/+M/Y3RSbq3xxiLgbGh/N6SC07SXuM0WgKRD+SD4AAR8htLUzLy+z2/fRH6P0J19Iu5/+t/O8AK yBzkTplHLPJ2Zs3fh2GpKBT/IQW4HOsMai8JezvUPCjO4oapQEw1HAUuiNc/jfue2OCF8y74RphEL ZfFUOeLRk7+MYW7QmLow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3GLI-000uqj-1c; Wed, 15 Nov 2023 13:54:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3GLF-000uq0-2p for linux-arm-kernel@lists.infradead.org; Wed, 15 Nov 2023 13:54:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12847DA7; Wed, 15 Nov 2023 05:54:48 -0800 (PST) Received: from [192.168.1.3] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBC473F641; Wed, 15 Nov 2023 05:54:00 -0800 (PST) Message-ID: <92d6a66d-3270-3378-2ab9-9214c004d5c7@arm.com> Date: Wed, 15 Nov 2023 13:53:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 4/7] coresight: tpiu: Move ACPI support from AMBA driver to platform driver Content-Language: en-US To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Lorenzo Pieralisi , Sudeep Holla , Mike Leach , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com References: <20231027072943.3418997-1-anshuman.khandual@arm.com> <20231027072943.3418997-5-anshuman.khandual@arm.com> From: James Clark In-Reply-To: <20231027072943.3418997-5-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231115_055405_980945_5A1B957E X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/10/2023 08:29, Anshuman Khandual wrote: > Add support for the tpiu device in the platform driver, which can then be > used on ACPI based platforms. This change would now allow runtime power > management for ACPI based systems. The driver would try to enable the APB > clock if available. > [...] > +#ifdef CONFIG_ACPI > +static const struct acpi_device_id tpiu_acpi_ids[] = { > + {"ARMHC979", 0}, /* ARM CoreSight TPIU */ > + {} > +}; > +MODULE_DEVICE_TABLE(acpi, tpiu_acpi_ids); > +#endif > + > +static struct platform_driver tpiu_platform_driver = { > + .probe = tpiu_platform_probe, > + .remove = tpiu_platform_remove, > + .driver = { > + .name = "coresight-tpiu-platform", > + .acpi_match_table = ACPI_PTR(tpiu_acpi_ids), > + .suppress_bind_attrs = true, > + .pm = &tpiu_dev_pm_ops, > + }, > +}; > +module_platform_driver(tpiu_platform_driver); > + Is there a special build config where this works? I get an error here because module_platform_driver() redefines things that are in module_amba_driver() which is defined above: module_amba_driver(tpiu_driver); This isn't a W=1 build or anything, just a normal one. And it applies to most of the patches in this set. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel