From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C02C433F5 for ; Fri, 5 Nov 2021 02:57:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD2566120F for ; Fri, 5 Nov 2021 02:57:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD2566120F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=68pVqVePtawYI4TGwdPquKyYRe9tHxcGs8xO/TGgj5k=; b=wNFaUDjxRR+R8/ WeYpjzmZh+TtNecy6ElndJf3aphgFjTWo5fOlvRhDAXwz/1Xapc/xvxKA1H6H/A8WqqyYmX23Yk+D nmmPYrEzxo9YuGpAthFgr2xXrSv+MVVcbVp+wbp2v9VL4nS94ScbhYs7poysveVIibqRTbnggEvBo 1U4a+Rlh5BwJk6rIk7CBdcUjAhHW+PEVv1Y6wZa0wncDRJwxCype5o5kkSyN1t6Jo8c3nWEe8Es6G LhG5j1wuCtHDNt22GrFbdRisgca8vaq6r3TREw7+L71NsuG6diPf/tH5tMiZd5Z8k/wr37+Gr9iPG 8aHgwxVkowU6rJGX7Jgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mipOv-00ARr7-DB; Fri, 05 Nov 2021 02:56:21 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mipOr-00ARpM-Qv for linux-arm-kernel@lists.infradead.org; Fri, 05 Nov 2021 02:56:19 +0000 Received: by mail-pj1-x1032.google.com with SMTP id gx15-20020a17090b124f00b001a695f3734aso2401758pjb.0; Thu, 04 Nov 2021 19:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Sldp+dEA/S3fed/PPXTlW+EzxdJTFfKjqSSoeZHFt94=; b=WNWCD5Wz6aytXpg2bn/p5/52YbT3FeflDludwI2sImT4WEN4YrvdlTFCp7i/e4mX9y pRNCYGqROvhhYio/q11i42l86JotYT4o8hM5QKbxtFqHtQLIJi1VRG+kaIgwrP4lzo2s ccu0LN4+NWKFr2+8x28tYLDEqjpOYJU3HoiqK79bki4Ifk+UYm2IIU83/MtW4V11Pay8 Ib9BG5JUGpMM0305IvRIPgrvm2RZlI+Z9hIDEgUItjWizybR8K5pdyT4ZGbh//gW2t0g cRAzDfjDUE8FW/55cw4cy/Eh4D4efDYd4SZm9+ylBQ6GbHks73ylnxsJsBoZbmaVBYre wOBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Sldp+dEA/S3fed/PPXTlW+EzxdJTFfKjqSSoeZHFt94=; b=p+9ILSSf6hMAwzjYfatoccMhlbAXE2abGAOD7QNQV8o3MvXeNKU8ZowMdyT3Jp4yaB Lic/5fCTCMaILq1LSfxJkaQhA+Uo65tm5jEO9xJx+BhkcuonFSAwvSHl/gQrv7Q7w4lW 5dx5A2aZd1RBWkNi5ju9BLCRO2ZoBCsm3G52Wjep0GgiOvNooECFIA6rDK6Z2ddmARar NgIxqemCXOYm+PErUCAxx6y79jltVFawCEnVaQmRqhtEbbORRU9zg+mXIkesBzdw9QCv CZWkACURsZkY4MmmzD5kCZos5WxV+BS0Xkd1N43ODctC4nuPyYiPPOT0n83YNarzgK5U 4HCQ== X-Gm-Message-State: AOAM531CqGNz3a20bX4/afTSvM2/ngYali2Y1C6NVmywi7c/Dg9emQf7 xnQtpqWFQusfiIPf8tGeVn0= X-Google-Smtp-Source: ABdhPJypwO55FF48mMTgLOXlgYlvP3+fyv+itreGkJB2dinAEKGEXapmrwQnC2nrvR6hL6ObL0Ujiw== X-Received: by 2002:a17:90a:e7c4:: with SMTP id kb4mr27289226pjb.237.1636080975251; Thu, 04 Nov 2021 19:56:15 -0700 (PDT) Received: from [10.230.2.240] ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id h20sm6347511pfh.175.2021.11.04.19.56.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Nov 2021 19:56:14 -0700 (PDT) Message-ID: <9318932a-9b00-62be-eeb9-ca755a05c841@gmail.com> Date: Thu, 4 Nov 2021 19:56:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] bus: brcmstb_gisb: Allow building as module Content-Language: en-US To: Guenter Roeck , Thomas Bogendoerfer Cc: linux-kernel@lists.infradead.org, "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Arnd Bergmann , Linus Walleij , open list , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20210924191035.1032106-1-f.fainelli@gmail.com> <20211105025155.GA2922689@roeck-us.net> From: Florian Fainelli In-Reply-To: <20211105025155.GA2922689@roeck-us.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211104_195617_934810_B3384D9D X-CRM114-Status: GOOD ( 22.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/4/2021 7:51 PM, Guenter Roeck wrote: > On Fri, Sep 24, 2021 at 12:10:34PM -0700, Florian Fainelli wrote: >> Allow building the Broadcom STB GISB arbiter driver as a module, however >> similar to interrupt controller drivers, don't allow its unbind/removal >> since it is not quite prepared for that and we want it to catch bus >> errors all the time. >> >> Signed-off-by: Florian Fainelli > > Hmm, did you actually test that ? Great way to introduce someone to a problem, really. > > Building mips:allmodconfig ... failed > -------------- > Error log: > :1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp] > ERROR: modpost: "board_be_handler" [drivers/bus/brcmstb_gisb.ko] undefined! I did not indeed test a modular build for MIPS and had not anticipated it to fail. Thomas, do you have any objections exporting board_be_handler to modules or would you rather not do it and force the driver to be boolean for MIPS? > > Guenter > >> drivers/bus/Kconfig | 2 +- >> drivers/bus/brcmstb_gisb.c | 7 ++++++- >> 2 files changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig >> index a5b96f3aad67..9cfeae3fc244 100644 >> --- a/drivers/bus/Kconfig >> +++ b/drivers/bus/Kconfig >> @@ -30,7 +30,7 @@ config ARM_INTEGRATOR_LM >> found on the ARM Integrator AP (Application Platform) >> >> config BRCMSTB_GISB_ARB >> - bool "Broadcom STB GISB bus arbiter" >> + tristate "Broadcom STB GISB bus arbiter" >> depends on ARM || ARM64 || MIPS >> default ARCH_BRCMSTB || BMIPS_GENERIC >> help >> diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c >> index 6551286a60cc..4c2f7d61cb9b 100644 >> --- a/drivers/bus/brcmstb_gisb.c >> +++ b/drivers/bus/brcmstb_gisb.c >> @@ -1,6 +1,6 @@ >> // SPDX-License-Identifier: GPL-2.0-only >> /* >> - * Copyright (C) 2014-2017 Broadcom >> + * Copyright (C) 2014-2021 Broadcom >> */ >> >> #include >> @@ -536,6 +536,7 @@ static struct platform_driver brcmstb_gisb_arb_driver = { >> .name = "brcm-gisb-arb", >> .of_match_table = brcmstb_gisb_arb_of_match, >> .pm = &brcmstb_gisb_arb_pm_ops, >> + .suppress_bind_attrs = true, >> }, >> }; >> >> @@ -546,3 +547,7 @@ static int __init brcm_gisb_driver_init(void) >> } >> >> module_init(brcm_gisb_driver_init); >> + >> +MODULE_AUTHOR("Broadcom"); >> +MODULE_DESCRIPTION("Broadcom STB GISB arbiter driver"); >> +MODULE_LICENSE("GPL v2"); -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel