From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9D77C61DA4 for ; Mon, 6 Feb 2023 03:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u25xBXZFRBc00Q2kE0XWj5zJ+5OXqdqJyPQwjey/Dlc=; b=RR/EmrM+As9qxW vvlA6NJEIMX7lSyFCrDs15yxjsGR1KAPDihjVnYfPSToW9dgc1eJIrBxjCWm398GGBxkqUrffqOBf 5YZcCnEIWaEWXNt7ZXV8DGtuWqktclwRqLbuWmYlABVXaslL1dVMAd7hh81+55LowmJRSSWpH64bv 3Cyd3yTAJQkH7ZWtfA7IyyMuXFp9FQA9Yd9kXwsQwt8K8vyg8AwxVqWvY/oDigiPQx30NCX8KeTRT 2MQzcgfdPv6g/u5aE0uC+CZD9xhFKXLO5WE0Cb2wISfrhWJpjPZiXJMJk9mXRKc5zr8ftamzdkCu5 iq0AkPjSi0aPzdu9n3vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOsBj-007GoS-IQ; Mon, 06 Feb 2023 03:29:03 +0000 Received: from out-27.mta0.migadu.com ([91.218.175.27]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOsBf-007Gna-Cm for linux-arm-kernel@lists.infradead.org; Mon, 06 Feb 2023 03:29:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675654132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eE336XECImzBUOMMtwTdImPHKD+HUI3PqxaznZaYnMA=; b=EoZLM7P7qlsS+N4RWiw1WaYVQHNFUid91vo47ESSmcljE2xzeGdeSIm4JlgDiHr/vCbUDe OMwlRqkUEsqyvxleiBlQs/GUeeJ00Hyym4bBL1H6UEsCOtlQKiC8e8s7vg6X0VVVIyhR+0 LjvweO9V6h/eVI6p+mNSqX92pikUTI0= MIME-Version: 1.0 Subject: Re: [PATCH V2] arm64/mm: Intercept pfn changes in set_pte_at() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230203101023.GA5597@willie-the-truck> Date: Mon, 6 Feb 2023 11:28:12 +0800 Cc: Catalin Marinas , Robin Murphy , Anshuman Khandual , linux-arm-kernel@lists.infradead.org, Mark Rutland , Andrew Morton , linux-kernel@vger.kernel.org, Mark Brown Message-Id: <93461768-791A-45BE-BEF2-344CC5228C92@linux.dev> References: <20230109052816.405335-1-anshuman.khandual@arm.com> <20230126133321.GB29148@willie-the-truck> <20230131154950.GB2646@willie-the-truck> <20230203101023.GA5597@willie-the-truck> To: Will Deacon X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230205_192859_891925_BC1E1D43 X-CRM114-Status: GOOD ( 23.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Feb 3, 2023, at 18:10, Will Deacon wrote: > > On Fri, Feb 03, 2023 at 10:40:18AM +0800, Muchun Song wrote: >> >> >>> On Feb 2, 2023, at 18:45, Catalin Marinas wrote: >>> >>> On Thu, Feb 02, 2023 at 05:51:39PM +0800, Muchun Song wrote: >>>>> On Feb 1, 2023, at 20:20, Catalin Marinas wrote: >>>>>> Bah, sorry! Catalin reckons it may have been him talking about the vmemmap. >>>>> >>>>> Indeed. The discussion with Anshuman started from this thread: >>>>> >>>>> https://lore.kernel.org/all/20221025014215.3466904-1-mawupeng1@huawei.com/ >>>>> >>>>> We already trip over the existing checks even without Anshuman's patch, >>>>> though only by chance. We are not setting the software PTE_DIRTY on the >>>>> new pte (we don't bother with this bit for kernel mappings). >>>>> >>>>> Given that the vmemmap ptes are still live when such change happens and >>>>> no-one came with a solution to the break-before-make problem, I propose >>>>> we revert the arm64 part of commit 47010c040dec ("mm: hugetlb_vmemmap: >>>>> cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*"). We just need this hunk: >>>>> >>>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>>>> index 27b2592698b0..5263454a5794 100644 >>>>> --- a/arch/arm64/Kconfig >>>>> +++ b/arch/arm64/Kconfig >>>>> @@ -100,7 +100,6 @@ config ARM64 >>>>> select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT >>>>> select ARCH_WANT_FRAME_POINTERS >>>>> select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >>>>> - select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP >>>> >>>> Maybe it is a little overkill for HVO as it can significantly minimize the >>>> overhead of vmemmap on ARM64 servers for some workloads (like qemu, DPDK). >>>> So I don't think disabling it is a good approach. Indeed, HVO broke BBM, >>>> but the waring does not affect anything since the tail vmemmap pages are >>>> supposed to be read-only. So, I suggest skipping warnings if it is the >>>> vmemmap address in set_pte_at(). What do you think of? >>> >>> IIUC, vmemmap_remap_pte() not only makes the pte read-only but also >>> changes the output address. Architecturally, this needs a BBM sequence. >>> We can avoid going through an invalid pte if we first make the pte >>> read-only, TLBI but keeping the same pfn, followed by a change of the >>> pfn while keeping the pte readonly. This also assumes that the content >>> of the page pointed at by the pte is the same at both old and new pfn. >> >> Right. I think using BBM is to avoid possibly creating multiple TLB entries >> for the same address for a extremely short period. But accessing either the >> old page or the new page is fine in this case. Is it acceptable for this >> special case without using BBM? > > Sadly, the architecture allows the CPU to conjure up a mapping based on a > combination of the old and the new descriptor (a process known as > "amalgamation") so we _really_ need the BBM sequence. I am not familiar with ARM64, what's the user-visible effect if this "amalgamation" occurs? Muchun, Thanks. > > I'm in favour of disabling the optimisation now and bringing it back once > we've got this fixed. > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel