From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6A1C2D0A3 for ; Tue, 3 Nov 2020 14:43:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DACDC223BF for ; Tue, 3 Nov 2020 14:43:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LBOaihTO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DACDC223BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nZn8LdTv4Wuvj/apa0aNg51AQ4FducPMD2tKvUY086Y=; b=LBOaihTOQ3USUDsgIocSy2E+k lSFsmHgEYSeAaQtVbL1wc9QSEgpZ0zdGZtVbeLKACza+slsyVCODMnFOD20cdogypXu78syeiXI1J JukrU1A2lNMZLDJQMbszQsC9gcOQIls89GzDiqlO30ugPpsERecWEflfOEO/RaGMQwuFSNhaGhtw3 KU17ChmptEVALG1l15V8Lsg6zeRHJOMpVpt2Zsxu9iZV4H0jqVAkswIfTPRB+vQk7svX11uBqdXpk ezsdNWnh+BTeZcO5Eh3fCGDAWhGkUqp4DBeIWUPZKjzhSeOyPR31HhW4uhtOuYu2QiqtVZn+yP0Rf y2vqTALwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZxWv-0000pA-7v; Tue, 03 Nov 2020 14:43:25 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZxWs-0000ni-FI for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 14:43:23 +0000 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 7F9E3D02944A3A90DE54; Tue, 3 Nov 2020 14:43:15 +0000 (GMT) Received: from [10.47.5.37] (10.47.5.37) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 3 Nov 2020 14:43:13 +0000 Subject: Re: [perf metricgroup] fcc9c5243c: perf-sanity-tests.Parse_and_process_metrics.fail To: Ian Rogers , kajoljain References: <1602152121-240367-10-git-send-email-john.garry@huawei.com> <20201018085031.GK11647@shao2-debian> <602e6bb8-a4ac-fae7-ed61-edf252e08d9a@huawei.com> <6d22bbdf-1a7c-1ba9-3c1a-88600178facf@linux.ibm.com> From: John Garry Message-ID: <935893a3-297d-c6ed-524b-e50e5d5a0d54@huawei.com> Date: Tue, 3 Nov 2020 14:43:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.47.5.37] X-ClientProxiedBy: lhreml754-chm.china.huawei.com (10.201.108.204) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_094322_760707_175307EC X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Zijlstra , linuxarm@huawei.com, LKML , Jin Yao , James Clark , Jiri Olsa , Andi Kleen , 0day robot , kernel test robot , Will Deacon , Alexander Shishkin , Ingo Molnar , linux-imx@nxp.com, Arnaldo Carvalho de Melo , zhangshaokun@hisilicon.com, lkp@lists.01.org, Namhyung Kim , Linux ARM , Mathieu Poirier , Joakim Zhang , Leo Yan Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/10/2020 17:53, Ian Rogers wrote: >>> Thanks for taking a look John. If you want help you can send the >>> output of "perf test 67 -vvv" to me. It is possible Broadwell has >>> similar glitches in the json to Skylake. I tested the original test on >>> server parts as I can access them as cloud machines. >>> >>>> I will have a look, but I was hoping that Ian would have a proper fix >>>> for this on top of ("perf metricgroup: Fix uncore metric expressions"), >>>> which now looks to be merged. >>> I still have these changes to look at in my inbox but I'm assuming >>> they're good:-) Sorry for not getting to them, but it's good they are >>> merged. >> Hi Ian, >> Checked in upstream kernel with your fix patch, in powerpc also test case 67 is passing. >> But I am getting issue in test 10 for powerpc >> >> [command]# ./perf test 10 >> 10: PMU events : >> 10.1: PMU event table sanity : Ok >> 10.2: PMU event map aliases : Ok >> 10.3: Parsing of PMU event table metrics : Skip (some metrics failed) >> 10.4: Parsing of PMU event table metrics with fake PMUs : FAILED! >> >> Was debugging it, issue is with commit e1c92a7fbbc5 perf tests: Add another metric parsing test. >> >> So, there we are passing different runtime parameter value in "expr__find_other and expr__parse" >> in function `metric_parse_fake`. I believe we need to send same value. >> I will send fix patch for the same. Just wondering, was a patch ever submitted for this? Something still broken? I can't see any recent relevant changes to tests/pmu-events.c Thanks, John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel