Re: [PATCH 3/3] drm/rockchip: Add MIPI DSI2 glue driver for RK3588

["Heiko Stübner" <heiko@sntech.de>]

Hi,

Am Mittwoch, 6. November 2024, 14:33:25 CET schrieb Diederik de Haas:
> > +#define IPI_DEPTH_5_6_5_BITS		0x02
> > +#define IPI_DEPTH_6_BITS		0x03
> > +#define IPI_DEPTH_8_BITS		0x05
> > +#define IPI_DEPTH_10_BITS		0x06
> 
> Possibly dumb remark (sorry):
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c also defines these
> values, so wouldn't it be better if they're defined in 1 place?

they are quite device-specific, so for me it doesn't really make sense
to try to centralize them. I.e. these are the values that need to go into
the GRF register to select a specific depth and are more or less the
same by chance.

I still remember quite well the answer to why Rockchip hardware engineers
sometimes shuffle around similar grf entries between socs "because they
want to" ;-)

At least for the rk3576, they seem to stay the same for now, though part
of me just expects the values to change in the future.

So personally I'd like to keep them where they are :-)

Heiko