From: Mukesh Ojha <mojha@codeaurora.org>
To: Anson Huang <anson.huang@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"Sven.Schmitt@mixed-mode.de" <Sven.Schmitt@mixed-mode.de>,
"vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"robh@kernel.org" <robh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 2/2] soc: imx: gpcv2: use devm_platform_ioremap_resource() to simplify code
Date: Mon, 1 Apr 2019 13:19:07 +0530 [thread overview]
Message-ID: <9374e771-4132-6183-fdfa-e227aedfdbbd@codeaurora.org> (raw)
In-Reply-To: <1554098543-5036-2-git-send-email-Anson.Huang@nxp.com>
On 4/1/2019 11:37 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/soc/imx/gpcv2.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index e06bf12..31b8d00 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -563,7 +563,6 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct device_node *pgc_np, *np;
> struct regmap *regmap;
> - struct resource *res;
> void __iomem *base;
> int ret;
>
> @@ -573,8 +572,7 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-01 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 6:07 [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 6:07 ` [PATCH 2/2] soc: imx: gpcv2: " Anson Huang
2019-04-01 7:49 ` Mukesh Ojha [this message]
2019-04-01 7:48 ` [PATCH 1/2] soc: imx: gpc: " Mukesh Ojha
2019-04-11 5:28 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9374e771-4132-6183-fdfa-e227aedfdbbd@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=Sven.Schmitt@mixed-mode.de \
--cc=andrew.smirnov@gmail.com \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).