From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Thu, 26 Jan 2017 10:56:34 -0600 Subject: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock In-Reply-To: <1485190856-4711-6-git-send-email-bgolaszewski@baylibre.com> References: <1485190856-4711-1-git-send-email-bgolaszewski@baylibre.com> <1485190856-4711-6-git-send-email-bgolaszewski@baylibre.com> Message-ID: <93a3bbb3-2d9f-bc38-c7b4-5eb3325d985d@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote: > The ahci-da850 SATA driver is now capable of retrieving clocks by > con_id. Add the connection id for the sysclk2-derived SATA clock. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/mach-davinci/da850.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c > index 1d873d1..dbf1daa 100644 > --- a/arch/arm/mach-davinci/da850.c > +++ b/arch/arm/mach-davinci/da850.c > @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = { > CLK("spi_davinci.0", NULL, &spi0_clk), > CLK("spi_davinci.1", NULL, &spi1_clk), > CLK("vpif", NULL, &vpif_clk), > - CLK("ahci_da850", NULL, &sata_clk), > + CLK("ahci_da850", "sata", &sata_clk), I'm worry a bit - wouldn't this cause future problems with PM runtime (if it will be the case)? If this is functional clock - shouldn't it be "fck" to follow PM domain con_id list for davinci? (arch/arm/mach-davinci/pm_domain.c) > CLK("davinci-rproc.0", NULL, &dsp_clk), > CLK(NULL, NULL, &ehrpwm_clk), > CLK("ehrpwm.0", "fck", &ehrpwm0_clk), > -- regards, -grygorii