From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4FE1C04A95 for ; Tue, 25 Oct 2022 07:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qIEs5veUepGzt1oY1uhrWBNXjcZcMjZqQsFrCJfky1M=; b=MMHka0KVLOya84 MaoAmfBK1Q6lBW9amp7Q2PteQMpBH3cfKLymWnDx5BDNNCHhwWAj2SgjnI9tuYpnEXMQA9CwZTqv2 f2i2PYjca21Ak78wv95YMXJICFl/yaAg4qOuILhZIByJtVNkDXIi0O0erhbhi+sdCwVWy60hvdb3T u3/w7g6w6KowN+1VcKDD5++aSclmZ1R3mEw6IB4XjJSs3vk5ZjurW+iYy+37ge68w3yb7qAsCNnAw gfp5a56O9P+hS7S6zmHNdo8wF0w8xaBPP5onjNjy8WEgoZrECaxdFkqBA5uzGbGmkO6AYyZV4mxC8 890/OKbQdwjFNjuf57DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onEYd-004CIC-51; Tue, 25 Oct 2022 07:41:07 +0000 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onEYY-004CHU-Qi for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 07:41:04 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VT2-i3n_1666683654; Received: from 30.240.99.167(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0VT2-i3n_1666683654) by smtp.aliyun-inc.com; Tue, 25 Oct 2022 15:40:57 +0800 Message-ID: <93a9e613-c4ee-e2f8-63d0-45119c031670@linux.alibaba.com> Date: Tue, 25 Oct 2022 15:40:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v2 12/15] crypto: arm64/sm4 - add CE implementation for ESSIV mode Content-Language: en-US To: Eric Biggers Cc: Herbert Xu , "David S. Miller" , Jussi Kivilinna , Ard Biesheuvel , Mark Brown , Catalin Marinas , Will Deacon , Maxime Coquelin , Alexandre Torgue , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20221018071006.5717-1-tianjia.zhang@linux.alibaba.com> <20221018071006.5717-13-tianjia.zhang@linux.alibaba.com> <6d2a98f4-c50d-d05b-4a24-08fdd3ee20fa@linux.alibaba.com> From: Tianjia Zhang In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_004103_089095_DECE925B X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Eric, On 10/25/22 1:20 PM, Eric Biggers wrote: > On Fri, Oct 21, 2022 at 10:47:14AM +0800, Tianjia Zhang wrote: >> Hi Eric, >> >> On 10/20/22 11:58 AM, Eric Biggers wrote: >>> On Tue, Oct 18, 2022 at 03:10:03PM +0800, Tianjia Zhang wrote: >>>> This patch is a CE-optimized assembly implementation for ESSIV mode. >>>> The assembly part is realized by reusing the CBC mode. >>>> >>>> Signed-off-by: Tianjia Zhang >>> >>> Is there still a use case for CBC-ESSIV mode these days, now that everyone is >>> using XTS instead? >>> >>> - Eric >> >> The mainstream is already using XTS, but CBC-ESSIV is still an optional >> backup algorithm, especially in block crypto and fscrypto, I'm currently >> working on supporting the SM4 algorithm for these subsystems. >> > > The only reason that AES-CBC-ESSIV support was added to fs/crypto/ was because > someone had a low-power embedded device with a hardware crypto accelerator that > only supported AES-CBC. > > Nothing like that is relevant here, as this is just a software implementation. > > Please just don't include ESSIV. There's no need to implement random useless > algorithms. It could always be added later if a use case actually arises. > > - Eric Thanks for this information, I will remove the ESSIV code in the next patch. Best regards, Tianjia _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel