From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBE6C433E0 for ; Wed, 3 Mar 2021 19:43:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A73464ED0 for ; Wed, 3 Mar 2021 19:43:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A73464ED0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S0dhN2KZd6bxaSSy5HNKsPR2StAymzGxXjoOXi76YA4=; b=OyfJxdoaZ8UUTbfiJibX1zpMy i3aTu5Ac+76B6tK8226TyLdngHFEzkVHEDqAWl7nKLfUWO045OY0RSz0d9dVa/KTDh0ccYVu9AhbF kQn5itVp5Qh5kX9R3wG6LByAj1nlrI5DctCy4OJGkBrvQcwhBjoQ7cD/a1AgmvJAS2uEsQGGl3wOu Xc8yr+jYyMqd647KpmybEJ2vZ8DZpChYa7Ci/RcVKwVmVkb9d/PrAcf7w19nhMgLb0bunvUKXcml+ htHevtJl0A+LFyswoaqpgQJFND1mQnQsS3X4y7oHgOdBJs3fbQCqs5/k5/HeBvIipBD1iYJcuq1Fj 4GJ2cDSIA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHXMp-006GCh-MI; Wed, 03 Mar 2021 19:41:09 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT3p-005IBo-GZ for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 15:05:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Cc:Sender :Reply-To:Content-ID:Content-Description; bh=n5O4RyqZ9tvYiX+Rpqy3Y5F0iZrJZ3BEEOKELvymBFg=; b=kR/FiW/FtHnNJDOCo01OqTvIuM bSwGMQTlK5t3ls1cjG9K69IijhMGEiT3xKC0JCYIWkY8PUb0PjJlroDDbjktXyjjaW+IA2PiV8BNa sXamKpZtqiVEch5JxQpSNCKNNkCiG5fXnNYfNo9yils3bNvwgObYXZuRht7IqlK7ChoRCxaperXdj gSjEkFCZy2ck0aTZIJF+5Gkci+xwdTCykf8vpXf3BcMt2NrtNWKrd92TqQqiVM+aclJ9WduQzV/Py V+L1EyzANxG0wQCw8/IIhF/W2/war8sixMdVa1kw6o9CtqpnWNM0/DsXD7zMRrlO3L5XW8zEwkH0Q Goa8b5bQ==; Received: from mga14.intel.com ([192.55.52.115]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHJqd-001MQg-L7 for linux-arm-kernel@lists.infradead.org; Wed, 03 Mar 2021 05:15:01 +0000 IronPort-SDR: rIO7E72GfmFyNNjGWojMwJ/+axDly+OPI6qP8UyTS5KtoljYVUbLHI8dy9796H17ELxlSS/Civ G+o95r0LKLzw== X-IronPort-AV: E=McAfee;i="6000,8403,9911"; a="186448051" X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="186448051" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 21:13:56 -0800 IronPort-SDR: W4v/nO9ltO4kt5+ahN8iBfKrHoekmqH21ZUT4l4BpgOpWZHofqqsHfhMkMGB1cDomKF9wWzHRs SGA9xegTO8/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="428037288" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga004.fm.intel.com with ESMTP; 02 Mar 2021 21:13:48 -0800 Subject: Re: [PATCH v13 03/10] iommu: Separate IOMMU_DEV_FEAT_IOPF from IOMMU_DEV_FEAT_SVA To: Jean-Philippe Brucker , joro@8bytes.org, will@kernel.org References: <20210302092644.2553014-1-jean-philippe@linaro.org> <20210302092644.2553014-4-jean-philippe@linaro.org> From: Lu Baolu Message-ID: <93b369dc-2145-bebb-b20c-90018bcc69c3@linux.intel.com> Date: Wed, 3 Mar 2021 13:04:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210302092644.2553014-4-jean-philippe@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_051501_857218_09014071 X-CRM114-Status: GOOD ( 23.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , vivek.gautam@arm.com, guohanjun@huawei.com, zhukeqian1@huawei.com, lorenzo.pieralisi@arm.com, wangzhou1@hisilicon.com, linux-acpi@vger.kernel.org, zhangfei.gao@linaro.org, lenb@kernel.org, devicetree@vger.kernel.org, kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , eric.auger@redhat.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, linux-arm-kernel@lists.infradead.org, David Woodhouse , rjw@rjwysocki.net, shameerali.kolothum.thodi@huawei.com, iommu@lists.linux-foundation.org, sudeep.holla@arm.com, robin.murphy@arm.com, linux-accelerators@lists.ozlabs.org, baolu.lu@linux.intel.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/2/21 5:26 PM, Jean-Philippe Brucker wrote: > Some devices manage I/O Page Faults (IOPF) themselves instead of relying > on PCIe PRI or Arm SMMU stall. Allow their drivers to enable SVA without > mandating IOMMU-managed IOPF. The other device drivers now need to first > enable IOMMU_DEV_FEAT_IOPF before enabling IOMMU_DEV_FEAT_SVA. Enabling > IOMMU_DEV_FEAT_IOPF on its own doesn't have any effect visible to the > device driver, it is used in combination with other features. > > Reviewed-by: Eric Auger > Signed-off-by: Jean-Philippe Brucker > --- > Cc: Arnd Bergmann > Cc: David Woodhouse > Cc: Greg Kroah-Hartman > Cc: Joerg Roedel > Cc: Lu Baolu > Cc: Will Deacon > Cc: Zhangfei Gao > Cc: Zhou Wang > --- > include/linux/iommu.h | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 16ce75693d83..45c4eb372f56 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -156,10 +156,24 @@ struct iommu_resv_region { > enum iommu_resv_type type; > }; > > -/* Per device IOMMU features */ > +/** > + * enum iommu_dev_features - Per device IOMMU features > + * @IOMMU_DEV_FEAT_AUX: Auxiliary domain feature > + * @IOMMU_DEV_FEAT_SVA: Shared Virtual Addresses > + * @IOMMU_DEV_FEAT_IOPF: I/O Page Faults such as PRI or Stall. Generally > + * enabling %IOMMU_DEV_FEAT_SVA requires > + * %IOMMU_DEV_FEAT_IOPF, but some devices manage I/O Page > + * Faults themselves instead of relying on the IOMMU. When > + * supported, this feature must be enabled before and > + * disabled after %IOMMU_DEV_FEAT_SVA. > + * > + * Device drivers query whether a feature is supported using > + * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature(). > + */ > enum iommu_dev_features { > - IOMMU_DEV_FEAT_AUX, /* Aux-domain feature */ > - IOMMU_DEV_FEAT_SVA, /* Shared Virtual Addresses */ > + IOMMU_DEV_FEAT_AUX, > + IOMMU_DEV_FEAT_SVA, > + IOMMU_DEV_FEAT_IOPF, > }; > > #define IOMMU_PASID_INVALID (-1U) > Reviewed-by: Lu Baolu Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel