From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EC28C636D3 for ; Wed, 1 Feb 2023 11:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VNW31+iAxWcqX+SvfBDhIKHV9TenP3nVr338s0qZz5g=; b=KWTMLY5cG6Z0z+ w4qWId6ELHFausrGu0Ezdm/efQi9kyjEC20FIFDvfptyx8azM6tz6TrLJ21y2pg+10dmW5VVnWC+e jla1XxSUIKRjyaRwhPOyYaMtIErzjPMtTyKzhai97rDYTtsPr/hUDN1IczsgdIUa75tq9GuC1l6Gp fSgqBtKb3NVB9yeg5vl4kXTrQifyn5nLk4rSH8nsV2Ojy0exeOepu7rzd9Uy0Fk5YzbNeL/06XOQ3 Nda9xC7CACN9IIgTggXeUt1FNN21GSsOKufiM/Oc3KxMAxCfnJpYzCAQ1ZYxnP4kj+2dCx35QlJPT 5nUZbncuaX6shrE1F0mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNB8P-00BRdT-Lh; Wed, 01 Feb 2023 11:18:37 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNB8L-00BRbn-PU for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 11:18:36 +0000 Received: by mail-ed1-x532.google.com with SMTP id v10so17305930edi.8 for ; Wed, 01 Feb 2023 03:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LmkNkwc/roPUBoxOIRfaMs2JmM8/cj5oMwOtaYpttR0=; b=DmnxSKU7s6WIyUgSYiMgSy6s+OPOlWELHyjPOLn68AIZ/TRnmhV3B4rswEkHQbvUqk Y3nvRwRgX7qEMRWldjUqTrmEmSDuUsjz2RnaVKK2zFbnK3ugSuXqt2Qc9UzNq+PH4GYa 3JmaNKcn2jcFB4r0BxD6Ps+GbVUFcFbRJueFzcaHEro9R1tC7CXCefdo1+OY7EHnVhSN ti3PkVGtzR4StfY990ViG0dDVR2WOvgj5yqV57QApSP3p+XmiqksrGtrUY3ujHsn51/0 wj9xJVvbjXF93sMxw2SACtJjegkpiv1BjUW+GnKLrWsd8ORz9/1eYHzsBiEvExRHNjoF 5sWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LmkNkwc/roPUBoxOIRfaMs2JmM8/cj5oMwOtaYpttR0=; b=8ILaa9C+4z2hVoLdFCOXs/5ylKawwKu1buiVJsi8zXhdjqnCUKApydMGzy6XDTa+Ih LFhnfk6W1zri3mxIqHQ7OV+3qzgw0OGK6UWWe8KYny8VEuJ6cf3opWLEdW7sBC+jB6kR HY/huhbA3B1aO+YqweRd7PrPVomO5t5f/F/of73EIYu59mNiIw1hXbLaqteszjHrehI1 5cTjMAx/ZLrsq5ij0oUALkR1jG8ZoMOL/5yQPT/na38Z+oTjb3AUCsWXhiYxobUTiw0P PearUtlO0pOHw+gJMZTGRGvFZu9ntV4KeyX5GYTCngL7DLaltFwGXyOsaqjY5XyyoNJg To6g== X-Gm-Message-State: AO0yUKUwaPDLyzGU8B96+rfsMuWieoIVdd1Sq2kQXg7c0z5EYusOGNcI VmYeY7vsp+NDijezaKENzt6qKA== X-Google-Smtp-Source: AK7set8RBAqgYqL/UHyvViSxh65icsNQZmgKHSdri9gKC/VCfijAbqmy6paNIDeBSH0CtXt3GutdKw== X-Received: by 2002:aa7:cd53:0:b0:4a3:43c1:843c with SMTP id v19-20020aa7cd53000000b004a343c1843cmr1313349edw.16.1675250311234; Wed, 01 Feb 2023 03:18:31 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id t21-20020a170906065500b007a4e02e32ffsm9949372ejb.60.2023.02.01.03.18.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 03:18:30 -0800 (PST) Message-ID: <93bec467-d8ff-efd0-4c7f-69e6bd42afbb@linaro.org> Date: Wed, 1 Feb 2023 12:18:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 01/23] interconnect: fix mem leak when freeing nodes Content-Language: en-US To: Johan Hovold , Georgi Djakov Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Sylwester Nawrocki , =?UTF-8?B?QXJ0dXIgxZp3aWdvxYQ=?= , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Georgi Djakov References: <20230201101559.15529-1-johan+linaro@kernel.org> <20230201101559.15529-2-johan+linaro@kernel.org> From: Konrad Dybcio In-Reply-To: <20230201101559.15529-2-johan+linaro@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_031833_856870_CD38FFD6 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1.02.2023 11:15, Johan Hovold wrote: > The node link array is allocated when adding links to a node but is not > deallocated when nodes are destroyed. > > Fixes: 11f1ceca7031 ("interconnect: Add generic on-chip interconnect API") > Cc: stable@vger.kernel.org # 5.1 > Cc: Georgi Djakov > Signed-off-by: Johan Hovold > --- Reviewed-by: Konrad Dybcio Konrad > drivers/interconnect/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index 423f875d4b54..dc61620a0191 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -850,6 +850,7 @@ void icc_node_destroy(int id) > > mutex_unlock(&icc_lock); > > + kfree(node->links); > kfree(node); > } > EXPORT_SYMBOL_GPL(icc_node_destroy); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel