From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx
Date: Tue, 17 Apr 2018 14:37:29 +0100 [thread overview]
Message-ID: <93e7f93c-a2e4-1e16-be4c-b908f88b9897@arm.com> (raw)
In-Reply-To: <20180410183212.16787-7-jae.hyun.yoo@linux.intel.com>
Just a drive-by nit:
On 10/04/18 19:32, Jae Hyun Yoo wrote:
[...]
> +#define PECI_CTRL_SAMPLING_MASK GENMASK(19, 16)
> +#define PECI_CTRL_SAMPLING(x) (((x) << 16) & PECI_CTRL_SAMPLING_MASK)
> +#define PECI_CTRL_SAMPLING_GET(x) (((x) & PECI_CTRL_SAMPLING_MASK) >> 16)
FWIW, <linux/bitfield.h> already provides functionality like this, so it
might be worth taking a look at FIELD_{GET,PREP}() to save all these
local definitions.
Robin.
next prev parent reply other threads:[~2018-04-17 13:37 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 18:32 [PATCH v3 00/10] PECI device driver introduction Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers Jae Hyun Yoo
2018-04-11 11:52 ` Joel Stanley
2018-04-12 2:06 ` Jae Hyun Yoo
2018-04-16 17:59 ` Rob Herring
2018-04-16 23:06 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 02/10] Documentations: ioctl: Add ioctl numbers for PECI subsystem Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core Jae Hyun Yoo
2018-04-19 18:59 ` kbuild test robot
2018-04-23 10:52 ` Greg KH
2018-04-23 17:40 ` Jae Hyun Yoo
2018-04-24 16:01 ` Andy Shevchenko
2018-04-24 16:29 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs Jae Hyun Yoo
2018-04-11 11:52 ` Joel Stanley
2018-04-12 2:11 ` Jae Hyun Yoo
2018-04-16 18:10 ` Rob Herring
2018-04-16 23:12 ` Jae Hyun Yoo
2018-04-17 13:16 ` Rob Herring
2018-04-17 18:16 ` Jae Hyun Yoo
2018-04-17 22:06 ` Jae Hyun Yoo
2018-04-18 13:59 ` Rob Herring
2018-04-18 16:45 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 05/10] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
2018-04-11 11:52 ` Joel Stanley
2018-04-12 2:20 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx Jae Hyun Yoo
2018-04-11 11:51 ` Joel Stanley
2018-04-12 2:03 ` Jae Hyun Yoo
2018-04-17 13:37 ` Robin Murphy [this message]
2018-04-17 18:21 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers Jae Hyun Yoo
2018-04-16 18:14 ` Rob Herring
2018-04-16 23:22 ` Jae Hyun Yoo
2018-04-16 23:51 ` Jae Hyun Yoo
2018-04-17 20:40 ` Jae Hyun Yoo
2018-04-18 14:32 ` Rob Herring
2018-04-18 20:28 ` Jae Hyun Yoo
2018-04-18 21:28 ` Rob Herring
2018-04-18 21:57 ` Jae Hyun Yoo
2018-04-19 19:48 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 08/10] Documentation: hwmon: " Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 09/10] drivers/hwmon: Add " Jae Hyun Yoo
2018-04-10 22:28 ` Guenter Roeck
2018-04-11 21:59 ` Jae Hyun Yoo
2018-04-12 0:34 ` Guenter Roeck
2018-04-12 2:51 ` Jae Hyun Yoo
2018-04-12 3:40 ` Guenter Roeck
2018-04-12 17:09 ` Jae Hyun Yoo
2018-04-12 17:37 ` Guenter Roeck
2018-04-12 19:51 ` Jae Hyun Yoo
2018-04-24 15:56 ` Andy Shevchenko
2018-04-24 16:26 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 10/10] Add a maintainer for the PECI subsystem Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e7f93c-a2e4-1e16-be4c-b908f88b9897@arm.com \
--to=robin.murphy@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).