From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Jinlong Mao <quic_jinlmao@quicinc.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Hao Zhang <quic_hazha@quicinc.com>
Subject: Re: [PATCH v3] coresight: core: Fix coresight device probe failure issue
Date: Wed, 4 May 2022 12:01:46 +0100 [thread overview]
Message-ID: <93f0e003-e9ce-c37f-e603-ddf22ffec0d6@arm.com> (raw)
In-Reply-To: <0ef5aa68-fc1c-6f0b-a1cb-46c5548952db@quicinc.com>
On 15/03/2022 08:52, Jinlong Mao wrote:
>
> On 3/15/2022 4:42 PM, Suzuki K Poulose wrote:
>> On 15/03/2022 08:36, Jinlong Mao wrote:
>>> On 3/10/2022 5:10 PM, Suzuki K Poulose wrote:
>>>> Hi Jinlong
>>>>
>>>>
>>>> On 09/03/2022 14:22, Mao Jinlong wrote:
>>>>> It is possibe that probe failure issue happens when the device
>>>>> and its child_device's probe happens at the same time.
>>>>> In coresight_make_links, has_conns_grp is true for parent, but
>>>>> has_conns_grp is false for child device as has_conns_grp is set
>>>>> to true in coresight_create_conns_sysfs_group. The probe of parent
>>>>> device will fail at this condition. Add has_conns_grp check for
>>>>> child device before make the links and make the process from
>>>>> device_register to connection_create be atomic to avoid this
>>>>> probe failure issue.
>>>>>
>>>>> Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>>>> Suggested-by: Mike Leach <mike.leach@linaro.org>
>>>>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>>>>
>>>> Thanks for the rework. The patch looks good to me.
>>>>
>>>> Suzuki
>>> Thanks Suzuki.
>>>
>>> Hi Mathieu & Mike,
>>>
>>> Could you please help to review and provide your comments for the
>>> PATCH V3 ?
>>
>> Thats what I just said above. The patch looks good to me, I can queue
>> this in the next cycle.
Queued here:
https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/commit/?h=next&id=8c1d3f79d9ca48e406b78e90e94cf09a8c076bf2
Cheers
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-05-04 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:22 [PATCH v3] coresight: core: Fix coresight device probe failure issue Mao Jinlong
2022-03-10 9:10 ` Suzuki K Poulose
2022-03-15 8:36 ` Jinlong Mao
2022-03-15 8:42 ` Suzuki K Poulose
2022-03-15 8:52 ` Jinlong Mao
2022-05-04 11:01 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93f0e003-e9ce-c37f-e603-ddf22ffec0d6@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_hazha@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).