From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AC6EEB64D9 for ; Thu, 6 Jul 2023 05:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a2ch2KhUeC4vGgiAB81lx/eWZoeOi1O9R17c1fPROL4=; b=dqSRIGSjFYaEQg O6xiHjzw8KD4ylI48CHwla6GyCW9hDKF1nFnua+Q5gjhyg1LLjjSvQC+sj8VUZYd5OPml9XkToSBr IlLQ05lMs/IAFZRM3BOTR2p6M18d2fZu/HiIyI5SUksJ4zfmr14Y/k3LBYvAynwyfD/En9Ka3++3F RIkL84h0Cd2J+YNBcgpHOYcxoOCbm//ecC/clems9Eu3FwHbgMpv+Ew3cfgSHl7sqodiUxkNWuspX OJXNGnx0AqhYHkmSJ9K1EaqjVdBt/rEd4OLOcQ+E67hTu+SwrTJ6n8VhXGbX/WpOGlwnlK+b74CXb ZXVOd/YkW2YoN7+FD4ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHHCs-000RsB-1t; Thu, 06 Jul 2023 05:07:06 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHHCp-000Rqw-30 for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2023 05:07:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1688620024; x=1720156024; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=6Ht0rAFs+rZnK+7UtbasxXqvhje9rztLxAQxVYA9THI=; b=H3TDp87Cj3HoYTSIA8eqWpE3093CFiwT5gtQznL9J32R08j2Q42dIerr GdUB0kNFppjbb2vj5Etfc3PjIhXSRrKBBpSSdrSjuTit6/BQd+An+Qnqc l90bDSpFTcr5187jWKuYx0kNT4kMtXofeP/vae+ZTV0ACy5m09eVdz/or mlW83Qmf9eBSJAUdhdsOpywfJ3vmt2KMRSR9p5UlvxencOFgPOSDufNx3 7VNZ44eel6Mogz3IcsnSMS5Gon7+6W+FC/6Jwo5Ws3sbM0JrlyTV4Xw5s A493r8dEsRVceAlM/IsBua/n4B/BPGGQViFCh0YhEmtde3H+AdSRI43y9 w==; X-IronPort-AV: E=Sophos;i="6.01,184,1684792800"; d="scan'208";a="31780937" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Jul 2023 07:06:59 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id BD365280084; Thu, 6 Jul 2023 07:06:58 +0200 (CEST) From: Alexander Stein To: suzuki.poulose@arm.com, coresight@lists.linaro.org, imx@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marek Vasut , Peng Fan , Lucas Stach , Adam Ford , Laurent Pinchart , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list , Frank Li Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: remove arm, primecell-periphid at etm nodes Date: Thu, 06 Jul 2023 07:06:58 +0200 Message-ID: <9405224.NyiUUSuA9g@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230705205954.4159781-1-Frank.Li@nxp.com> References: <20230705205954.4159781-1-Frank.Li@nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_220704_380372_B0BAC040 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, Am Mittwoch, 5. Juli 2023, 22:59:53 CEST schrieb Frank Li: > The reg size of etm nodes is incorrectly set to 64k instead of 4k. This > leads to a crash when calling amba_read_periphid(). After corrected reg > size, amba_read_periphid() retrieve the correct periphid. > arm,primecell-periphid were removed from the etm nodes. So this means the reference manual is wrong here? It clearly states the siz= e = is 64kiB. Reference Manual i.MX8MP Rev 1. 06/2021 On a side note: Is imx8mq affected by this as well? The DAP memory table li= sts = similar sizes in the RM . Best regards, Alexander > Signed-off-by: Frank Li > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > = > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index > cc406bb338fe..e0ca82ff6f15 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -306,8 +306,7 @@ soc: soc@0 { > = > etm0: etm@28440000 { > compatible =3D "arm,coresight-etm4x", = "arm,primecell"; > - reg =3D <0x28440000 0x10000>; > - arm,primecell-periphid =3D <0xbb95d>; > + reg =3D <0x28440000 0x1000>; > cpu =3D <&A53_0>; > clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>; > clock-names =3D "apb_pclk"; > @@ -323,8 +322,7 @@ etm0_out_port: endpoint { > = > etm1: etm@28540000 { > compatible =3D "arm,coresight-etm4x", = "arm,primecell"; > - reg =3D <0x28540000 0x10000>; > - arm,primecell-periphid =3D <0xbb95d>; > + reg =3D <0x28540000 0x1000>; > cpu =3D <&A53_1>; > clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>; > clock-names =3D "apb_pclk"; > @@ -340,8 +338,7 @@ etm1_out_port: endpoint { > = > etm2: etm@28640000 { > compatible =3D "arm,coresight-etm4x", = "arm,primecell"; > - reg =3D <0x28640000 0x10000>; > - arm,primecell-periphid =3D <0xbb95d>; > + reg =3D <0x28640000 0x1000>; > cpu =3D <&A53_2>; > clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>; > clock-names =3D "apb_pclk"; > @@ -357,8 +354,7 @@ etm2_out_port: endpoint { > = > etm3: etm@28740000 { > compatible =3D "arm,coresight-etm4x", = "arm,primecell"; > - reg =3D <0x28740000 0x10000>; > - arm,primecell-periphid =3D <0xbb95d>; > + reg =3D <0x28740000 0x1000>; > cpu =3D <&A53_3>; > clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>; > clock-names =3D "apb_pclk"; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel