From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDD59C54E67 for ; Fri, 15 Mar 2024 12:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iTlMIU0ExW4R5vByuTRuOB10EaeyLt+oQL4v44kQ99o=; b=KOxx1iNPa/29ak KI6Pfhtt1C0Os9Ahj1prnzskJhdSEz08CW6v9vqQ9DrlCFBIKKOVRbGUz/dK3oH0u5rIB5fVK4d4f fzXwTZJEJE00+7xhL9upqJcLEF1SRjN/sXN7BnITN1FgeowI2YcjmslTTnW8BMyZFZ0yF+/TJhF8w qO7iowVWUdfMfyIT/JVqKUhf/Mdnnd9KUgbInfw1zgS9WxAm1EG90IlGAT09v3zkCJzENjkSvUXql OgmGBve8t8ky4w0PkZF2vODyUYWEmXOj2b/4j5b0lYBePLZL1HlFJg2eoS9P2Bu2EkGmEcIXOpS2A zad1ECE7azDYLz0jPaRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl6a7-00000000Ax6-0oql; Fri, 15 Mar 2024 12:22:39 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl6a3-00000000Avo-2UrJ; Fri, 15 Mar 2024 12:22:37 +0000 Received: from i53875a9e.versanet.de ([83.135.90.158] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rl6Zn-0000H4-Sa; Fri, 15 Mar 2024 13:22:19 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org, Jianfeng Liu Cc: sfr@canb.auug.org.au, liujianfeng1994@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, sigmaris@gmail.com, knaerzche@gmail.com Subject: Re: [PATCH v3 2/2] dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible string Date: Fri, 15 Mar 2024 13:22:18 +0100 Message-ID: <9414316.4vTCxPXJkl@diego> In-Reply-To: <20231231151112.3994194-3-liujianfeng1994@gmail.com> References: <20231231151112.3994194-1-liujianfeng1994@gmail.com> <20231231151112.3994194-3-liujianfeng1994@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_052235_659777_7AC68CE2 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Sonntag, 31. Dezember 2023, 16:11:12 CET schrieb Jianfeng Liu: > Add Hantro G1 VPU compatible string for RK3588. > RK3588 has the same Hantro G1 ip as RK3568, which are both > known as VDPU121 in TRM of RK3568 and RK3588. > > Signed-off-by: Jianfeng Liu > --- > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index c57e1f488..16886bccf 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -31,6 +31,9 @@ properties: > - items: > - const: rockchip,rk3228-vpu > - const: rockchip,rk3399-vpu > + - items: > + - const: rockchip,rk3588-vpu > + - const: rockchip,rk3568-vpu at least the rk3588 has multiple v{d/e{.}pu blocks, so this compatible is very misleading. As you mention in the commit description already, this describes the vdpu121, so can we please use that in the compatible as well to distinguish this one from the others that hopefully will come later? Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel