From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: shmobile: irqpin: fix handling of spurious interrupts in DT case
Date: Wed, 15 May 2013 00:07:54 +0200 [thread overview]
Message-ID: <9440947.bdAq5SKB5F@avalon> (raw)
In-Reply-To: <20130328053044.GA25938@verge.net.au>
On Thursday 28 March 2013 14:30:45 Simon Horman wrote:
> On Wed, Mar 27, 2013 at 07:47:47PM +0900, Simon Horman wrote:
> > On Thu, Mar 21, 2013 at 05:05:36PM +0100, Guennadi Liakhovetski wrote:
> > > To disable spurious interrupts, that get triggered on certain hardware,
> > > the irqpin driver masks them on the parent interrupt controller. To
> > > specify such broken devices a .control_parent parameter can be provided
> > > in the platform data. In the DT case we need a property, to do the same.
> > > However, this is not enough to correctly handle spurious interrupts in
> > > the DT case. In the non-DT case all interrupts get mapped statically
> > > during probing, therefore, if a spurious interrupt arrives, it can
> > > easily be mapped back to hardware registers and bits and handled. In the
> > > DT case interrupts are mapped only when a device, using that interrupt
> > > is instantiated from DT. So, spurious interrupts occur unmapped and thus
> > > cannot be handled properly. This patch fixes this by mapping such
> > > interrupts as they occur.
> > >
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> >
> > Thanks, queued up for v3.10 in the intc-external-irq branch of the renesas
> > tree.
>
> As requested by Magnus I have dropped this patch.
I'm running into similar spurious interrupt issues on both kzm9g-reference and
marzen-reference. Magnus, you've rejected this patch, how would you like the
issue to be fixed ? Could you please provide a patch ? This is blocking
pinctrl DT testing, as I can't get any board to boot properly through DT with
ethernet support.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-05-14 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 16:05 [PATCH 0/3] ARM: shmobile: kzm9g: add irqpin to DT Guennadi Liakhovetski
2013-03-21 16:05 ` [PATCH 1/3] ARM: shmobile: irqpin: fix handling of spurious interrupts in DT case Guennadi Liakhovetski
2013-03-27 10:47 ` Simon Horman
2013-03-28 5:30 ` Simon Horman
2013-05-14 22:07 ` Laurent Pinchart [this message]
2013-03-21 16:05 ` [PATCH 2/3] ARM: shmobile: sh73a0: add irqpin DT nodes Guennadi Liakhovetski
2013-03-27 10:47 ` Simon Horman
2013-03-21 16:05 ` [PATCH 3/3] ARM: shmobile: kzm9g-reference: add ethernet support Guennadi Liakhovetski
2013-03-27 10:47 ` Simon Horman
2013-03-27 5:59 ` [PATCH 0/3] ARM: shmobile: kzm9g: add irqpin to DT Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9440947.bdAq5SKB5F@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).