From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67E7FC61DB2 for ; Fri, 13 Jun 2025 11:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yaEX4dDgKDNxKZX0+vcnih4XjDWoAZY8oCSw4SAHFH8=; b=4OcqSGk/U4QXOtHgsKH1Tz//1J 9lNUY+d/6BfdIz20RoBsrh8Y0h8YZkav8S+kDxhoXWEj+pHuAaCYF8fmwglVjtRdV5LxDJChXQ38H VQxo2XD9ne9AGaxjvqdyC/DsCrgNR7fpwwGObAcidYE2j4gbKPmGcLaAlVjctOQqSq9OStTS/Ynsq 2lLpYF6oeTnW4K5m+olUm3upyOGGh0n82Axzi1G5k+p1e9y9+JPYeBe4qhOuZxUcziAYN69ZQO9TD +iDYYo2u5zL7rSNRrZBxItzK4dPRC5oXoysD62/tX7hGeGpBWhPXP1pntB1Yy6qxznB4bzjPJ7MHv PyEHKmoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ2cK-0000000GAZI-2d8n; Fri, 13 Jun 2025 11:30:40 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ0Sb-0000000FsvP-3TzO for linux-arm-kernel@lists.infradead.org; Fri, 13 Jun 2025 09:12:31 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-450cea01b9cso9288705e9.0 for ; Fri, 13 Jun 2025 02:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749805948; x=1750410748; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=yaEX4dDgKDNxKZX0+vcnih4XjDWoAZY8oCSw4SAHFH8=; b=kHT8BeyWwrOdmHbMHetHQetzfnZgsUMvu8cNq4e9xrPivjfaaJZTnwerkgPZ8yxteG UDCSw9XBSF3oB2EEUXQQAbpCKSxQi5hmPMrFsFajI1p95feZGiNE+zpcY0h7Hdzo1vju ZR7yy+K1RmnDqZRZxwgJ8r7QlCfGNonUAwL3ZGB9Pm1fw9/iZigo6ftVXMbj9Rjmtdtl 7ZpFWozfOpE0kSmceF1wLKA/z+FfQgPFo+wJVqXsV7D+kra2GPmKpUaebQjgWBNQr1QA yRioqwASDnsdiKtKZQJHbXm5RQLncYvyq6W+78S78VgZKxhCnst0w8trpWU4o0DuCbdo d5rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749805948; x=1750410748; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yaEX4dDgKDNxKZX0+vcnih4XjDWoAZY8oCSw4SAHFH8=; b=bFlMQ9Kf4xam+WwizUxWl1dbnPx5kp0MMBlKgKeJLg0kD86ElvTnYKu3CWVEmnfnmd 20GXlC7967y+84Ve/KKzUKUjXSWsVlm+oCvfiQpxs2WW6c0x6J9jo+TPmp52HZPBx3wd kFE7wb87bEbuu9YspA9gRmLj79jGTlT+lP0AGIGzdA3d23MKzGw3LMEHqDyn/HrtwVnx P2gLzQkdlv7CrCMdggao99i3t6F5L6aEBzPyndPoR09dm6wjwagr5zlsbIG7i68lhkro Tk9ehT1lbWM8YVedD3nQS4qEP2Zbs0XgoJVcR8C5xAwPYbTDcRhdcxMsXV30z5jQN/b5 XS6A== X-Forwarded-Encrypted: i=1; AJvYcCVcVOTn4A57yG4/hz1kIG2I+9AW1iYPVkgT10HpRS+nRBGcZFP056V0x4efq81zzxtwV8N8hC/gfDbezKnydEy+@lists.infradead.org X-Gm-Message-State: AOJu0YytPb4R4kPVT0lry9IZNyd8Z3wAbTDjobQqXKgGjOy1clBwat/j NM4+nf/A/0C0b31sTW4dz+Met6z/p4e1z6ZX1ZVSr0+x7RMdLnShXgs0DcGFMmDthMg= X-Gm-Gg: ASbGncutl+IpguNCn4Cnqgm3zufMvFOt90MeezC0Z93Xj0Aa8U9QdaWYhSf6avEvNrL ESF9UwQOkz5WYkF3AvxOX32YUB91aaBnKBh0vtLobApxnBq/G9H58Bf3TVOE57lU9soOqouIyLj pS24L2MoWymo1Z2McqXDN+fvvU/L5pKlxLhH44UHsSvjODiJISQuj9kXeGN0Sr4oZwQMIlmVYsS 65U8UwzDJJMrznpFhhqpzenqQyHiMZHOvg2ySFtpJ4VDhRJx2/pkzvQBJ/hL7d/mDeMcCC5kkgd x3qdzro70wjQoXSsGiBo0pglhw3OgxRr/5/j00yR8V635Q2CGXA4u7z5W7/usq3BpAzL7Xr+6Ky 7BebjqJnbhtl9LwTmRnOpmZliqDLROmHNQF70SEGtkwP/8p3OGA== X-Google-Smtp-Source: AGHT+IGfNqq5N/dXfqPTy6lk5lwkJCrvfc3vLmcZOn5YDfPCKU4e2XDDXROymQQp9fqDHIQhZiR3NQ== X-Received: by 2002:a05:600c:34c7:b0:442:f8e7:25ef with SMTP id 5b1f17b1804b1-45334ad3f41mr21047235e9.11.1749805948257; Fri, 13 Jun 2025 02:12:28 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:4144:6a84:fe1d:3aae? ([2a01:e0a:3d9:2080:4144:6a84:fe1d:3aae]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e2446b0sm45162715e9.21.2025.06.13.02.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 02:12:27 -0700 (PDT) Message-ID: <9455a4e1-6352-4832-ac9f-2816f889c3a4@linaro.org> Date: Fri, 13 Jun 2025 11:12:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Subject: Re: [PATCH v3 9/9] arm64: dts: exynos: ExynosAutov920: add USB and USB SS combo phy nodes To: Pritam Manohar Sutar , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com, andre.draszik@linaro.org, peter.griffin@linaro.org, kauschluss@disroot.org, ivo.ivanov.ivanov1@gmail.com, m.szyprowski@samsung.com, s.nawrocki@samsung.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rosa.pila@samsung.com, dev.tailor@samsung.com, faraz.ata@samsung.com, muhammed.ali@samsung.com, selvarasu.g@samsung.com References: <20250613055613.866909-1-pritam.sutar@samsung.com> <20250613055613.866909-10-pritam.sutar@samsung.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250613055613.866909-10-pritam.sutar@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250613_021229_879861_3F03FC90 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/06/2025 07:56, Pritam Manohar Sutar wrote: > Update the USB 3.1 DRD controller and USB31DRD phy nodes to support > SS combo phy for this soc. > > The USB 3.1 DRD controller has the following features: > * DWC3 compatible > * compliant with both USB device 3.1 and USB device 2.0 standards > * compliant with USB host 3.1 and USB host 2.0 standards > * supports USB device 3.1 and USB device 2.0 interfaces > * supports USB host 3.1 and USB host 2.0 interfaces > * full-speed (12 Mbps) and high-speed (480 Mbps) modes with USB device > 2.0 interface > * super-speed (5 Gbps) mode with USB device 3.1 Gen1 interface > * super-speed plus (10 Gbps) mode with USB device 3.1 Gen2 interface > * single USB port which can be used for USB 3.1 or USB 2.0 > * on-chip USB PHY transceiver > * supports up to 16 bi-directional endpoints > * compliant with xHCI 1.1 specification > > USB3.1 SSP+(10Gbps) is supported in this commit and SS phy in combo > phy only supports PIPE3 interface and it is added in index 0 of SS phy. > UTMI+ and PIPE3 PHY interfaces are specified in "phys" property, > UTMI+ (index 0 HS phy) and PIPE3 (index 0 SS phy). > > Signed-off-by: Pritam Manohar Sutar > --- > .../arm64/boot/dts/exynos/exynosautov920-sadk.dts | 4 ++++ > arch/arm64/boot/dts/exynos/exynosautov920.dtsi | 15 +++++++++++++-- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > index a21386bd9af3..40588f7c9998 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > @@ -88,6 +88,10 @@ &xtcxo { > }; > > /* usb */ > +&usbdrd31_ssphy { > + status = "okay"; > +}; > + > &usbdrd31_hsphy { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > index 4efc005cae80..5ee7fad346b9 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > @@ -1048,6 +1048,17 @@ pinctrl_hsi1: pinctrl@16450000 { > interrupts = ; > }; > > + usbdrd31_ssphy: phy@16480000 { > + compatible = "samsung,exynosautov920-usb31drd-ssphy"; > + reg = <0x16480000 0x0200>; > + clocks = <&cmu_hsi1 CLK_MOUT_HSI1_NOC_USER>, > + <&cmu_hsi1 CLK_MOUT_HSI1_USBDRD>; > + clock-names = "phy", "ref"; > + #phy-cells = <1>; > + samsung,pmu-syscon = <&pmu_system_controller>; > + status = "disabled"; > + }; > + > usbdrd31_hsphy: phy@16490000 { > compatible = "samsung,exynosautov920-usbdrd-hsphy"; > reg = <0x16490000 0x0200>; > @@ -1109,8 +1120,8 @@ usbdrd31_dwc3: usb@0 { > <&cmu_hsi1 CLK_MOUT_HSI1_USBDRD>; > clock-names = "ref", "susp_clk"; > interrupts = ; > - phys = <&usbdrd31_hsphy 0>; > - phy-names = "usb2-phy"; > + phys = <&usbdrd31_hsphy 0>, <&usbdrd31_ssphy 0>; > + phy-names = "usb2-phy", "usb3-phy"; > snps,has-lpm-erratum; > snps,dis_u2_susphy_quirk; > snps,dis_u3_susphy_quirk; I think at least patch 6 & 9 should be squashed. Neil