From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600ECC4338F for ; Sat, 24 Jul 2021 16:39:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2218A60E91 for ; Sat, 24 Jul 2021 16:39:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2218A60E91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0P8gWZYWB5MZirL1eYtVJEbTQUA002XEI50e3dgnvp8=; b=Wsxm6QdzygLC1ZBHoPnSBJ5haH zQojArVeGmXh/6IAUk2PA2i7qOUiBJApRMo5LQwIK4FBNY5yNtjirCO47QkU4d8ytSIx3xt69RGT5 Kald4tw4xOnVbMdGYC6a+UH8F5rLlAr8Ywbj3ZIVZZ4r/eARaz1eWG2mNYBirBOhRJ0bYFMZ0alD/ T0N8R+jf+ePkd+BozZ+xG9qq/JVfLtapeXKbSZWmAFI0xOjdonjV/kKrNne0pKaD8bU9YeCr1mDeX JdDa41WcSYG+23rYsdc+qUCCXjBNg2h2nyItlzKsca67X1U1oNNFaBkfIobqLKzbZeO77mdyw65fJ W6TbmfkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Kes-007Ree-4F; Sat, 24 Jul 2021 16:37:50 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Keo-007RdZ-4F for linux-arm-kernel@lists.infradead.org; Sat, 24 Jul 2021 16:37:47 +0000 Received: by mail-pj1-x1034.google.com with SMTP id m10-20020a17090a34cab0290176b52c60ddso2031494pjf.4 for ; Sat, 24 Jul 2021 09:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=58ES39bJrYCI4yZSgZYLWPj6FS4iI+jyIri71waPCCE=; b=RQx8YSnn1sc4taeC5u1cwP1A3qGEWRaEB3oenANQiUCFjI91oamhfvVH3MeHZy01OW 7L/fy8+dIxDliJ0a5xH8zl7cEouuI6nLExmvVBveVOPt4FDJJYYi0gVJ0DqhrDJyGJqj UiXWgRjws0ipXgoHKw7KMpAj8k1yhHouTiNz2d2BF0vAcpwyyIkuyT5pYxaUu6Ozh//S 4X1lP0nhvs+V9bF96mD5IPu4WxW/ujiRMYaAGIcL8L9UupHhxZC3egXbYODURDhWOrWG swJyLJkG64zTB+w9MFdA9ulaf8muGJaAFItwW8sfButzg3qR7zpHgp6U7OGjs0C/iSp3 SPZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=58ES39bJrYCI4yZSgZYLWPj6FS4iI+jyIri71waPCCE=; b=PqkCasdw39EYhzdWgsJFf8ONuY+hjd049UgJGj2Gt/5drsfYMuB9oCMQoeQaMQF9cu v+fbwaxnfrSaEqnZEUjgipNpFQPBgSBiMG09TFojWT1dB6zNDUyrrP7K7s70VUzdJOiF 1JIA/+FMuAfe4a0CI5U9HvmnS/3mumk823z8kXOo2kuzcp+dO4nhW/+inQuSIshSvPri +vucLfTDhYQiY4nJSwOtUeOdBP7JimxNhGdLvgrBKuKPAjQPzkoryAyNNsFAtGD0YyjH WXmfMlt6ysXQmGadK5n2cX70LwEt4s1JsAXm5+SCiCPUAKaYUbdjvppAmafg5c098fr2 S59w== X-Gm-Message-State: AOAM532CQFXHyVWhtNGtPGq4n/78k1gCkouJKrDtATXObHG86sDcvc6P Py2AFJQ39Z21k6YuaK/6+Qc= X-Google-Smtp-Source: ABdhPJwiQiyJ77bf1ENGGXmgUX+ZsNnRLL07yQAJv3Cu7toWAAQJSHfcfemLY/3Gcx2fXKvBNbuUjw== X-Received: by 2002:a65:6489:: with SMTP id e9mr10184228pgv.409.1627144663739; Sat, 24 Jul 2021 09:37:43 -0700 (PDT) Received: from [192.168.1.121] (99-44-17-11.lightspeed.irvnca.sbcglobal.net. [99.44.17.11]) by smtp.gmail.com with ESMTPSA id y30sm7982477pfa.220.2021.07.24.09.37.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jul 2021 09:37:43 -0700 (PDT) Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells To: Vladimir Oltean , Fabio Estevam Cc: davem@davemloft.net, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, qiangqing.zhang@nxp.com, robh+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org References: <20210723112835.31743-1-festevam@gmail.com> <20210723130851.6tfl4ijl7hkqzchm@skbuf> From: Florian Fainelli Message-ID: <9455e5b8-d994-732f-2c3d-88c7a98aaf86@gmail.com> Date: Sat, 24 Jul 2021 09:37:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210723130851.6tfl4ijl7hkqzchm@skbuf> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_093746_228877_2BA09437 X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/23/2021 6:08 AM, Vladimir Oltean wrote: > Hi Fabio, > > On Fri, Jul 23, 2021 at 08:28:35AM -0300, Fabio Estevam wrote: >> Since commit dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into >> phy device node") the following W=1 dtc warnings are seen: >> >> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (avoid_unnecessary_addr_size): /soc/bus@2100000/ethernet@2188000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property >> >> Remove the unnecessary mdio #address-cells/#size-cells to fix it. >> >> Fixes: dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node") >> Signed-off-by: Fabio Estevam >> --- > > Are you actually sure this is the correct fix? If I look at mdio.yaml, I > think it is pretty clear that the "ethernet-phy" subnode of the MDIO > controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If It is valid to omit the "reg" property of an Ethernet PHY which the kernel will then dynamically scan for. If you know the Ethernet PHY address it's obviously better to set it so you avoid scanning and the time spent in doing that. The boot loader could (should?) also provide that information to the kernel for the same reasons. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel