Re: [PATCH 1/2] dt-bindings: arm: rockchip: add Radxa ROCK3 Model C

FUKAUMI Naoki
2024-04-18T06:14:26Z

Hi,

On 4/16/24 22:00, Chukun Pan wrote:
> The Radxa ROCK3 Model C is a similar board to
> the Radxa ROCK3 Model A with the RK3566 SoC.
> Add devicetree binding documentation for it.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 99bd5e2c76a0..dc3847bd67fe 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -777,6 +777,11 @@ properties:
> - const: radxa,rock3a
> - const: rockchip,rk3568
>
> + - description: Radxa ROCK3 Model C

please use "Radxa ROCK 3C" here too.

> + items:
> + - const: radxa,rock3c

and "rock-3c" here.

> + - const: rockchip,rk3566
> +
> - description: Radxa ROCK 5 Model A
> items:
> - const: radxa,rock-5a

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.