From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC724C64EC7 for ; Tue, 28 Feb 2023 08:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qajr5GGj+UaWYhFlRiYrcMpGrxD0MBDGRh1lRiVxglg=; b=GVTYnf1YV9K0dt zMAHOxiEcsC6IWuqCjrwA/+k3Tbnba0LyVifrGup8IGOSfPrhitZDa0Crb4Z/8mxL986LB8rmJ0Vb 5fx/huSsnlpqn6FBcWjmUtfh6UtkhqPLYAEUtsEEt0DCF2PjJYCbrqyDQdWoIsNKYx16suNkDbbOv CeoDn49KmmPDn+2W7aNZOx4DC5nGtvuy3OQa7/N23JZSHrZ3UU5lxPWF+8EW5hullNf3X0yr33YOs 277tVvf+FdqwJhA4I3Py+HIGmWBt4GPkaq9Sn3Ph4Grq/37oSSGHZoAKzJbLDVaNFeR4QUj/VoyOM 0RkQV7PK+Z+FhNI8lKow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWv4c-00CLKr-Ii; Tue, 28 Feb 2023 08:10:58 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWv4a-00CLJV-4u for linux-arm-kernel@lists.infradead.org; Tue, 28 Feb 2023 08:10:57 +0000 Received: by mail-wr1-x435.google.com with SMTP id bv17so8759226wrb.5 for ; Tue, 28 Feb 2023 00:10:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677571845; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1lZT49oy95m22EGxr6coWHrOvpI9jNUmdpagNrbHvNM=; b=kmrYBY92z4EHdQLcGzm06sr1j17uqz820eu2pjqPJ8grXAAIC+X9CD01WC8LQfAqfA Xbl2nB4N8aeoIDPb363pGNI1rt5EnVhSxTZAk1qWlKDbmYpfymiP8UexOKNLkgU7FIsR z+nDLz0PesWcQeHRlP6O37cnA9m5yy3XaKUt90BzlDFwdn5HWO94gN/PqpoErkRNxrpu J4p9eCwIEUQylukbzrmG1BtfJ6SSrSz1Y7jicXY8g1i3h5gxnAlV2url3bckgAUcfuym s2bmRLrN14puvOiP39jkOYkl9s+O/mGUo1Rr6QyO9SYPyWK//ro8DVZRFtt8w0OY6x95 HbXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677571845; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1lZT49oy95m22EGxr6coWHrOvpI9jNUmdpagNrbHvNM=; b=GP9RJdxK/ge6rbbn8IkIUdn6lOF5GTvStijslZT1KRVXil+QjVwPcRVzTWnB/pRG0m 0uC4hKihSwT6irouFYyHzGmRmON2npE7kt/97xFYehSy8lYLpBtChFdiuglvgIawNHIR yfFJOeMI5+mgAYdmKUb3FP9LAtytRzTT9F5CHL2qOH+cNbFvCO9saMY/rP4MuLOlYN6O CFXNlaM+LN4Ph/8I+beOohaewa833fgvwSro4Ad09JjTewX1J97zb49NeQrCXNArLAva fH75aRunxSwg00gomPNh/V1rCNwusO9FqOTzxWEhmOmqaK4J9mLHLsK39XZUp9Yww4VS ijpw== X-Gm-Message-State: AO0yUKVy81h/AkfkChZMv1H//LHYSUrvuJQ9Gg62TRjvTDKMpUI34F8R 9GIuQeYMrhwc/z1tAcZ2RrzW5g== X-Google-Smtp-Source: AK7set9jNkGwv2a2WSq4/mD4IKvMJUFZALH8OCkO/Q+zbLQobS0DnHUXEdt/GO1AVrEG/l1GhQKgjA== X-Received: by 2002:a05:6000:d1:b0:2c6:e87f:30cc with SMTP id q17-20020a05600000d100b002c6e87f30ccmr1388533wrx.48.1677571845301; Tue, 28 Feb 2023 00:10:45 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id i14-20020a05600c354e00b003e91b9a92c9sm12145345wmq.24.2023.02.28.00.10.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 00:10:44 -0800 (PST) Message-ID: <947af937-3178-48ad-998f-b048245f3ffe@linaro.org> Date: Tue, 28 Feb 2023 09:10:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes To: Marco Felsch , Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Abel Vesa , Alexander Stein , Fabio Estevam , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Luca Ceresoli , Lucas Stach , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20230227174535.87657-1-marex@denx.de> <20230227190123.znifdqympsantpt6@pengutronix.de> <20230227200039.ugmtvpli6gvux3fi@pengutronix.de> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230227200039.ugmtvpli6gvux3fi@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230228_001056_217167_57780370 X-CRM114-Status: GOOD ( 14.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/02/2023 21:00, Marco Felsch wrote: >>>> + #sound-dai-cells = <0>; >>> >>> Please don't add it in front of the compatible and the reg property. >> >> The #address-cells and #size-cells are also always on top, why should the >> #sound-dai-cells be any different ? Where should they be ? > > As of now my understanding of specifying a devicetree node was: > > node-name@reg-nr { > compatible = ""; > reg = <>; > // all pending properties below > ... > }; > > @Rob, @Krzysztof: > Is this a (unwritten) rule/policy? > Each platform has its own coding style around this but I am not aware of a coding style which puts address and size cells at the top. To me it is really odd placement. First property is always "compatible", as the most important. Then for most platforms second is "reg", as the one easiest to compare with unit address. Some platforms put status as last property. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel