linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: elfring@users.sourceforge.net (SF Markus Elfring)
To: linux-arm-kernel@lists.infradead.org
Subject: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()
Date: Sun, 23 Apr 2017 14:36:05 +0200	[thread overview]
Message-ID: <947cea53-0373-f756-d73b-030c9b77e2d0@users.sourceforge.net> (raw)
In-Reply-To: <bb42bc46-cb12-cd32-ecd9-ae9b991b476b@math.uni-bielefeld.de>

>> Its implementation of the check ?ALLOC_WITH_MULTIPLY? considers only an other
>> search pattern so far.
>>
>> * Do you find it worthwhile to add a prefix like ?devm_? to the used
>>   regular expression?
>>
>> * Would like to improve any related scripts for the semantic patch language
>>   (Coccinelle software) a bit more?
> I don't understand why you're asking this.

Software developers and code reviewers have got different opinions
about such checks and their relevance.


> I'm talking about the _output_ of checkpatch,

This information is clear at first glance.


> not about the script itself.

But it will not provide the warning you might be looking for
while you seem to find my source code analysis approach and
notifications improvable.
I assume that you might be interested in corresponding extensions
for the involved search patterns.


> But undoubtedly your patch is motivated by the output of said tool.

This tool implemented some checks.


> Hence you should mention that.

Additional tools take also care for similar software development concerns,
don't they?

Can it be appropriate to omit the reference to only one Perl script
for related use cases?

Regards,
Markus

  reply	other threads:[~2017-04-23 12:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22 21:23 [PATCH 0/2] dmaengine: s3c24xx: Fine-tuning for s3c24xx_dma_probe() SF Markus Elfring
2017-04-22 21:24 ` [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() SF Markus Elfring
2017-04-23  9:59   ` Tobias Jakobi
2017-04-23 10:38     ` SF Markus Elfring
2017-04-23 10:44       ` Tobias Jakobi
2017-04-23 11:10         ` SF Markus Elfring
2017-04-23 12:18           ` Tobias Jakobi
2017-04-23 12:36             ` SF Markus Elfring [this message]
2017-04-22 21:25 ` [PATCH 2/2] dmaengine: s3c24xx: Fix a typo in a comment line SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=947cea53-0373-f756-d73b-030c9b77e2d0@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).