From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D037DCE7A89 for ; Sat, 23 Sep 2023 17:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qN8tkM5IJNkn3nStl2yTf+o08gAp0Z7iO0SB3mu5XAQ=; b=fMMpqViCixoBhc 6Vgg9uo3Eco0HinmP+j3HvBfpN8+DbV2ttlehnUv2HVcsmKkzn/JozTStT13E1ZEkiE50ZJosuaOy tAk34uX+HH30QFQh2AF+bQjXQ4oa/FQOvf+YN4YASPAFTRUsQkOWwfX8tQ0x0M5k9lYV0YeFKk7lu OQnIplE4Yr1AxRBur1PwQgXOM+tCdTYOGhSY5MGEcuRllMR7Q+D7huqPAELIqHdNoKGz4bkFKRbsX WXwc9BrlRMoi3egcwid6VkaBwg0kSJujD+M5ZgpdZRDQbHF2Wnj6YsarVe/6o4QvAWvQGov8czk33 j7s/uX7NOYbfV2I3yfmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qk6WG-00BG9A-1B; Sat, 23 Sep 2023 17:34:16 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qk6WC-00BG7y-0j for linux-arm-kernel@lists.infradead.org; Sat, 23 Sep 2023 17:34:13 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3214cdb4b27so3760230f8f.1 for ; Sat, 23 Sep 2023 10:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695490450; x=1696095250; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h8e4WOeV3uP0Avl4Q9o2tfB8fRCYhZPCMlDY4X+oryg=; b=ooRUAmLHMM3EBxSJ91xYpGoUvJCgvY5PtVYJsCA05HmvuygIuEMfOhxgvf7FqSfjaV 0+HgNSknLLNp4GRFrXnSFn3w3+gDZeD3SguZprMb8DSClz/ViGtn3VX1OPPtOCES1JCW jTYN9rybvCvBDUMYtnMCJyJzTdslovkoW+fG44q/FHPqYmJhwW7YPdhtk415wATIKPrX H+qFLA1yW00TZGXPJCJepmEA1C6YlF7nZ3eXIr5FKT9gvfLI92WplL6R+26E1PN3Q7sU uTm9nLKqrgnXfxI99ORWIiHVFExUym6RyHBK1GerqDXrcDq6bSCuEJewOcXTY7YVTeib F+eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695490450; x=1696095250; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h8e4WOeV3uP0Avl4Q9o2tfB8fRCYhZPCMlDY4X+oryg=; b=VozrZNqv7bFxw4VS3nNrX6lJ53jHVKRXRKtL39FQJMFwM6jc9Bf+EPMUhURfpw4oe1 zFmmJIIi2WeMgbWAoIE0WxBjTLfBKXFettMGcphnUS59Gi5AAhOao6nlwWhpeKUUi4nG 9vg/ik+Cs+JDGDTOhVozT3Cpwni96xSjvSB2qzDWogQM/DvWWksk5aCbxUYN8NkMT0Qy sBUzeOUEqyRi+zngFFwIhmcyAip/VcWJOaavf83/H8O8bRJNsR5Sa93RxNKJ9eZWoO2B pi08G4ptKXM40m5XweQn55JBBh5R4RDr8oXT3AY1v1Y563HzsezwxGKSKrLvCsqLlviA Rn9Q== X-Gm-Message-State: AOJu0Yw0VAGvgLtWiCB4TboD054iHbVRrWbb+m/68eHEerHzbUobMDKS TE+Dng3JFk3IXmCivK7E6l1Z1Q== X-Google-Smtp-Source: AGHT+IGywFoLRHTpFCviFneYTV3hIVt1uqS6WEMAUjyo6HuW9R7DnOeXATYbyZiXoF0+vDPukj7PRg== X-Received: by 2002:a5d:44ca:0:b0:31f:fdd8:7d56 with SMTP id z10-20020a5d44ca000000b0031ffdd87d56mr2347231wrr.12.1695490450364; Sat, 23 Sep 2023 10:34:10 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id p13-20020a5d68cd000000b00321673de0d7sm7374280wrw.25.2023.09.23.10.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Sep 2023 10:34:09 -0700 (PDT) Message-ID: <948a37c4-2237-8ec8-270d-8a704c8c4835@linaro.org> Date: Sat, 23 Sep 2023 19:34:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 10/16] dt-bindings: media: mediatek: mdp3: add component TDSHP for MT8195 Content-Language: en-US To: Moudy Ho , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230922072116.11009-1-moudy.ho@mediatek.com> <20230922072116.11009-11-moudy.ho@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230922072116.11009-11-moudy.ho@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230923_103412_305124_30365654 X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/09/2023 09:21, Moudy Ho wrote: > Add the fundamental hardware configuration of component TDSHP, > which is controlled by MDP3 on MT8195. > > Signed-off-by: Moudy Ho > --- > .../bindings/media/mediatek,mdp3-tdshp.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml > new file mode 100644 > index 000000000000..0ac904cbc2c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,mdp3-tdshp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Media Data Path 3 TDSHP > + > +maintainers: > + - Matthias Brugger > + - Moudy Ho > + > +description: > + One of Media Data Path 3 (MDP3) components used to improve image > + sharpness and contrast. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8195-mdp3-tdshp > + > + reg: > + maxItems: 1 > + > + mediatek,gce-client-reg: > + description: > + The register of display function block to be set by gce. There are 4 arguments, > + such as gce node, subsys id, offset and register size. The subsys id that is > + mapping to the register of display function blocks is defined in the gce header > + include/dt-bindings/gce/-gce.h of each chips. > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + items: > + - description: phandle of GCE > + - description: GCE subsys id > + - description: register offset > + - description: register size > + maxItems: 1 > + > + clocks: > + minItems: 1 NAK. So you ignored all the review. Brilliant. I am getting fed up with Mediatek's approach. It's not the first time. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel