From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71876EE499F for ; Wed, 11 Sep 2024 12:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BdmKVpYOCXupjygmurJ7aZLkNXlxQdPPh/zp935/SMc=; b=jAydxZ2FZ76bjBwrEfAMwu31Zg vqaGsmP2d7ulIvw1UuEFiKpDDwVYSja+fkFZHus1WUqaAM+Vuv/1xWkyzqMYQFv4bIgYalP/2RVyZ vEhxdwPP65Dn/vYGo7qpnvR12i2NgBoWTReckoioNjD76LRjNa+eqxGWvNmdz8Y6LdPMzFynnxW63 jhFlgHQRORHGYRICPdPyv6nxYXfrn50Zu1i2nLGOPIVbU5avRZRdvnhQcFA8UshfNmF6MQjm5S3LA LMElMnvlxHKMQ9RlZuFDT8bfNx0t6FjBWjlTam1wOJwYfECcBlE32kQZy+Vb1cOF1DWp47koOW8KO SNu2QuBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soMRf-00000009T7O-0H5j; Wed, 11 Sep 2024 12:27:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soMEG-00000009QUK-2pPw for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 12:13:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4CCA1007; Wed, 11 Sep 2024 05:14:15 -0700 (PDT) Received: from [10.57.76.6] (unknown [10.57.76.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 336653F66E; Wed, 11 Sep 2024 05:13:45 -0700 (PDT) Message-ID: <948daae7-8d94-4d44-93e7-1764f6500be6@arm.com> Date: Wed, 11 Sep 2024 13:13:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] perf: arm-ni: Fix an NULL vs IS_ERR() bug To: Dan Carpenter Cc: Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <04d6ccc3-6d31-4f0f-ab0f-7a88342cc09a@stanley.mountain> From: Robin Murphy Content-Language: en-GB In-Reply-To: <04d6ccc3-6d31-4f0f-ab0f-7a88342cc09a@stanley.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_051348_787622_FB2742F0 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-09-11 8:39 am, Dan Carpenter wrote: > The devm_ioremap() function never returns error pointers, it returns a > NULL pointer if there is an error. Ah, this code went through a few evolutions, and apparently I missed that devm_ioremap() and devm_ioremap_resource() helpfully have different behaviour, urgh. Thanks Dan! Reviewed-by: Robin Murphy > Fixes: 4d5a7680f2b4 ("perf: Add driver for Arm NI-700 interconnect PMU") > Signed-off-by: Dan Carpenter > --- > drivers/perf/arm-ni.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c > index b72df3aea93e..90fcfe693439 100644 > --- a/drivers/perf/arm-ni.c > +++ b/drivers/perf/arm-ni.c > @@ -603,8 +603,8 @@ static int arm_ni_probe(struct platform_device *pdev) > */ > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); > - if (IS_ERR(base)) > - return PTR_ERR(base); > + if (!base) > + return -ENOMEM; > > arm_ni_probe_domain(base, &cfg); > if (cfg.type != NI_GLOBAL)