* [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure [not found] ` <1503999271-15712-1-git-send-email-daniel.lezcano@linaro.org> @ 2017-08-29 9:34 ` Daniel Lezcano 2017-08-29 11:21 ` SF Markus Elfring 0 siblings, 1 reply; 7+ messages in thread From: Daniel Lezcano @ 2017-08-29 9:34 UTC (permalink / raw) To: linux-arm-kernel From: Markus Elfring <elfring@users.sourceforge.net> The bcm2835_timer_init() function emits an error message in case of a memory allocation failure. This is pointless as the mm core already do that. Remove this message. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/bcm2835_timer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/bcm2835_timer.c b/drivers/clocksource/bcm2835_timer.c index 82828d3..39e489a 100644 --- a/drivers/clocksource/bcm2835_timer.c +++ b/drivers/clocksource/bcm2835_timer.c @@ -114,7 +114,6 @@ static int __init bcm2835_timer_init(struct device_node *node) timer = kzalloc(sizeof(*timer), GFP_KERNEL); if (!timer) { - pr_err("Can't allocate timer struct\n"); ret = -ENOMEM; goto err_iounmap; } -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure 2017-08-29 9:34 ` [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure Daniel Lezcano @ 2017-08-29 11:21 ` SF Markus Elfring 2017-08-29 11:42 ` Daniel Lezcano 0 siblings, 1 reply; 7+ messages in thread From: SF Markus Elfring @ 2017-08-29 11:21 UTC (permalink / raw) To: linux-arm-kernel I would prefer to use the wording ?for a? instead of ?on? in the commit subject. > The bcm2835_timer_init() function emits an error message in case of a memory > allocation failure. This is pointless as the mm core already do that. Does this commit message contain a typo? Would a wording like ?? does that already.? be more appropriate here? Regards, Markus ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure 2017-08-29 11:21 ` SF Markus Elfring @ 2017-08-29 11:42 ` Daniel Lezcano 2017-08-29 13:12 ` SF Markus Elfring 0 siblings, 1 reply; 7+ messages in thread From: Daniel Lezcano @ 2017-08-29 11:42 UTC (permalink / raw) To: linux-arm-kernel On 29/08/2017 13:21, SF Markus Elfring wrote: > I would prefer to use the wording ?for a? instead of ?on? in the commit subject. > > >> The bcm2835_timer_init() function emits an error message in case of a memory >> allocation failure. This is pointless as the mm core already do that. > > Does this commit message contain a typo? > Would a wording like ?? does that already.? be more appropriate here? Yep. Fixed. Thanks. -- Daniel -- <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure 2017-08-29 11:42 ` Daniel Lezcano @ 2017-08-29 13:12 ` SF Markus Elfring 2017-08-29 13:16 ` Daniel Lezcano 0 siblings, 1 reply; 7+ messages in thread From: SF Markus Elfring @ 2017-08-29 13:12 UTC (permalink / raw) To: linux-arm-kernel >> Would a wording like ?? does that already.? be more appropriate here? > > Yep. Fixed. Thanks for this adjustment. https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa Do you disagree to my suggestion to amend also the commit subject? Regards, Markus ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure 2017-08-29 13:12 ` SF Markus Elfring @ 2017-08-29 13:16 ` Daniel Lezcano 2017-08-29 13:20 ` SF Markus Elfring 0 siblings, 1 reply; 7+ messages in thread From: Daniel Lezcano @ 2017-08-29 13:16 UTC (permalink / raw) To: linux-arm-kernel On 29/08/2017 15:12, SF Markus Elfring wrote: >>> Would a wording like ?? does that already.? be more appropriate here? >> >> Yep. Fixed. > > Thanks for this adjustment. > https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa > > Do you disagree to my suggestion to amend also the commit subject? Just wanted to keep it short. -- <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* clocksource/drivers/bcm2835: Remove message on memory allocation failure 2017-08-29 13:16 ` Daniel Lezcano @ 2017-08-29 13:20 ` SF Markus Elfring 2017-08-29 13:26 ` Daniel Lezcano 0 siblings, 1 reply; 7+ messages in thread From: SF Markus Elfring @ 2017-08-29 13:20 UTC (permalink / raw) To: linux-arm-kernel >> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa >> >> Do you disagree to my suggestion to amend also the commit subject? > > Just wanted to keep it short. I propose to reconsider the preposition which should be used in the title. Regards, Markus ^ permalink raw reply [flat|nested] 7+ messages in thread
* clocksource/drivers/bcm2835: Remove message on memory allocation failure 2017-08-29 13:20 ` SF Markus Elfring @ 2017-08-29 13:26 ` Daniel Lezcano 0 siblings, 0 replies; 7+ messages in thread From: Daniel Lezcano @ 2017-08-29 13:26 UTC (permalink / raw) To: linux-arm-kernel On 29/08/2017 15:20, SF Markus Elfring wrote: >>> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa >>> >>> Do you disagree to my suggestion to amend also the commit subject? >> >> Just wanted to keep it short. > > I propose to reconsider the preposition which should be used in the title. Done. -- <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-29 13:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170829093354.GA2572@mai>
[not found] ` <1503999271-15712-1-git-send-email-daniel.lezcano@linaro.org>
2017-08-29 9:34 ` [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure Daniel Lezcano
2017-08-29 11:21 ` SF Markus Elfring
2017-08-29 11:42 ` Daniel Lezcano
2017-08-29 13:12 ` SF Markus Elfring
2017-08-29 13:16 ` Daniel Lezcano
2017-08-29 13:20 ` SF Markus Elfring
2017-08-29 13:26 ` Daniel Lezcano
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).