From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58E74C2BA15 for ; Mon, 17 Jun 2024 12:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d8Fhf4JOX+eQHmfKJgo0VL59I075x6PJI/pMFa803UQ=; b=PH/MXILqLMyT6oXiR7NO2Somnk hZi6cnm78szRH3n7SnxYelaV1kKgtN7e3Y6GpPNG5yAqgRgTYM2JO27fLw0Nob7K0hQRZ+neJ4mSw 2RddB1JIeQ67dASkhVlVHU4sUfsuL9mRkPb+CRSFhNSMW/6q4a/26adJUzY/joN830xd4s2bC3kyN U8Lsb0CiTXWhiPdSA72PexKgKBi9b+R5f/W2zeUmyJilMyTVADnlJC5Pr34WmNvAzGqZ0XXpdzExj jD0/vBy6tAqd+VF0n6fIrshy1xsIPlYR8PSLj6d6d6xE4ei2cCMCM4fpCGVCG9flIWlhGnXfsd3c2 tNiePXXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJB4n-0000000Aaas-38wb; Mon, 17 Jun 2024 12:03:09 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJB4k-0000000AaYR-2FM4 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 12:03:08 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-42172ab4b60so37568445e9.0 for ; Mon, 17 Jun 2024 05:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718625781; x=1719230581; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d8Fhf4JOX+eQHmfKJgo0VL59I075x6PJI/pMFa803UQ=; b=uPneFReEYPVx+SvQOC4GSNmidil2euKuzRsafDRYJlPHyDRrMVWql9Cx8e5CD0wW9d KuGNDUGS8RCkPUQHx83nqg1jPXbQStvliY+tKbIAidlGa76Jg5BSflEcTHNDeVitN4BK lhxGAfn7tcTuhLmVVl1kpnSakbQC3J4BEo45S28ir31xdV7HPOMGGBQh7NQGqeyGz9x1 u6Br8o75PthO5BbsYzd3kkGgrAhSbj8NUsReZwTYSCz+KTPmih1s3K3awM1IZZsgm8Ks v3QfpXwXJ0sevSXdZS6JoyB0V9zbus2uHV4w/yWgYUHMYkhJrpvIUYqzRPBXCNq2E9YG S5yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718625781; x=1719230581; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d8Fhf4JOX+eQHmfKJgo0VL59I075x6PJI/pMFa803UQ=; b=b/tIRFS30kNJdeiLy3fInojhbRLtYp7qQWFxwJzMem/aExv8nZ13+8sTe1nqszr7BQ UDrgDQNtUappRGXlL41YYOJfbdeKw35lHRRQgcbEh8kxCvbwvFA7aAFukRZ1ljejEDzx n0QoZ8dICaQjmpapf8vSh6r1I1c21hnIyWkBuTWTIzQcxds26RYY373N7M6/bc14aI8o 2Y8SP3bl0D7M/UR4JTGkYLw+/c9tSEqehxameTruY+wcFpkiK5flnicpf3vu8MTNEiCc 5qiHdpLXZdsG345laQsyKBnQKr/MfsI/djbDWiRFN8EU35m+AMofeRNOuHAB4Y8qpPZJ PVIQ== X-Forwarded-Encrypted: i=1; AJvYcCWNWlcEsmHr9xJ7RJsEOaX7g+tRG6Buxf3jLS0x53F+8H0msbBfWLPQZkeXasxKle90G0LdokMKn8gyvAXnaIge6a6SEUisbnnTPxOnnXGV7ylgxWI= X-Gm-Message-State: AOJu0Yw732R1mGv/XRQRkCaCnztN9ExRh6AZ44v++g9XcmH1bQhP94S+ iP8Iioii5YnLT1tFLjwBuwkVNLj2GZmZOgzu7aEOTTWBkW54lURLmEUqQrhjj3Q= X-Google-Smtp-Source: AGHT+IETqjtVw4vm/BaAXb+7+BMz4Su+YcAJ5zJwSTOWHGTDcdm9ORyc65IHd9xEKGG8oTMrigZ+jg== X-Received: by 2002:a05:600c:1d0f:b0:423:4c2:7a43 with SMTP id 5b1f17b1804b1-42304c27b17mr80244375e9.0.1718625781238; Mon, 17 Jun 2024 05:03:01 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f6127c1esm156486645e9.23.2024.06.17.05.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 05:03:00 -0700 (PDT) Date: Mon, 17 Jun 2024 15:02:56 +0300 From: Dan Carpenter To: Detlev Casanova Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Greg Kroah-Hartman , Sebastian Reichel , Dragan Simic , Alexey Charkov , Cristian Ciocaltea , Diederik de Haas , Andy Yan , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 1/3] media: rockchip: Introduce the rkvdec2 driver Message-ID: <94b9e0fd-2f4f-4d75-ae39-7d780a4e6374@moroto.mountain> References: <20240615015734.1612108-1-detlev.casanova@collabora.com> <20240615015734.1612108-2-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240615015734.1612108-2-detlev.casanova@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_050306_684348_475843B0 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2024 at 09:56:27PM -0400, Detlev Casanova wrote: > +static int rkvdec2_start_streaming(struct vb2_queue *q, unsigned int count) > +{ > + struct rkvdec2_ctx *ctx = vb2_get_drv_priv(q); > + const struct rkvdec2_coded_fmt_desc *desc; > + int ret, i; > + u32 width, height; > + > + if (V4L2_TYPE_IS_CAPTURE(q->type)) > + return 0; > + > + desc = ctx->coded_fmt_desc; > + if (WARN_ON(!desc)) > + return -EINVAL; > + > + width = ctx->decoded_fmt.fmt.pix_mp.width; > + height = ctx->decoded_fmt.fmt.pix_mp.height; > + for (i = 0; i < RKVDEC2_RCB_COUNT; i++) { > + ctx->rcb_bufs[i].cpu = > + dma_alloc_coherent(ctx->dev->dev, > + RCB_SIZE(i), > + &ctx->rcb_bufs[i].dma, > + GFP_KERNEL); > + if (!ctx->rcb_bufs[i].cpu) { > + ret = -ENOMEM; > + goto err_rcb; > + } > + } > + > + if (desc->ops->start) { > + ret = desc->ops->start(ctx); > + if (ret) > + goto err_ops_start; > + } > + > + return 0; > + > +err_ops_start: > +err_rcb: > + i--; > + while (i) { > + dma_free_coherent(ctx->dev->dev, > + RCB_SIZE(i), > + ctx->rcb_bufs[i].cpu, > + ctx->rcb_bufs[i].dma); > + i--; > + } This will leak the first element of the ctx->rcb_bufs[i] array. The traditional way to write this is either while (--i >= 0) or for unsigned int i iterators it would be while (i--). > + > + return ret; > +} regards, dan carpenter