From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E441DCD11C2 for ; Fri, 5 Apr 2024 05:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ppvrInDT6rCQU1TKtVstEyPtHjJG/y7xjE5wkd8obBs=; b=rG/ONzHLJMzwFP 0RKk5eyzEVV6Ted9Gbk3QOQuB2pNIKAlzQd2j4OLRfXPG1RXLocm17UjK+Jxvn/eFx0aNSdBzkgQS 5hGPI1aUsF2dV58Ob5Ox/to4/aGIAQDC6uhSEkkwohZ9yw/09iuB4beuW51f4UIoD7bauLMLN6o+z Mx+xmWQ/4DXMy5BcpEjaa5HSKjVle36c6LuG3tcuZVYr82Y6DyHNyJCtrbFf5qlP+eXECO/+EMKjR TF6a/wki/lS3kO7wllYj/Y8gZXJNfvzpPJGdcOaZb8Guu6BVf28bZnbje12ZeshqLq1AT6mNGeBm/ +X0c3bbX0U+gUXf9zCZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsc19-00000005HZG-2mGP; Fri, 05 Apr 2024 05:21:35 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsc15-00000005HXp-2hNK for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 05:21:33 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 4355LMkL032194; Fri, 5 Apr 2024 00:21:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1712294482; bh=rUC31u9nczDP7owyqjPSB+1Eq1oH+xM4RGziXzYW0k8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=AhJi/sZG9+dE6kumgP/Ws/t/dcNQDpfOEIaHs1NQTS6VM0q1V+FDjTLzjzjbCnE/1 sbq/iHzZhOXXv1LgOggYzY9ZVYE0QJX8aRfoDTZZp8VGll+cQvoo09wr77Y8seZjqu 6/5dJbKYdKLTOkt506O69Wq4aZw6vK3CCG28nDLk= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 4355LLAR047800 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Apr 2024 00:21:22 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 5 Apr 2024 00:21:21 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 5 Apr 2024 00:21:21 -0500 Received: from localhost (uda0492258.dhcp.ti.com [172.24.227.9]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4355LK0C089520; Fri, 5 Apr 2024 00:21:21 -0500 Date: Fri, 5 Apr 2024 10:51:20 +0530 From: Siddharth Vadapalli To: Krzysztof Kozlowski CC: Siddharth Vadapalli , , , , , , , , Subject: Re: [PATCH] dt-bindings: mfd: syscon: Add ti,am62p-cpsw-mac-efuse compatible Message-ID: <94bae793-ba4f-467f-917d-213fa3cd6faa@ti.com> References: <20240402105708.4114146-1-s-vadapalli@ti.com> <2e9b6a91-43d3-4b23-830d-40e607505d8c@kernel.org> <30065bdc-ccef-4610-b1c1-7661f801b8e9@ti.com> <4b1380a8-0136-4395-ba42-9bcff2e1bdb0@kernel.org> <083e50de-1c99-4a58-8b55-4dec26d97c1b@kernel.org> <9bca7d94-142e-4717-aea7-437805717a00@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_222131_967861_524BC027 X-CRM114-Status: GOOD ( 38.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2024 at 02:02:21PM +0530, Siddharth Vadapalli wrote: > On Wed, Apr 03, 2024 at 12:18:10PM +0530, Siddharth Vadapalli wrote: > > On Wed, Apr 03, 2024 at 08:40:19AM +0200, Krzysztof Kozlowski wrote: > > > On 03/04/2024 08:32, Siddharth Vadapalli wrote: > > > > On Wed, Apr 03, 2024 at 08:27:06AM +0200, Krzysztof Kozlowski wrote: > > > >> On 03/04/2024 07:35, Siddharth Vadapalli wrote: > > > >>> On Tue, Apr 02, 2024 at 08:06:27PM +0200, Krzysztof Kozlowski wrote: > > > >>>> On 02/04/2024 14:30, Siddharth Vadapalli wrote: > > > >>>>> On Tue, Apr 02, 2024 at 02:08:32PM +0200, Krzysztof Kozlowski wrote: > > > >>>>>> On 02/04/2024 12:57, Siddharth Vadapalli wrote: > > > >>>>>>> The CTRLMMR_MAC_IDx registers within the CTRL_MMR space of TI's AM62p SoC > > > >>>>>>> contain the MAC Address programmed in the eFuse. Add compatible for > > > >>>>>>> allowing the CPSW driver to obtain a regmap for the CTRLMMR_MAC_IDx > > > >>>>>>> registers within the System Controller device-tree node. The default MAC > > > >>>>>>> Address for the interface corresponding to the first MAC port will be set > > > >>>>>>> to the value programmed in the eFuse. > > > >>>>>>> > > > >>>>>>> Signed-off-by: Siddharth Vadapalli > > > >>>>>>> --- > > > >>>>>>> > > > >>>>>>> This patch is based on linux-next tagged next-20240402. > > > >>>>>> > > > >>>>>> Where is the DTS using it? > > > >>>>> > > > >>>>> The current implementation in the device-tree for older TI K3 SoCs is as > > > >>>>> follows: > > > >>>>> > > > >>>>> cpsw_port1: port@1 { > > > >>>>> reg = <1>; > > > >>>>> ti,mac-only; > > > >>>>> label = "port1"; > > > >>>>> phys = <&phy_gmii_sel 1>; > > > >>>>> mac-address = [00 00 00 00 00 00]; > > > >>>>> ti,syscon-efuse = <&wkup_conf 0x200>; > > > >>>>> }; > > > >>>>> > > > >>>>> The "ti,syscon-efuse" property passes the reference to the System > > > >>>>> Controller node as well as the offset to the CTRLMMR_MAC_IDx registers > > > >>>>> within the CTRL_MMR space. > > > >>>> > > > >>>> Please reference upstream DTS or lore link to patch under review. > > > >>> > > > >>> An example of the existing implementation in the device-tree for AM64x > > > >>> is: > > > >>> https://github.com/torvalds/linux/blob/d4e8c8ad5d14ad51ed8813442d81c43019fd669d/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L697 > > > >>> It uses: > > > >>> ti,syscon-efuse = <&main_conf 0x200>; > > > >>> > > > >>> and "main_conf" node is defined at: > > > >>> https://github.com/torvalds/linux/blob/d4e8c8ad5d14ad51ed8813442d81c43019fd669d/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L40 > > > >> > > > >> It is quite different than your bindings, so your bindings are incorrect. > > > > > > > > Sorry I didn't understand what you mean. The references I have provided > > > > are for existing DTS where "main_conf"/"wkup_conf" (System Controller > > > > nodes) have the compatible "syscon", unlike in AM62p at: > > > > https://github.com/torvalds/linux/blob/20f8173afaac90dd9dca11be4aa602a47776077f/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi#L8 > > > > which has the "simple-bus" compatible for the "wkup_conf" node. > > > > > > > > Also, shouldn't the device-tree bindings patches be posted first and get > > > > merged before I post the device-tree patches that utilize the > > > > compatible/properties that have been added in the bindings? That is the > > > > reason why I had shared the "DIFF" for the DTS changes that I will be > > > > posting once this patch for the new compatible is accepted. > > > > > > > > > > That's not the process. I will be NAKing bindings which do not have any > > > users, because I do not trust you test them. > > > > > > The process is almost always: > > > 1. Send bindings, > > > 2. Send driver changes (if applicable) in the same patchset. > > > 3. Send DTS, usually in separate patches and provide lore link to the > > > bindings in the changelog or cover letter. > > > > Thank you for clarifying. I will post the DTS patches corresponding to > > this patch and reference this patch in the DTS patch series. > > I have posted the DTS patch at: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20240404081845.622707-1-s-vadapalli@ti.com/ > indicating the dependency on this bindings patch. Hello Krzysztof, Do I have to post a v2 for this patch? You had Acked it initially but I am not sure if the discussion so far will make it unclear to readers regarding the acceptance of this patch. Thank you for Acking the v3 DTS patch at: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20240404124614.891416-1-s-vadapalli@ti.com/ Since the v3 DTS patch mentions this bindings patch as a dependency, I wanted to be sure whether I have to post a v2 for this or that won't be required. Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel