From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE75C48BE3 for ; Thu, 20 Jun 2019 18:08:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59B6421530 for ; Thu, 20 Jun 2019 18:08:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f+h0xD2g"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YlqAVIiA"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="agu9uSKc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B6421530 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OFeDzTYKsjXtlk0A+z9XKC8UQf8M5iaEaKaeZzj9k0Q=; b=f+h0xD2g1mouhzJJfU2eCvFz5 gW0axUfrOdn8yKPxxRTw1981/SH0rvLTH17yiUirlNEgvS3qI3f5rwcVg5UMK/vjZCHn7NR6qaIMJ z4eQFnTIeCRQBO4XVUZPprXVhxVzL+FjEdmQ8kfeUper524docAj6RWARPN/LSp/kXqD3lsgHYoRj P1hF9eFzzaW0GNKteClyrIkN1I1e9vM9PRDXCuOQq/R3QiH1EwmOZlPtJZhIBZV+7e9RxQKhPEmuf vsfOeuh8l98o4dhNhbzH76YK161J70RwNR9zIsHNnaR5VQBG+vWo6WjQozB365aQ0whBIdySlfYXU GRVTaWLbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he1Ta-0004iw-MW; Thu, 20 Jun 2019 18:07:58 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1he1TY-0004iK-5H for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 18:07:57 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A858360C5F; Thu, 20 Jun 2019 18:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561054075; bh=7oF5FYVB4lfqoUS0Whfvt1/H7DjfkYY/IRM8xOGXllU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YlqAVIiA/lKJzIFFZUt+ZrM+/+ZM1rCumypNtbH6LGaFGEA9Q8cSyP7b7n6XjfO8E Wt3JyOhza6IxlHDHi6IIVRr/Yi0c21NV1HgpqRn7NcCAOYGrG/DqpG9/UHEVsl+rN5 VS/KzxwBvWmab6sEkffzjmLm0XBZfrPlFwSgNpdE= Received: from [192.168.1.100] (unknown [157.45.245.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4309760E57; Thu, 20 Jun 2019 18:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561054074; bh=7oF5FYVB4lfqoUS0Whfvt1/H7DjfkYY/IRM8xOGXllU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=agu9uSKcqLRU1u8dTJcRsoe5C4M6B+ntgNfLUgVMBz+jj2LE6WkQBaXE3SkqP0MRu rf/B6aRW/MyrsRTed2F2jFmJj/pBTu8sUwSSjIn4CfprmjyP0nhwACjGX/x33JPI5O CinIvimXEuZa97ng+wQ2GNtkrUmfHVtjjgP3ZopA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4309760E57 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org Subject: Re: [PATCH 2/2] coresight: Abort probe for missing CPU phandle To: Mathieu Poirier References: <20190620174308.GB5581@xps15> From: Sai Prakash Ranjan Message-ID: <94bd685a-1c03-f234-7d3c-e5df0856845b@codeaurora.org> Date: Thu, 20 Jun 2019 23:37:45 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190620174308.GB5581@xps15> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_110756_232287_E0F36C1B X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rajendra Nayak , Suzuki K Poulose , Alexander Shishkin , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, David Brown , Sibi Sankar , Vivek Gautam , Leo Yan , Andy Gross , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, Thanks for the review comments. On 6/20/2019 11:13 PM, Mathieu Poirier wrote: > On Thu, Jun 20, 2019 at 07:15:47PM +0530, Sai Prakash Ranjan wrote: >> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c >> index 07a1367c733f..43f32fa71ff9 100644 >> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c >> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c >> @@ -579,6 +579,9 @@ static int debug_probe(struct amba_device *adev, const struct amba_id *id) >> return -ENOMEM; >> >> drvdata->cpu = coresight_get_cpu(dev); >> + if (drvdata->cpu == -ENODEV) >> + return -ENODEV; > > As Suzuki pointed out, simply return the error message conveyed by > coresight_get_cpu(). > > Also please merge both patches together to avoid bisect nightmare. Sure, will do it. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel