Re: [PATCH v2 1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only

Lorenzo Pieralisi
2021-12-01T17:19:32Z

On Wed, Dec 01, 2021 at 06:01:46PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 01, 2021 at 03:53:21PM +0000, Lorenzo Pieralisi wrote:
> > On Mon, 15 Nov 2021 13:20:00 +0200, Andy Shevchenko wrote:
> > > Use BIT() as __GENMASK() is for internal use only. The rationale
> > > of switching to BIT() is to provide better generated code. The
> > > GENMASK() against non-constant numbers may produce an ugly assembler
> > > code. On contrary the BIT() is simply converted to corresponding shift
> > > operation.
> > >
> > > Note, it's the only user of __GENMASK() in the kernel outside of its own realm.
> > >
> > > [...]
> >
> > Applied to pci/brcmstb, thanks!
> >
> > [1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only
> > https://git.kernel.org/lpieralisi/pci/c/6ec6eb949d
>
> Thanks, but there is another patch which changes the logic a bit and cleans up
> more.
>
> From: Florian Fainelli <f.fainelli@gmail.com>
> Subject: [PATCH] PCI: brcmstb: Do not use __GENMASK

Right,

I pulled that one instead, thanks for the heads-up.

Lorenzo