From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA92DC43381 for ; Tue, 26 Mar 2019 11:34:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A786D2075D for ; Tue, 26 Mar 2019 11:34:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OOXtWpsj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A786D2075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GUsTXW6CZrw7gRsehA7d7l0o8d4Ioj7WMihujjvllGs=; b=OOXtWpsjKkd/e5 cr5Afr4UvU8Z9va89SiqVtpLCx8ENH5Om0qBp28e4Hlq70AfQNcgDt16PTvXMV5im5RwZ5AzRZPnf CNq5neWFKVYCt9zAoUuu47XP9THpU9SCBzbKhdTctyfhBAomrOoSaQpMYMAe7ET1WzwIdjgb26V2t mC8dTizEDHmHvpxExjz3CXo2tXyJ+FTeC7XJcn8u1yhI6Ysfa09OnGsQhNYmlQrQyymSyffFzvTro EszzlTj6x9FWA6V5oL2TwT9OKL3DDhS2SC9fB03PAQ5aBvQWUwo+ktHm516IxjYJvdcpWyr81UMzh BtqtcjIVnGeDG2ocElVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8kM2-0002rq-3S; Tue, 26 Mar 2019 11:34:54 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8kLz-0002qN-Sz for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 11:34:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B8AA1596; Tue, 26 Mar 2019 04:34:45 -0700 (PDT) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 444183F59C; Tue, 26 Mar 2019 04:34:44 -0700 (PDT) Subject: Re: [PATCH] firmware: arm_scmi: check return value of idr_find To: Kangjie Lu References: <225abd6e-4551-213d-367b-93d938789188@arm.com> <20190325204823.5428-1-kjlu@umn.edu> From: Steven Price Message-ID: <94d8e411-1eef-1450-4828-5faabb03a3d1@arm.com> Date: Tue, 26 Mar 2019 11:34:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325204823.5428-1-kjlu@umn.edu> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_043451_946166_77E58266 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pakki001@umn.edu, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/03/2019 20:48, Kangjie Lu wrote: > Thanks for Steven Price's review of this patch. In the current code, There's no need to include a "thanks" message in the commit message - the "Reviewed-by" tag is sufficient. Please also remember to include an appropriate version tag in the subject - this should be "v2". Thanks, Steve > idr_find won't return NULL because the SCMI_PROTOCOL_BASE id must > exist. However, it might return NULL in the future code if the check > is on another node while processing the children in subsequent calls > to scmi_mbox_chan_setup(). > Therefore, the patch conservatively checks the return value and > returns -EINVAL when it indeed failed. > > Signed-off-by: Kangjie Lu > Reviewed-by: Steven Price > --- > drivers/firmware/arm_scmi/driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 8f952f2f1a29..35faa203d549 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -709,6 +709,8 @@ scmi_mbox_chan_setup(struct scmi_info *info, struct device *dev, int prot_id) > > if (scmi_mailbox_check(np)) { > cinfo = idr_find(&info->tx_idr, SCMI_PROTOCOL_BASE); > + if (!cinfo) > + return -EINVAL; > goto idr_alloc; > } > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel