From: Krzysztof Kozlowski <krzk@kernel.org>
To: long.yunjian@zte.com.cn, hjc@rock-chips.com
Cc: heiko@sntech.de, andy.yan@rock-chips.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
fang.yumeng@zte.com.cn, mou.yi@zte.com.cn, xu.lifeng1@zte.com.cn,
ouyang.maochun@zte.com.cn
Subject: Re: [PATCH] drm/rockchip: Use dev_err_probe() to simplify code
Date: Thu, 15 May 2025 17:54:20 +0200 [thread overview]
Message-ID: <94e0951b-46e1-439b-9dbc-c2009a78b04b@kernel.org> (raw)
In-Reply-To: <20250515203554564-j1jBXUXR6bdiN6zARicC@zte.com.cn>
On 15/05/2025 14:35, long.yunjian@zte.com.cn wrote:
> From: Yumeng Fang <fang.yumeng@zte.com.cn>
>
> In the probe path, dev_err() can be replaced with dev_err_probe()
That's not probe path. I am not sure if you really understand this code.
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yumeng Fang <fang.yumeng@zte.com.cn>
Incomplete chain.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-15 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:35 [PATCH] drm/rockchip: Use dev_err_probe() to simplify code long.yunjian
2025-05-15 15:54 ` Krzysztof Kozlowski [this message]
2025-05-16 9:58 ` Heiko Stübner
2025-05-22 8:45 ` Krzysztof Kozlowski
2025-05-23 9:36 ` Andy Yan
2025-07-08 17:35 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94e0951b-46e1-439b-9dbc-c2009a78b04b@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fang.yumeng@zte.com.cn \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=long.yunjian@zte.com.cn \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mou.yi@zte.com.cn \
--cc=mripard@kernel.org \
--cc=ouyang.maochun@zte.com.cn \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=xu.lifeng1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).