linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] dt-bindings: pwm: convert lpc32xx-pwm.txt to yaml format
@ 2025-06-24 20:09 Frank Li
  2025-06-25  0:37 ` Vladimir Zapolskiy
  0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2025-06-24 20:09 UTC (permalink / raw)
  To: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vladimir Zapolskiy, Piotr Wojtaszczyk,
	open list:PWM SUBSYSTEM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/LPC32XX SOC SUPPORT, open list
  Cc: imx

Convert pc32xx-pwm.txt to yaml format.

Additional changes:
- add ref to pwm.yaml
- restrict #pwm-cells to 3

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/pwm/lpc32xx-pwm.txt   | 17 --------
 .../bindings/pwm/nxp,lpc3220-pwm.yaml         | 41 +++++++++++++++++++
 2 files changed, 41 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml

diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
deleted file mode 100644
index 74b5bc5dd19ac..0000000000000
--- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-LPC32XX PWM controller
-
-Required properties:
-- compatible: should be "nxp,lpc3220-pwm"
-- reg: physical base address and length of the controller's registers
-
-Examples:
-
-pwm@4005c000 {
-	compatible = "nxp,lpc3220-pwm";
-	reg = <0x4005c000 0x4>;
-};
-
-pwm@4005c004 {
-	compatible = "nxp,lpc3220-pwm";
-	reg = <0x4005c004 0x4>;
-};
diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
new file mode 100644
index 0000000000000..b82d52f583df8
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/nxp,lpc3220-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP LPC32XX PWM controller
+
+maintainers:
+  - Frank Li <Frank.Li@nxp.com>
+
+properties:
+  compatible:
+    enum:
+      - nxp,lpc3220-pwm
+      - nxp,lpc3220-motor-pwm
+
+  reg:
+    maxItems: 1
+
+  '#pwm-cells':
+    const: 3
+
+required:
+  - compatible
+  - reg
+  - '#pwm-cells'
+
+allOf:
+  - $ref: pwm.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pwm@4005c000 {
+        compatible = "nxp,lpc3220-pwm";
+        reg = <0x4005c000 0x4>;
+        #pwm-cells = <3>;
+    };
+
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] dt-bindings: pwm: convert lpc32xx-pwm.txt to yaml format
  2025-06-24 20:09 [PATCH 1/1] dt-bindings: pwm: convert lpc32xx-pwm.txt to yaml format Frank Li
@ 2025-06-25  0:37 ` Vladimir Zapolskiy
  2025-06-25  4:04   ` Frank Li
  0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Zapolskiy @ 2025-06-25  0:37 UTC (permalink / raw)
  To: Frank Li, Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Piotr Wojtaszczyk, open list:PWM SUBSYSTEM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/LPC32XX SOC SUPPORT, open list
  Cc: imx

On 6/24/25 23:09, Frank Li wrote:
> Convert pc32xx-pwm.txt to yaml format.
> 
> Additional changes:
> - add ref to pwm.yaml
> - restrict #pwm-cells to 3
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>   .../devicetree/bindings/pwm/lpc32xx-pwm.txt   | 17 --------
>   .../bindings/pwm/nxp,lpc3220-pwm.yaml         | 41 +++++++++++++++++++
>   2 files changed, 41 insertions(+), 17 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
>   create mode 100644 Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> deleted file mode 100644
> index 74b5bc5dd19ac..0000000000000
> --- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -LPC32XX PWM controller
> -
> -Required properties:
> -- compatible: should be "nxp,lpc3220-pwm"
> -- reg: physical base address and length of the controller's registers
> -
> -Examples:
> -
> -pwm@4005c000 {
> -	compatible = "nxp,lpc3220-pwm";
> -	reg = <0x4005c000 0x4>;
> -};
> -
> -pwm@4005c004 {
> -	compatible = "nxp,lpc3220-pwm";
> -	reg = <0x4005c004 0x4>;
> -};
> diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> new file mode 100644
> index 0000000000000..b82d52f583df8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/nxp,lpc3220-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC32XX PWM controller
> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,lpc3220-pwm
> +      - nxp,lpc3220-motor-pwm
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#pwm-cells':
> +    const: 3
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#pwm-cells'
> +
> +allOf:
> +  - $ref: pwm.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pwm@4005c000 {
> +        compatible = "nxp,lpc3220-pwm";
> +        reg = <0x4005c000 0x4>;
> +        #pwm-cells = <3>;
> +    };
> +

"clocks" and "assigned-clock-parents" properties are required.

Please fix the old .txt scheme, or the new one.

I will have to NAK any converted yaml file, if there is a clear
difference between the actual and proper description of controllers
from lpc32xx.dtsi and new proposed schemes.

-- 
Best wishes,
Vladimir


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] dt-bindings: pwm: convert lpc32xx-pwm.txt to yaml format
  2025-06-25  0:37 ` Vladimir Zapolskiy
@ 2025-06-25  4:04   ` Frank Li
  0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-06-25  4:04 UTC (permalink / raw)
  To: Vladimir Zapolskiy
  Cc: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Piotr Wojtaszczyk, open list:PWM SUBSYSTEM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/LPC32XX SOC SUPPORT, open list, imx

On Wed, Jun 25, 2025 at 03:37:49AM +0300, Vladimir Zapolskiy wrote:
> On 6/24/25 23:09, Frank Li wrote:
> > Convert pc32xx-pwm.txt to yaml format.
> >
> > Additional changes:
> > - add ref to pwm.yaml
> > - restrict #pwm-cells to 3
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >   .../devicetree/bindings/pwm/lpc32xx-pwm.txt   | 17 --------
> >   .../bindings/pwm/nxp,lpc3220-pwm.yaml         | 41 +++++++++++++++++++
> >   2 files changed, 41 insertions(+), 17 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> >   create mode 100644 Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> > deleted file mode 100644
> > index 74b5bc5dd19ac..0000000000000
> > --- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> > +++ /dev/null
> > @@ -1,17 +0,0 @@
> > -LPC32XX PWM controller
> > -
> > -Required properties:
> > -- compatible: should be "nxp,lpc3220-pwm"
> > -- reg: physical base address and length of the controller's registers
> > -
> > -Examples:
> > -
> > -pwm@4005c000 {
> > -	compatible = "nxp,lpc3220-pwm";
> > -	reg = <0x4005c000 0x4>;
> > -};
> > -
> > -pwm@4005c004 {
> > -	compatible = "nxp,lpc3220-pwm";
> > -	reg = <0x4005c004 0x4>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> > new file mode 100644
> > index 0000000000000..b82d52f583df8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/nxp,lpc3220-pwm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NXP LPC32XX PWM controller
> > +
> > +maintainers:
> > +  - Frank Li <Frank.Li@nxp.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nxp,lpc3220-pwm
> > +      - nxp,lpc3220-motor-pwm
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#pwm-cells':
> > +    const: 3
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - '#pwm-cells'
> > +
> > +allOf:
> > +  - $ref: pwm.yaml#
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    pwm@4005c000 {
> > +        compatible = "nxp,lpc3220-pwm";
> > +        reg = <0x4005c000 0x4>;
> > +        #pwm-cells = <3>;
> > +    };
> > +
>
> "clocks" and "assigned-clock-parents" properties are required.
>
> Please fix the old .txt scheme, or the new one.
>
> I will have to NAK any converted yaml file, if there is a clear
> difference between the actual and proper description of controllers
> from lpc32xx.dtsi and new proposed schemes.

Sorry, I missed squash local patch. In my local branch, lpc dtb check
warning already reduce to 0.

Frank
>
> --
> Best wishes,
> Vladimir


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-25  4:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 20:09 [PATCH 1/1] dt-bindings: pwm: convert lpc32xx-pwm.txt to yaml format Frank Li
2025-06-25  0:37 ` Vladimir Zapolskiy
2025-06-25  4:04   ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).