From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591FAC433F5 for ; Wed, 20 Oct 2021 09:09:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 282E561361 for ; Wed, 20 Oct 2021 09:09:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 282E561361 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=qIj0KNj5pJkn64GVS1Bc8f1j3XpdJME30qlh5xhHfZk=; b=Xka/8ZcYTMEjKCNsiNDLgzgSbU guEawqHm9G0HfTzWEsZnjf/30LBtjErtn24jvJf3S/XxDj7yyAXMjYYre4kvtQ6dMYDgqvIb5tiK1 EjXXnFys5wc1gTIUzhXHRStcT9bccTOh5xzfJ4Mrm/Dp729QtM0rS/ZpEJDc5S/rVRwgssuF9HYYb mwBlG2fSZ47q3uk6YcOXgApCtPgcG1vIg3dn4N5jvKDiUVWdhR8dG1Tx84w74bOCAqDlc2FFN/vpS pO5jw5W3XYhB7y2KoOLz+7/e7F3VXV6w7bszHTblf7UOmT04yh0fvz50XS3BFdHeNaU6zn9mvKQvK q2TYDuEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md7Zp-003wMU-Jy; Wed, 20 Oct 2021 09:08:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md7Zl-003wKs-6n for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 09:07:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 117F2ED1; Wed, 20 Oct 2021 02:07:54 -0700 (PDT) Received: from [10.57.74.74] (unknown [10.57.74.74]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B83A23F70D; Wed, 20 Oct 2021 02:07:51 -0700 (PDT) Subject: Re: [PATCH v2 4/4] arm64: vdso32: require CROSS_COMPILE_COMPAT for gcc+bfd To: Nick Desaulniers , Catalin Marinas , Will Deacon Cc: llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nathan Chancellor References: <20211019223646.1146945-1-ndesaulniers@google.com> <20211019223646.1146945-5-ndesaulniers@google.com> From: Vincenzo Frascino Message-ID: <94eccd0b-ea36-25af-8140-fa6209a0b222@arm.com> Date: Wed, 20 Oct 2021 11:08:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211019223646.1146945-5-ndesaulniers@google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_020757_389481_8F97BF26 X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/20/21 12:36 AM, Nick Desaulniers wrote: > Similar to > commit 231ad7f409f1 ("Makefile: infer --target from ARCH for CC=clang") > There really is no point in setting --target based on > $CROSS_COMPILE_COMPAT for clang when the integrated assembler is being > used, since > commit ef94340583ee ("arm64: vdso32: drop -no-integrated-as flag"). > > Allows COMPAT_VDSO to be selected without setting $CROSS_COMPILE_COMPAT > when using clang and lld together. > > Before: > $ ARCH=arm64 CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make -j72 LLVM=1 defconfig > $ grep CONFIG_COMPAT_VDSO .config > CONFIG_COMPAT_VDSO=y > $ ARCH=arm64 make -j72 LLVM=1 defconfig > $ grep CONFIG_COMPAT_VDSO .config > $ > > After: > $ ARCH=arm64 CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make -j72 LLVM=1 defconfig > $ grep CONFIG_COMPAT_VDSO .config > CONFIG_COMPAT_VDSO=y > $ ARCH=arm64 make -j72 LLVM=1 defconfig > $ grep CONFIG_COMPAT_VDSO .config > CONFIG_COMPAT_VDSO=y > > Reviewed-by: Nathan Chancellor > Suggested-by: Nathan Chancellor > Tested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Reviewed-by: Vincenzo Frascino > --- > Changes v1 -> v2: > * Cite ef94340583ee as per Nathan. > * Add parens to Kconfig expression as per Nathan. > * Pick up Nathan's RB, TB, and SB tags. > > arch/arm64/Kconfig | 3 ++- > arch/arm64/kernel/vdso32/Makefile | 17 +++++------------ > 2 files changed, 7 insertions(+), 13 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5c7ae4c3954b..f0f2c95aa4c8 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1264,7 +1264,8 @@ config KUSER_HELPERS > > config COMPAT_VDSO > bool "Enable vDSO for 32-bit applications" > - depends on !CPU_BIG_ENDIAN && "$(CROSS_COMPILE_COMPAT)" != "" > + depends on !CPU_BIG_ENDIAN > + depends on (CC_IS_CLANG && LD_IS_LLD) || "$(CROSS_COMPILE_COMPAT)" != "" > select GENERIC_COMPAT_VDSO > default y > help > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index e478cebb9891..c8fec493a450 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -10,18 +10,15 @@ include $(srctree)/lib/vdso/Makefile > > # Same as cc-*option, but using CC_COMPAT instead of CC > ifeq ($(CONFIG_CC_IS_CLANG), y) > -CC_COMPAT_CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > - > CC_COMPAT ?= $(CC) > -CC_COMPAT += $(CC_COMPAT_CLANG_FLAGS) > - > -ifneq ($(LLVM),) > -LD_COMPAT ?= $(LD) > +CC_COMPAT += --target=arm-linux-gnueabi > else > -LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld > +CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc > endif > + > +ifeq ($(CONFIG_LD_IS_LLD), y) > +LD_COMPAT ?= $(LD) > else > -CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc > LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld > endif > > @@ -45,10 +42,6 @@ VDSO_CPPFLAGS += $(LINUXINCLUDE) > # Common C and assembly flags > # From top-level Makefile > VDSO_CAFLAGS := $(VDSO_CPPFLAGS) > -ifneq ($(shell $(CC_COMPAT) --version 2>&1 | head -n 1 | grep clang),) > -VDSO_CAFLAGS += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > -endif > - > VDSO_CAFLAGS += $(call cc32-option,-fno-PIE) > ifdef CONFIG_DEBUG_INFO > VDSO_CAFLAGS += -g > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel