From mboxrd@z Thu Jan 1 00:00:00 1970 From: andre.przywara@arm.com (Andre Przywara) Date: Thu, 24 Nov 2016 11:09:21 +0000 Subject: [RFC PATCH 3/5] arm64: defconfig: sunxi: include options for Allwinner H5 SoC In-Reply-To: References: <1479950235-26821-1-git-send-email-andre.przywara@arm.com> <1479950235-26821-4-git-send-email-andre.przywara@arm.com> <20161124105725.va6gf6b3min74occ@lukather> Message-ID: <94faa7a4-1ccd-48b6-4983-53b9307c8c3f@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 24/11/16 11:01, Chen-Yu Tsai wrote: > On Thu, Nov 24, 2016 at 6:57 PM, Maxime Ripard > wrote: >> On Thu, Nov 24, 2016 at 01:17:13AM +0000, Andre Przywara wrote: >>> The Allwinner H5 SoC is closely related to the H3 SoC, so select the >>> basic pinctrl driver and the DMA driver to let a defconfig kernel boot >>> on those boards. >>> >>> Signed-off-by: Andre Przywara >>> --- >>> arch/arm64/Kconfig.platforms | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >>> index cfbdf02..8300677 100644 >>> --- a/arch/arm64/Kconfig.platforms >>> +++ b/arch/arm64/Kconfig.platforms >>> @@ -5,8 +5,12 @@ config ARCH_SUNXI >>> select GENERIC_IRQ_CHIP >>> select PINCTRL >>> select PINCTRL_SUN50I_A64 >>> + select PINCTRL_SUN8I_H3 >>> + select PINCTRL_SUN8I_H3_R >>> + select DMA_SUN6I >> >> I'm not sure I want to get an ever growing select which will be an >> union of all the drivers that all the arm64 Allwinner SoCs will >> require. >> >> Select leaves no option to disable that option, and we have defconfig >> to deal with that nicely. > I have to agree. We should only select things that aren't selectable > by the user. In our case, that's only the pinctrl drivers. Right, I missed that. > We should use default y (ARCH_SUNXI && ARM64) for every driver that > has a prompt entry in Kconfig. Sounds like a plan. I will look into this. Thanks, Andre.