From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 720D5C2BBCA for ; Tue, 25 Jun 2024 13:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jkZYWGYTrKGJQ8T76iipeSpIDVN0DUpXS3dgwpp9ztQ=; b=YLikngAEljPMluPf36FU6iXIIU 4abK3fJe/fnmrWG9hEABX/o4qMVcFu36FTQUrnpFLRO7g4yKN36lz2ICpzVZPbSNi1mAaCp0x5/Tj q+04IvyAByoa2LsBkm4TxUeu2jJbzEaKCcT0n3PTRBouOkObQBbqGLnbt8xzaWsYdOzK9E4X3+SGW rLS/dRzk3mXJWsS74Nle/21FxvfwwgJdWhuKM9AzbjV7Bsh4M815QdXmtsHlTrmXM6RYPXOsAoMdj zzq0hyFwL6D0NMSHWPJXBUexRd2nMb3DlXWBcStlmA1gP1KsFHZuUmRg05n8wbrw/JoqmOPmnzMqL G8z6UJ+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM5vg-00000002un5-0oZE; Tue, 25 Jun 2024 13:09:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM5vb-00000002umN-1AR7 for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 13:09:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7F0A060B3E; Tue, 25 Jun 2024 13:09:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C7BEC32781; Tue, 25 Jun 2024 13:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719320982; bh=v0RrGnLJx96prKt+gVIo7mfb5YkYNM0TlmCRr2Ajoag=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QD8ZQ7NFU9d2hK4o1vb9mt2wQ/fpgjkrBHTBm69mj3jPOwaAgTPSBF/Q640zSrv5v I2D8M/3o/R0umwh6RGK4vpi0AvO90fZgCDvGC9To4SLkJXpDNd7SXpVHTlLG4lMoXx AmttHbtmFNOMoZurji7AOEgYaqggSeSggCFzk1hJeQm668lV/R/5k5F2r5O8BCjrlL OWMcpdYfn6kn/vNMFLGRyzcdQ4CfCsofuU2LssYm3BBJ5n7CW3KRvg+Zi3M3oXpU9S dZrVEGKEr5aRHniKepmCKwhTk8FpNqOcrhjzucqUHwjChHsOSbh9dkePuQOgdMOrYL JM8Rk9yLBNjYQ== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sM5vY-0079jB-Bo; Tue, 25 Jun 2024 14:09:40 +0100 MIME-Version: 1.0 Date: Tue, 25 Jun 2024 14:09:40 +0100 From: Marc Zyngier To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Cc: James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Joey Gouly Subject: Re: [PATCH 4/4] KVM: arm64: Honor trap routing for TCR2_EL1 In-Reply-To: <20240625130042.259175-5-maz@kernel.org> References: <20240625130042.259175-1-maz@kernel.org> <20240625130042.259175-5-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.15 Message-ID: <95089bc5144ead3a4f195dbff159491f@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, joey.gouly@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_060943_421209_A0E8075A X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-06-25 14:00, Marc Zyngier wrote: > TCR2_EL1 handling is missing the handling of its trap configuration: > > - HCRX_EL2.TCR2En must be handled in conjunction with > HCR_EL2.{TVM,TRVM} > > - HFG{R,W}TR_EL2.TCR_EL1 does apply to TCR2_EL1 as well > > Without these two controls being implemented, it is impossible to > correctly route TCR2_EL1 traps. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/emulate-nested.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) Gahh, stale staging directory, please ignore this patch (5/5 is the same). M. -- Jazz is not dead. It just smells funny...