From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"maz@kernel.org" <maz@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
Date: Fri, 1 Apr 2022 11:32:21 +0200 [thread overview]
Message-ID: <951173dd-0d39-017c-322e-b38f693a8848@linaro.org> (raw)
In-Reply-To: <eae0d1c49fcd4b41b700e8fd86af1b3e@cqplus1.com>
On 01/04/2022 11:19, qinjian[覃健] wrote:
>>> diff --git a/include/dt-bindings/clock/sp-sp7021.h b/include/dt-bindings/clock/sp-sp7021.h
>>> new file mode 100644
>>> index 000000000..45dac6de8
>>> --- /dev/null
>>> +++ b/include/dt-bindings/clock/sp-sp7021.h
>>> @@ -0,0 +1,112 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>> +/*
>>> + * Copyright (C) Sunplus Technology Co., Ltd.
>>> + * All rights reserved.
>>> + */
>>> +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
>>> +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
>>> +
>>> +#define XTAL 27000000
>>> +
>>> +/* plls */
>>> +#define PLL_A 0
>>> +#define PLL_E 1
>>> +#define PLL_E_2P5 2
>>> +#define PLL_E_25 3
>>> +#define PLL_E_112P5 4
>>> +#define PLL_F 5
>>> +#define PLL_TV 6
>>> +#define PLL_TV_A 7
>>> +#define PLL_SYS 8
>>> +
>>> +/* gates: mo_clken0 ~ mo_clken9 */
>>> +#define CLK_SYSTEM 0x10
>>> +#define CLK_RTC 0x12
>>
>> YAML looks ok, but here comment from Arnd also applies. These should be
>> regular decimal numbers incremented by one.
>>
>> Best regards,
>> Krzysztof
>
> Yes, same as reset driver, these defines also mapping the hardware.
> But different from reset driver, clk driver also used these defines.
> If I removed this defines, I must write the proper hardware number twice in dt & driver.
> It's meaningless & hard to check.
Not really... just follow what most (or all) clock drivers are doing -
incremental IDs.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-01 9:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 8:29 [PATCH v12 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-03-31 8:29 ` [PATCH v12 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-03-31 8:29 ` [PATCH v12 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-03-31 8:58 ` Arnd Bergmann
2022-04-01 8:24 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 3/9] reset: Add Sunplus " Qin Jian
2022-03-31 8:59 ` Arnd Bergmann
2022-03-31 8:29 ` [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-03-31 20:21 ` Krzysztof Kozlowski
2022-04-01 9:19 ` qinjian[覃健]
2022-04-01 9:32 ` Krzysztof Kozlowski [this message]
2022-03-31 8:29 ` [PATCH v12 5/9] clk: Add Sunplus " Qin Jian
2022-03-31 9:22 ` Arnd Bergmann
2022-04-01 9:47 ` qinjian[覃健]
2022-04-01 10:09 ` Arnd Bergmann
2022-04-02 3:37 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-03-31 20:44 ` Rob Herring
2022-04-01 2:29 ` qinjian[覃健]
2022-04-01 17:53 ` Rob Herring
2022-04-02 2:43 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-03-31 9:17 ` Arnd Bergmann
2022-04-01 7:17 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-03-31 9:03 ` Arnd Bergmann
2022-03-31 8:29 ` [PATCH v12 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-03-31 9:09 ` Arnd Bergmann
2022-04-01 7:08 ` qinjian[覃健]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=951173dd-0d39-017c-322e-b38f693a8848@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).