From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4100E6FE4B for ; Fri, 6 Sep 2024 23:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject: References:In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KAS/Rwnc7T0eZM71tzNaAc3sWj4LOqmY83CNc7otz+k=; b=Wq/SKgSVUT3WysJu/x8AYe0JEs YI/f8RYB5G4JApaw3gTFj1ADsVm7OUoyXBauuoRt+CFoiH3/RrMo6VOC5gPHPGKt2Z1y1nGjHNMAd tS6rphsFehM8FrjqN2hkCzY37ZjydwyBz7uAchrIgs0ViH9AF6oGHBzPusimoZo2NOYbgWo/I2Bzp cdT71H2MxH9BWN93925lVH0dQeokkbCOHDpdwGOOAu0uhWacRss4THGdrmMHYTR+cIPpjkqOxpRc+ 0IixQ+Vsxf/XsI8QzJo9NCX+PvSUo8LaanmItMU/oW2P7uvc7E6FeQDXju3mh5lXEf9ZLmZdn/I+r cA6sI9zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smhxu-0000000DpDI-0i5u; Fri, 06 Sep 2024 23:02:06 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smhwt-0000000Dp72-3hRO for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2024 23:01:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9A846A41085; Fri, 6 Sep 2024 23:00:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DA8FC4CEC4; Fri, 6 Sep 2024 23:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725663662; bh=KAS/Rwnc7T0eZM71tzNaAc3sWj4LOqmY83CNc7otz+k=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=V9JGbMWoTcRD+R7JyDvalu0KM0ftwD1NewkIvjjoXLdwmSTIv4ql+UD7IusXhbXw3 C4Awf5d0kXFiXSFVoQIP/Ozn+dVnMI9XZAuMFRumtmsoJZD4C8cbbDrN/nom748O+U t9vNhe4N+QvEgPVi1cpvkmSSriqlPpZ3za/vquA22K/5IDlT3UCBBJ7QtAIHPErkMH pErs/lY+Fppj2KJsSQqW2rBQQ9dkd22FY9D56Nn5PbmU7KErcCNaVLkjtN/ZJblDqd yQgnoN6M9fYmYho+njxn3tlDKKWtoK2NC7lvwYqFUBRaOSGdBuyxarHuK2mtIInTSC VLHPd17TElaHg== Message-ID: <951b5c09c3ca2de3f0a28a078084f7dd.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20240830130218.3377060-1-claudiu.beznea.uj@bp.renesas.com> <20240830130218.3377060-8-claudiu.beznea.uj@bp.renesas.com> <83fac884d749bda0cf0b346e4e869bc8.sboyd@kernel.org> Subject: Re: [PATCH v3 07/12] arm64: dts: renesas: r9a08g045: Add VBATTB node From: Stephen Boyd Cc: alexandre.belloni@bootlin.com, claudiu beznea , conor+dt@kernel.org, krzk+dt@kernel.org, magnus.damm@gmail.com, mturquette@baylibre.com, p.zabel@pengutronix.de, robh@kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea To: Geert Uytterhoeven Date: Fri, 06 Sep 2024 16:01:00 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240906_160104_010067_A0BB60C7 X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Geert Uytterhoeven (2024-09-06 00:28:38) > Hi Stephen, >=20 > On Thu, Sep 5, 2024 at 8:09=E2=80=AFPM Stephen Boyd wr= ote: > > Quoting claudiu beznea (2024-09-04 05:17:30) > > > On 03.09.2024 22:48, Stephen Boyd wrote: > > > > The node name should be something like clock- but if the > > > > frequency is different per-board then I don't know what should happ= en > > > > here. > > > > > > The frequency should be always around 32768 Hz but not necessarily ex= actly > > > 32768 Hz. It depends on what is installed on the board, indeed. RTC c= an do > > > time error adjustments based on the variations around 32768 Hz. > > > > > > > Can you leave the vbattb_xtal phandle up above and then require > > > > the node to be defined in the board with the proper frequency after= the > > > > dash? > > > > > > Is it OK for you something like this (applied on top of this series)? > > > > Yes, it's too bad we can't append to a property in DT, or somehow leave > > alone certain cells and only modify one of them. >=20 > My main objections are that (1) this approach is different than the one u= sed > for all other external clock inputs on Renesas SoCs, and (2) this requires > duplicating part of the clocks property in all board DTS files. >=20 Can 'clock-ranges' be used here? Leave the cell as null in the SoC dtsi file and then fill it in with clocks property at the parent node. I think you'd have to use clock-names for this though.