From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10CC5C43381 for ; Fri, 1 Mar 2019 18:17:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8B4A20840 for ; Fri, 1 Mar 2019 18:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gX2S9PS5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8B4A20840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xu4DA6X7gXYokexmquf7ion1tsjXRc9aTdeeo0dtsGM=; b=gX2S9PS5bs6vSJ FatFUA0T+HvQmG4cPrdxg1SBBTGNmhgOB4EZJhsDcrPZ3rzS12DluJL+/XdcS4aIghuvv5Ax+smMi ELzv881+Y6yTf2xw3fY9ZH6SHiYGH6hDA3cEv9SOHEDI5DLcNUTg6GbrPHBblMKXBc2jwrvLVeYdu t8eu9JN9SB71b8IcDJEjVRZp9LpCLskgCS08hVkaXMXVbtFuW4LnbiifO+ffTsebNK8pFTX9J+f8C CsZyVIiSCFk5/whMbZ80UO8CgQiZ441sP2vMzgb83yZHVt+5IO0MFn/twT6+29YDiqCNonDp6FM5t 9BPAT7MR3A5Xptd1AZcQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzmjL-0004EK-7G; Fri, 01 Mar 2019 18:17:55 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzmjH-0004DV-Ru; Fri, 01 Mar 2019 18:17:53 +0000 Received: from p57b77bb0.dip0.t-ipconnect.de ([87.183.123.176] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gzmis-0005RF-Gk; Fri, 01 Mar 2019 19:17:26 +0100 From: Heiko Stuebner To: Christoph Muellner Subject: Re: [PATCH 1/3] dt-bindings: mmc: Add DTS property to disable DCMDs on Arasan controllers Date: Fri, 01 Mar 2019 19:17:25 +0100 Message-ID: <9535423.1mel94qINy@phil> In-Reply-To: <20190301164349.60589-1-christoph.muellner@theobroma-systems.com> References: <20190301164349.60589-1-christoph.muellner@theobroma-systems.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_101752_058889_5E809791 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, ulf.hansson@linaro.org, Viresh Kumar , shawn.lin@rock-chips.com, adrian.hunter@intel.com, Tony Xie , Klaus Goger , Philipp Tomsich , Michal Simek , linux-rockchip@lists.infradead.org, Shunqian Zheng , devicetree@vger.kernel.org, Randy Li , Jeffy Chen , Vicente Bergas , robh+dt@kernel.org, Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 1. M=E4rz 2019, 17:43:45 CET schrieb Christoph Muellner: > Direct commands (DCMDs) are an optional feature of eMMC 5.1's command > queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, > which exposes a control register bit to enable the feature. > The current implementation sets this bit unconditionally. > = > This patch allows to surpress the feature activation, > by specifying the property disable-cqe-dcmd. > = > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich Patch subject is needs improvement :-) . I did scratch my head a lot regarding "where is the code change" until I actually looked into the patch itself, so you probably want mmc: sdhci-of-arasan: Add DTS property to disable DCMDs or similar instead of "dt-bindings: ..." here to match the subsystem. Heiko > --- > drivers/mmc/host/sdhci-of-arasan.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > = > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-= of-arasan.c > index c9e3e050ccc8..88dc3f00a5be 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device= *pdev) > host->mmc_host_ops.start_signal_voltage_switch =3D > sdhci_arasan_voltage_switch; > sdhci_arasan->has_cqe =3D true; > - host->mmc->caps2 |=3D MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; > + host->mmc->caps2 |=3D MMC_CAP2_CQE; > + > + if (!of_property_read_bool(np, "disable-cqe-dcmd")) > + host->mmc->caps2 |=3D MMC_CAP2_CQE_DCMD; > } > = > ret =3D sdhci_arasan_add_host(sdhci_arasan); > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel