From: <Claudiu.Beznea@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <lars@metafoo.de>,
<perex@perex.cz>, <tiwai@suse.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding
Date: Thu, 16 Feb 2023 10:15:43 +0000 [thread overview]
Message-ID: <954cdf90-c41a-4e21-31e0-88a0baf26065@microchip.com> (raw)
In-Reply-To: <485d74fe-bfb5-c55e-724f-304476624abd@linaro.org>
On 16.02.2023 12:04, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 14/02/2023 17:14, Claudiu Beznea wrote:
>> Add microchip,startup-delay-us binding to let PDMC users to specify
>> startup delay.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> .../devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
>> index c4cf1e5ab84b..9b40268537cb 100644
>> --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
>> +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
>> @@ -67,6 +67,12 @@ properties:
>> maxItems: 4
>> uniqueItems: true
>>
>> + microchip,startup-delay-us:
>> + description: |
>> + Specifies the delay in microseconds that needs to be applied after
>> + enabling the PDMC microphones to avoid unwanted noise due to microphones
>> + not being ready.
>
> Is this some hardware delay? Or OS? If OS, why Linux specific delay is
> put into DT?
It's the delay used in software workaround that IP needs to filter noises.
The IP is not fully featured to do this kind of filtering on its own thus
this software workaround. This delay may depend on used microphones thus
for different kind of setups (PDMC + different microphones) I introduced
this in DT.
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-16 10:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 16:14 [PATCH 0/3] ASoC: mchp-pdmc: fix poc noises when starting capture Claudiu Beznea
2023-02-14 16:14 ` [PATCH 1/3] ASoC: soc-generic-dmaengine-pcm: add option to start DMA after DAI Claudiu Beznea
2023-02-14 18:14 ` Lars-Peter Clausen
2023-02-14 21:26 ` Mark Brown
2023-02-16 9:49 ` Claudiu.Beznea
2023-02-16 13:53 ` Lars-Peter Clausen
2023-02-17 10:59 ` Claudiu.Beznea
2023-02-14 16:14 ` [PATCH 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding Claudiu Beznea
2023-02-16 10:04 ` Krzysztof Kozlowski
2023-02-16 10:15 ` Claudiu.Beznea [this message]
2023-02-16 10:18 ` Krzysztof Kozlowski
2023-02-16 10:41 ` Claudiu.Beznea
2023-02-16 10:43 ` Krzysztof Kozlowski
2023-02-16 14:46 ` Mark Brown
2023-02-14 16:14 ` [PATCH 3/3] ASoC: mchp-pdmc: fix poc noise at capture startup Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=954cdf90-c41a-4e21-31e0-88a0baf26065@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox