From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F2A8EB64DD for ; Tue, 11 Jul 2023 14:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gFMsHuqUoW2A+ohCFwiXb9Nr5DAv1QirB+QWNQyxLRE=; b=NjSVP4emLeAxXv jBrwEnFjdAJA+CbObBs42UTlIYki194/gOe8dk6ilbeMszgVo23iVUoUqJDf88xhGi8yLXTGBtylo buCvtVQy79h0KYHPE+YbPISXW3jnRCq9ttJO3+U73LFfyq+5CXuuuaSgITT2QSIRi31nYXH83xfh3 ItGH8Qm4qsmNJtgef0EcSRcMVbnifJQo+79hUtvNEmaNLFyk8YieZYdQ+5sarn/X1WZdiRFaDdgj/ Iogm2EA0sN0aGbUYsZYuo/fVYQGgJabhcpI5XkV3pStzvccwAC1UQx0zhh3S9pUe6emK7w+Zusg7a LcOJufJ+XGevp5PtXDpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJDzO-00F42e-0a; Tue, 11 Jul 2023 14:05:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJDzK-00F408-1B for linux-arm-kernel@lists.infradead.org; Tue, 11 Jul 2023 14:05:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6D381FB; Tue, 11 Jul 2023 07:05:45 -0700 (PDT) Received: from [10.57.30.34] (unknown [10.57.30.34]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5C733F740; Tue, 11 Jul 2023 07:05:00 -0700 (PDT) Message-ID: <95506174-546c-9bf7-82af-09058550be6d@arm.com> Date: Tue, 11 Jul 2023 15:04:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 3/4] arm_pmu: Remove unused PERF_PMU_CAP_HETEROGENEOUS_CPUS capability Content-Language: en-US To: Anshuman Khandual Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Will Deacon , Kan Liang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, irogers@google.com References: <20230710122138.1450930-1-james.clark@arm.com> <20230710122138.1450930-4-james.clark@arm.com> <86792ab2-864a-5c27-95c1-54c4057024db@arm.com> From: James Clark In-Reply-To: <86792ab2-864a-5c27-95c1-54c4057024db@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230711_070510_478914_A130F51A X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/07/2023 13:08, Anshuman Khandual wrote: > > > On 7/10/23 17:51, James Clark wrote: >> Since commit bd2756811766 ("perf: Rewrite core context handling") the >> relationship between perf_event_context and PMUs has changed so that >> the error scenario that PERF_PMU_CAP_HETEROGENEOUS_CPUS originally >> silenced no longer exists. >> >> Remove the capability and associated comment to avoid confusion that it >> actually influences any perf core behavior. This change should be a >> no-op. >> >> Signed-off-by: James Clark >> --- >> drivers/perf/arm_pmu.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c >> index d8844a9461a2..297906df6628 100644 >> --- a/drivers/perf/arm_pmu.c >> +++ b/drivers/perf/arm_pmu.c >> @@ -872,15 +872,12 @@ struct arm_pmu *armpmu_alloc(void) >> .attr_groups = pmu->attr_groups, >> /* >> * This is a CPU PMU potentially in a heterogeneous >> - * configuration (e.g. big.LITTLE). This is not an uncore PMU, >> - * and we have taken ctx sharing into account (e.g. with our >> - * pmu::filter callback and pmu::event_init group validation). >> - * >> + * configuration (e.g. big.LITTLE) so >> * PERF_PMU_CAP_EXTENDED_HW_TYPE is required to open the legacy >> * PERF_TYPE_HARDWARE and PERF_TYPE_HW_CACHE events on a >> * specific PMU. >> */ >> - .capabilities = PERF_PMU_CAP_HETEROGENEOUS_CPUS | PERF_PMU_CAP_EXTENDED_REGS | >> + .capabilities = PERF_PMU_CAP_EXTENDED_REGS | >> PERF_PMU_CAP_EXTENDED_HW_TYPE, > > Small nit, the second line could be folded back into the first one. .clang-format has a column limit of 80 which is why it gets folded. The kernel coding style guide also still says 80 is a strongly preferred limit so I'll probably leave it. > >> }; >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel