From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F68C433E3 for ; Mon, 20 Jul 2020 12:08:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E8F62176B for ; Mon, 20 Jul 2020 12:08:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yIvlnDb9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="eT8ph3Gf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E8F62176B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=41GdMAueNsT2IPxqUc2VXa00eNgfO5tmsxceqGMz0Z8=; b=yIvlnDb98GOcP9ooZB770E/LM 1pOQTnmcSdc8G04TKUrbM81wc2XOk+/MfFrU+9euwfARdBgTgfWx0GZzJ8XD1dY0XeLNovxBrDj3U 6agNn2ebm91qa0JeE7U5tegR6/KkXxyhLrL2bluLOqNB5N2uvKjAPlLRat8zWzOqKCld8cwsGtmBX 6V/4emHlWmIlk97xxtQfxJl2e05osmLJuPHi6LIju1bSFR6KBIzpgJni0g+5jjvw53eKLxKbNKjMK tZ/NDb9z3pIy11UkSn1s/yzfIc83iY2o4gQqf/CR8VRiVInzJoFsa6HCr3fUCs7AmAKNqU8KxRKnr UNb4rrGGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxUZb-0007Va-PX; Mon, 20 Jul 2020 12:07:11 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxUZY-0007Uo-PI for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 12:07:09 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06KC74kU075321; Mon, 20 Jul 2020 07:07:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1595246824; bh=aj1lP0WZkkMDqqRJkTAmBFSAqvwrbFH5xh9UNbjJztU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=eT8ph3GfR3hfkfZT/7C7F7eo0fkPxyj2yM9xX7MH8byXRnwwh5U23XN/8Rcwbc1GQ eStItNoISCEBVyoayZ3pq9FZ8h+imd5dTaP3iKXmiL68jHKY1nyieY0K4mGmU2Dt5b uOrb517DHFe+RNyLitdud984xaIMjz+IoI9DQuL4= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06KC74Zi071107; Mon, 20 Jul 2020 07:07:04 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 20 Jul 2020 07:07:03 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 20 Jul 2020 07:07:03 -0500 Received: from [10.250.32.229] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06KC73tp015469; Mon, 20 Jul 2020 07:07:03 -0500 Subject: Re: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition To: Pavel Machek References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-2-dmurphy@ti.com> <20200720095409.GA13137@amd> From: Dan Murphy Message-ID: <95708f01-0db6-ed25-e087-2d95f28fe509@ti.com> Date: Mon, 20 Jul 2020 07:07:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200720095409.GA13137@amd> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_080708_973975_4A0D4296 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Pavel On 7/20/20 4:54 AM, Pavel Machek wrote: > Hi! > >> Introduce a multicolor class that groups colored LEDs >> within a LED node. >> >> The multicolor class groups monochrome LEDs and allows controlling two >> aspects of the final combined color: hue and lightness. The former is >> controlled via the intensity file and the latter is controlled >> via brightness file. >> >> Acked-by: Jacek Anaszewski >> Signed-off-by: Dan Murphy > Thanks, applied and pushed out. Thank you. What about the patches for the users? >> +==================================== >> +MultiColor LED handling under Linux >> +==================================== > ... >> +Multicolor Class Control >> +======================== > AFAICT The first one should be "Multicolor" for consistency. > >> +config LEDS_CLASS_MULTICOLOR >> + tristate "LED MultiColor Class Support" > Here too. > > Can you send a followup patch to fix it up? Will send a patch to fix it up but not sure if I should send as part of this series or separately? Because I am not sure if you are going to apply the remaining patches up to the DTs Dan > Best regards, > Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel