From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58355C47073 for ; Fri, 5 Jan 2024 02:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lu4RK5arbyl/H6ozDXv1GVQJRnAnKzkTxecdYeBkfsA=; b=k7MK4ep9/ZOEtL DNh9NvRYLnL3DNqt3snhgdAH9yg70UW7nhEY2neutgS9cvowvAp7iPx0jz1EoxexhYIMaUwTz2Mi6 aB5WbmPkXuYfjSGKrlISNM21nryFA1eCaZs+pLmTDjr2PDhr22HFpgEqTMEawdLcW792D2MY9m0aE SD8nR68tWPOKLYhDiv7Lg9Q0UYH6u/L3eDJoMprw+CivaWs40tDZf2HkIwej6N7DAVIc4oPA2uUWj 3KpGvoRpAIqKv0Qlvu5Tu6fM13e4Rz3OtUYDhdWRovTYhHfuMEBBEKmfO/LR1Cg94vVFs6NN9K6eh vfP3OioxD1vB6pDMm8qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLZu8-00FmM8-2A; Fri, 05 Jan 2024 02:25:48 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLZu5-00FmLo-17 for linux-arm-kernel@lists.infradead.org; Fri, 05 Jan 2024 02:25:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9Fm13D6HkTMzEZBlOarDnIVaiSDDHq61aKHqbRpbK1E=; b=o4GsTItlbg+grt7he924K/ku2I 5+z0tWqqFd2nbLjRcJ8orIs0aKlySKR+eL+k4wUwmoF4/O5x2EniSQ2Qga17JV0zNUmjgPDIaH1Ee s0V1ZkV/FPJ+h0CtIu6Pel8NQDLjdCDPNaPuqRdEaDINZtPui0O9ZNztJI6M/ncFOrcE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rLZtq-004Pl0-14; Fri, 05 Jan 2024 03:25:30 +0100 Date: Fri, 5 Jan 2024 03:25:30 +0100 From: Andrew Lunn To: Christian Marangi Cc: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , Jacek Anaszewski , =?iso-8859-1?Q?Fern=E1ndez?= Rojas , Sven Schwermer , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [net-next PATCH v8 3/5] net: phy: add support for PHY LEDs polarity modes Message-ID: <957df01b-bb92-4f8a-9f2b-aacd3de1208d@lunn.ch> References: <20240104110114.2020-1-ansuelsmth@gmail.com> <20240104110114.2020-4-ansuelsmth@gmail.com> <47f18def-d34f-4224-9de2-6e0ae7122a52@lunn.ch> <6597286c.050a0220.4684a.182e@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6597286c.050a0220.4684a.182e@mx.google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_182545_385934_B07A78A5 X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > + * @dev: PHY device which has the LED > > > + * @index: Which LED of the PHY device or -1 > > > + * @modes: bitmap of LED polarity modes > > > + * > > > + * Configure LED with all the required polarity modes in @modes > > > + * to make it correctly turn ON or OFF. > > > > index == -1 should be explained. > > > > If you are referring to the special way of setting the LED globally, > that is not a thing anymore. Rob pointed out that having the double > reference in DT is problematic and PHY driver should handle that > internally. So it sounds like you need to change > > > + * @index: Which LED of the PHY device or -1 to remove the 'or -1' Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel