From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11ACFC2BA19 for ; Wed, 15 Apr 2020 10:32:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF4DC206D9 for ; Wed, 15 Apr 2020 10:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iqAFOMfS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF4DC206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/jMcefJUNM+wbMOsM/6cZQACiq47PHiEMGX4LZQ9OIU=; b=iqAFOMfSnM4WVZL0kzsMwafgb klZL3JaFR5NtPs1NIS2McySvuR/FZQZVqNkonuFojuovBf20O9E9OOdkrzr0foGmFo2AuG36cmV2t h4ktyRpsmMryrAx/EEvXJtvQIejZrwlCsrkfqEVNFhlIBgCsLrlltPRcFQOwqcwRfEKigm5ml0KQS nECwZ/2CEFnTNCm7PRZfrUMt49Nxs6SNRfZnHhbqAlxHLoNd7KMAILkDjvxyo3aJIajQaiE7J+4yh CufbcEr6+Lh3rsz+d0eZ0uKuXbIPSbjF+5NHnIlb6rI5JGOrN+ePOPzzXbYDZiTT1QaXoJ98smup/ Ly0hhzVDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOfLU-0002fY-3D; Wed, 15 Apr 2020 10:32:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOfKt-00029K-Dm for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 10:32:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D90B1063; Wed, 15 Apr 2020 03:32:00 -0700 (PDT) Received: from [10.37.12.1] (unknown [10.37.12.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A70563F68F; Wed, 15 Apr 2020 03:31:58 -0700 (PDT) Subject: Re: [PATCH 5/8] arm64: cpufeature: Factor out checking of AArch32 features To: will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu References: <20200414213114.2378-1-will@kernel.org> <20200414213114.2378-6-will@kernel.org> From: Suzuki K Poulose Message-ID: <95817087-122e-0392-9474-c17ad1f926d2@arm.com> Date: Wed, 15 Apr 2020 11:36:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200414213114.2378-6-will@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_033203_513803_3295267D X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, saiprakash.ranjan@codeaurora.org, anshuman.khandual@arm.com, maz@kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, catalin.marinas@arm.com, kernel-team@android.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/14/2020 10:31 PM, Will Deacon wrote: > update_cpu_features() is pretty large, so split out the checking of the > AArch32 features into a separate function and call it after checking the > AArch64 features. > > Signed-off-by: Will Deacon > --- > arch/arm64/kernel/cpufeature.c | 108 +++++++++++++++++++-------------- > 1 file changed, 61 insertions(+), 47 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 7dfcdd9e75c1..32828a77acc3 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -715,6 +715,65 @@ static int check_update_ftr_reg(u32 sys_id, int cpu, u64 val, u64 boot) > return 1; > } > > +static int update_32bit_cpu_features(int cpu, struct cpuinfo_arm64 *info, > + struct cpuinfo_arm64 *boot) > +{ ... > - > if (id_aa64pfr0_sve(info->reg_id_aa64pfr0)) { > taint |= check_update_ftr_reg(SYS_ZCR_EL1, cpu, > info->reg_zcr, boot->reg_zcr); > @@ -845,6 +857,8 @@ void update_cpu_features(int cpu, > sve_update_vq_map(); > } > > + taint |= update_32bit_cpu_features(cpu, info, boot); > + This relies on the assumption that the id_aa64pfr0 has been sanitised. It may be worth adding a comment to make sure people (hacking the kernel) don't move this around and break that dependency. Either ways: Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel